From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2EBA24262F;
	Mon, 25 Sep 2023 03:13:33 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 00FE040266;
	Mon, 25 Sep 2023 03:13:33 +0200 (CEST)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
 by mails.dpdk.org (Postfix) with ESMTP id 1B99840144
 for <dev@dpdk.org>; Mon, 25 Sep 2023 03:13:30 +0200 (CEST)
Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.53])
 by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Rv4Xr45d5zMlpj;
 Mon, 25 Sep 2023 09:09:48 +0800 (CST)
Received: from [10.67.121.175] (10.67.121.175) by
 kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.31; Mon, 25 Sep 2023 09:13:28 +0800
Message-ID: <748f51fb-1282-8ee8-0183-4b83dbce0060@huawei.com>
Date: Mon, 25 Sep 2023 09:13:27 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v4 4/7] app/proc-info: fix never show RSS info
To: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, 
 Vipin Varghese <vipin.varghese@amd.com>, "Mcnamara, John"
 <john.mcnamara@intel.com>
CC: "lihuisong@huawei.com" <lihuisong@huawei.com>
References: <20230904072851.7384-1-haijie1@huawei.com>
 <20230908080030.3837515-1-haijie1@huawei.com>
 <20230908080030.3837515-5-haijie1@huawei.com>
 <BYAPR11MB33661B620BA9F573E6CD7F3EFFF0A@BYAPR11MB3366.namprd11.prod.outlook.com>
From: Jie Hai <haijie1@huawei.com>
In-Reply-To: <BYAPR11MB33661B620BA9F573E6CD7F3EFFF0A@BYAPR11MB3366.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.175]
X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To
 kwepemi500020.china.huawei.com (7.221.188.8)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2023/9/13 19:48, Pattan, Reshma wrote:
> 
> 
>> -----Original Message-----
>> From: Jie Hai <haijie1@huawei.com>
>> Sent: Friday, September 8, 2023 9:00 AM
>> To: dev@dpdk.org; Pattan, Reshma <reshma.pattan@intel.com>; Vipin
>> Varghese <vipin.varghese@amd.com>; Mcnamara, John
>> <john.mcnamara@intel.com>
>> Cc: haijie1@huawei.com; lihuisong@huawei.com
>> Subject: [PATCH v4 4/7] app/proc-info: fix never show RSS info
>>
>> Command show-port should show RSS info (rss_key, len and rss_hf), However,
>> the information is shown only when rss_conf.rss_key is not NULL. Since no
>> memory is allocated for rss_conf.rss_key, rss_key will always be NULL and the
>> rss_info will never show. This patch allocates memory for rss_conf.rss_key and
>> makes it possible to show RSS info.
>>
> 
Hi, Pattan, Reshma
> Nitpick:
> You have to change the commit message as malloc and free not used now.
> 
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
> 
> 
Thanks for your comment, will do in next version.

Best regards,
Jie Hai
> 
> 
> .