From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id BEB13ADA2 for ; Wed, 27 Jan 2016 18:08:16 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id l65so153243269wmf.1 for ; Wed, 27 Jan 2016 09:08:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=fAhP+dBzaXXzA6ruwtgyl+qvvaLSiEqWMwJy2dwwD4Q=; b=pxZ5Rn05kihOzb2KSAJIk6tsryddf3pW1X532atYPydDhgCA668BwDYvKQoTLF85r+ sdcK/ZnXT3SK4zZYh0NutWBy9Q0rlek58A/+NuvDF9a8o+Gs1ghbsQF0AoJrzcyBoK7U KZwuxvXwoK8mhiOs0QXsFNXUccFyGvJx/K1aR6wIMD+XAG+2fxeTXbbPI/AZIBgZnXhp a7OLlAN64QnnQXKmopp1UZx9LwWV1EKE0cGSTMY/fXWrOfFYne0cX20VqRPk6h2zDNzd CazHLKHgYPnZO3cxTDZYxr3kSSsLUERVzDIseYTQTTPQ+oRz9Xi0XZDiwkkrwd990fBJ haXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=fAhP+dBzaXXzA6ruwtgyl+qvvaLSiEqWMwJy2dwwD4Q=; b=Spv/27tmxFYGbTi3B2avkEVp/38AL5U+R9i+0VS5OKQRtWqaLggXB550uaM+zE/t3s DVcQhf9TClGvbBdAHy06y788fBhnjpMo2ez2vlp5uVX7VvTMhLuGIAGiGraVtjVc2La8 n2qO/mRr59+LJ2jq7+lEqJaGExNzup6nbnnfxD2dQWZJAFHdvgES01SoFHbnZMnp4r8v LFiSxu5kH7yU5u9tsbCQfCoB6RifPFG4KAStE25cfwuJDKPaN6l1XDRm5a/Qf6NRKQro 4RLZuexQPudvNAEHgpYebI7frXS0UWt6TxSN6LTgi1RlxIREUVp3NN26RaHlkt/t7o5i Qajg== X-Gm-Message-State: AG10YOQ2AV3xIULMTz4pt2/7Oj4kT0NYW+4NW5GWYvdoemJqfV2m9ZVQns7hA2lBx5To7hQC X-Received: by 10.28.222.86 with SMTP id v83mr29816109wmg.17.1453914496582; Wed, 27 Jan 2016 09:08:16 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id js8sm7093174wjc.37.2016.01.27.09.08.15 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 27 Jan 2016 09:08:15 -0800 (PST) From: Thomas Monjalon To: Anatoly Burakov Date: Wed, 27 Jan 2016 18:07:06 +0100 Message-ID: <7496408.z4nt1qSYiL@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1453913438-22991-1-git-send-email-anatoly.burakov@intel.com> References: <1453905124-28544-1-git-send-email-anatoly.burakov@intel.com> <1453913438-22991-1-git-send-email-anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5] vfio: Support for no-IOMMU mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2016 17:08:17 -0000 2016-01-27 16:50, Anatoly Burakov: > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > +int vfio_type1_dma_map(int); > +int vfio_noiommu_dma_map(int); WARNING:AVOID_EXTERNS: externs should be avoided in .c files I agree with checkpatch, they should be static ;) > --- a/lib/librte_eal/linuxapp/eal/eal_vfio.h > +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.h > +/* older kernels may not have no-IOMMU mode */ > +#ifndef VFIO_NOIOMMU_IOMMU > +#define VFIO_NOIOMMU_IOMMU 8 > +#endif Shouldn't it be defined privately in .c file?