From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECF63A04F3; Wed, 8 Jan 2020 16:57:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 895E11DA95; Wed, 8 Jan 2020 16:57:06 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 8FA771DA8F; Wed, 8 Jan 2020 16:57:04 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2020 07:57:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,410,1571727600"; d="scan'208";a="421483910" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga005.fm.intel.com with ESMTP; 08 Jan 2020 07:57:02 -0800 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.26]) by IRSMSX154.ger.corp.intel.com ([169.254.12.207]) with mapi id 14.03.0439.000; Wed, 8 Jan 2020 15:57:01 +0000 From: "Loftus, Ciara" To: "Wang, Xiao W" , "Ye, Xiaolong" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Wang, Xiao W" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/af_xdp: fix redundant check for NEED WAKEUP Thread-Index: AQHVxDacyTa70iJ1akqowmbe7kJpnKfg7Jzg Date: Wed, 8 Jan 2020 15:57:00 +0000 Message-ID: <74F120C019F4A64C9B78E802F6AD4CC279297B77@IRSMSX106.ger.corp.intel.com> References: <20200106140940.10124-1-xiao.w.wang@intel.com> In-Reply-To: <20200106140940.10124-1-xiao.w.wang@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: fix redundant check for NEED WAKEUP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Function kick_tx() has built-in detection on NEED_WAKEUP flag, so just > call it directly, like elsewhere in the driver. >=20 > Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiao Wang > --- > drivers/net/af_xdp/rte_eth_af_xdp.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c > b/drivers/net/af_xdp/rte_eth_af_xdp.c > index 2b1245ee4..d903e6c28 100644 > --- a/drivers/net/af_xdp/rte_eth_af_xdp.c > +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c > @@ -480,10 +480,7 @@ af_xdp_tx_zc(void *queue, struct rte_mbuf **bufs, > uint16_t nb_pkts) > tx_bytes +=3D mbuf->pkt_len; > } >=20 > -#if defined(XDP_USE_NEED_WAKEUP) > - if (xsk_ring_prod__needs_wakeup(&txq->tx)) > -#endif > - kick_tx(txq); > + kick_tx(txq); >=20 > out: > xsk_ring_prod__submit(&txq->tx, count); > -- > 2.15.1 Thanks for the patch. Tested-by: Ciara Loftus