From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1220A1B1C3 for ; Fri, 8 Dec 2017 22:08:18 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Dec 2017 13:08:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,379,1508828400"; d="scan'208";a="10914950" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.68]) ([10.241.225.68]) by fmsmga004.fm.intel.com with ESMTP; 08 Dec 2017 13:08:17 -0800 To: Ravi Kumar , dev@dpdk.org References: <1512047472-118050-1-git-send-email-Ravi1.kumar@amd.com> <1512047472-118050-10-git-send-email-Ravi1.kumar@amd.com> From: Ferruh Yigit Message-ID: <74aa2336-3ee5-70a4-a653-4bcf6a470bfd@intel.com> Date: Fri, 8 Dec 2017 13:08:16 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1512047472-118050-10-git-send-email-Ravi1.kumar@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 10/16] net/axgbe: add transmit and receive data path apis X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 21:08:19 -0000 On 11/30/2017 5:11 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar > --- > drivers/net/axgbe/Makefile | 1 + > drivers/net/axgbe/axgbe_ethdev.c | 56 ++++- > drivers/net/axgbe/axgbe_rxtx.c | 427 +++++++++++++++++++++++++++++++++++++ > drivers/net/axgbe/axgbe_rxtx.h | 19 ++ > drivers/net/axgbe/axgbe_rxtx_vec.c | 215 +++++++++++++++++++ You may rename this as axgbe_rxtx_vec_sse.c to clarify which arch it is for. <...> > @@ -190,6 +192,7 @@ static const struct eth_dev_ops axgbe_eth_dev_ops = { > .dev_start = axgbe_dev_start, > .dev_stop = axgbe_dev_stop, > .dev_close = axgbe_dev_close, > + .link_update = axgbe_dev_link_update, Can you please separate this into its own patch. <...> > @@ -545,8 +595,8 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev) > axgbe_set_bit(AXGBE_STOPPED, &pdata->dev_state); > pdata->eth_dev = eth_dev; > eth_dev->dev_ops = &axgbe_eth_dev_ops; > - eth_dev->rx_pkt_burst = NULL; > - eth_dev->tx_pkt_burst = NULL; > + eth_dev->rx_pkt_burst = &axgbe_recv_pkts; > + eth_dev->tx_pkt_burst = &axgbe_xmit_pkts_vec; It can be helpful to comment axgbe_dev_tx_queue_setup() can set non-vector Tx path. <...>