From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02B10A00C2; Thu, 6 Oct 2022 15:07:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96F1342C52; Thu, 6 Oct 2022 15:07:46 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D8C6242C3C for ; Thu, 6 Oct 2022 15:07:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665061665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j/PJ8onTW1dUSz/Ujvm27nTHijgBblhYjHFb0GFNtx4=; b=YRPzd8k/R+eSSBpbQ+O4ugedrQdmmscRAv0pt+/S240oGu0dXzquuzJ5L3YlWgf4uC/nRM uw3FVJ3YQtQxv9zvuHyfjkAudygfjKoiZ3tS4JW/YLE7rYIGBvTv+vFVk7PqB8ANQib5KK 83HW/WZfPuyf72+wSkw3o8IvfnsiSqs= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-179-qPbDr_0ZMAqgbU3QAfZRBg-1; Thu, 06 Oct 2022 09:07:42 -0400 X-MC-Unique: qPbDr_0ZMAqgbU3QAfZRBg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D5BD62932497; Thu, 6 Oct 2022 13:07:41 +0000 (UTC) Received: from [10.39.208.19] (unknown [10.39.208.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D024C15BA4; Thu, 6 Oct 2022 13:07:40 +0000 (UTC) Message-ID: <74b774a7-6519-1434-55e3-455140fcf71d@redhat.com> Date: Thu, 6 Oct 2022 15:07:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] net/virtio: remove declaration of undefined function To: Olivier Matz , dev@dpdk.org Cc: Chenbo Xia References: <20220929122218.1115-1-olivier.matz@6wind.com> From: Maxime Coquelin In-Reply-To: <20220929122218.1115-1-olivier.matz@6wind.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/29/22 14:22, Olivier Matz wrote: > This function is not defined, remove its declaration. > > Fixes: c1f86306a026 ("virtio: add new driver") > > Signed-off-by: Olivier Matz > --- > drivers/net/virtio/virtqueue.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h > index d100ed8762..f5d8b40cad 100644 > --- a/drivers/net/virtio/virtqueue.h > +++ b/drivers/net/virtio/virtqueue.h > @@ -474,10 +474,6 @@ virtqueue_enable_intr(struct virtqueue *vq) > virtqueue_enable_intr_split(vq); > } > > -/** > - * Dump virtqueue internal structures, for debug purpose only. > - */ > -void virtqueue_dump(struct virtqueue *vq); > /** > * Get all mbufs to be freed. > */ Reviewed-by: Maxime Coquelin Thanks, Maxime