From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Radoslaw Biernacki <radoslaw.biernacki@linaro.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] test/memzone: add test for memzone count in eal mem config
Date: Mon, 29 Jan 2018 09:40:01 +0000 [thread overview]
Message-ID: <74c843c4-6ecf-e645-0220-c232a4448f3a@intel.com> (raw)
In-Reply-To: <CAEK-wKn8d+vUEWbhSYRzP_4Td3L8yXH8shzbKnQWpfYn-dF-CA@mail.gmail.com>
On 27-Jan-18 2:53 PM, Radoslaw Biernacki wrote:
> Looks OK.
>
> Following note is aside from the patch.
> Might be beneficial (in some rare cases) to add bailout recovery with
> goto's in test_memzone_basic()
> Just in case one of the rte_memzone_reserve() we should not make return -1,
> but instead a goto to below section where we call rte_memzone_free().
> This way we would be able to free only the allocated memzones and prevent
> leaking out those memzones to other tests.
Thanks, and yep, it's on my todo list :) didn't get around to it yet.
>
> Reviewed-by: Radoslaw Biernacki <r <ferruh.yigit@intel.com>
> adoslaw.biernacki@linaro.com>
>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-01-29 9:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 17:40 Anatoly Burakov
2018-01-26 17:40 ` [dpdk-dev] [PATCH 2/2] test/memzone: handle previously allocated memzones Anatoly Burakov
2018-01-27 14:46 ` Radoslaw Biernacki
2018-01-31 7:51 ` Phil Yang
2018-01-31 10:05 ` Burakov, Anatoly
2018-01-31 10:08 ` Phil Yang
2018-01-27 14:53 ` [dpdk-dev] [PATCH 1/2] test/memzone: add test for memzone count in eal mem config Radoslaw Biernacki
2018-01-29 9:40 ` Burakov, Anatoly [this message]
2018-01-31 15:29 ` [dpdk-dev] [PATCH v2 " Anatoly Burakov
2018-02-01 0:12 ` Thomas Monjalon
2018-02-01 10:05 ` Burakov, Anatoly
2018-02-01 10:02 ` [dpdk-dev] [PATCH v3 " Anatoly Burakov
2018-02-01 10:14 ` [dpdk-dev] [PATCH v4 " Anatoly Burakov
2018-02-06 0:49 ` Thomas Monjalon
2018-02-01 10:14 ` [dpdk-dev] [PATCH v4 2/2] test/memzone: handle previously allocated memzones Anatoly Burakov
2018-02-01 10:02 ` [dpdk-dev] [PATCH v3 " Anatoly Burakov
2018-01-31 15:29 ` [dpdk-dev] [PATCH v2 " Anatoly Burakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74c843c4-6ecf-e645-0220-c232a4448f3a@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=radoslaw.biernacki@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).