From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F356440E8; Mon, 27 May 2024 18:08:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35552402D4; Mon, 27 May 2024 18:08:05 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 1E7D5402C5 for ; Mon, 27 May 2024 18:08:04 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id CDB361F782 for ; Mon, 27 May 2024 18:08:03 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id C109D1F71C; Mon, 27 May 2024 18:08:03 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.3 Received: from [192.168.1.59] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id AF4471F65A; Mon, 27 May 2024 18:08:01 +0200 (CEST) Message-ID: <74e169b4-3b28-498d-9af1-c60e6aeb82fa@lysator.liu.se> Date: Mon, 27 May 2024 18:08:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] event/dsw: support explicit release only mode To: Jerin Jacob , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: Jerin Jacob , dev@dpdk.org, bruce.richardson@intel.com, Peter Nilsson J , =?UTF-8?B?U3ZhbnRlIErDpHJ2c3Ryw6V0?= , Heng Wang References: <20231109183323.2880-1-mattias.ronnblom@ericsson.com> <20240524192437.183960-1-mattias.ronnblom@ericsson.com> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-05-27 17:35, Jerin Jacob wrote: > On Sat, May 25, 2024 at 1:13 AM Mattias Rönnblom > wrote: >> >> Add the RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE capability to the >> DSW event device. >> >> This feature may be used by an EAL thread to pull more work from the >> work scheduler, without giving up the option to forward events >> originating from a previous dequeue batch. This in turn allows an EAL >> thread to be productive while waiting for a hardware accelerator to >> complete some operation. >> >> Prior to this change, DSW didn't make any distinction between >> RTE_EVENT_OP_FORWARD and RTE_EVENT_OP_NEW type events, other than that >> new events would be backpressured earlier. >> >> After this change, DSW tracks the number of released events (i.e., >> events of type RTE_EVENT_OP_FORWARD and RTE_EVENT_OP_RELASE) that has >> been enqueued. >> >> For efficency reasons, DSW does not track the *identity* of individual >> events. This in turn implies that a certain stage in the flow >> migration process, DSW must wait for all pending releases (on the >> migration source port, only) to be received from the application, to >> assure that no event pertaining to any of the to-be-migrated flows are >> being processed. >> >> With this change, DSW starts making a distinction between forward and >> new type events for credit allocation purposes. Only RTE_EVENT_OP_NEW >> events needs credits. All events marked as RTE_EVENT_OP_FORWARD must >> have a corresponding dequeued event from a previous dequeue batch. >> >> Flow migration for flows on RTE_SCHED_TYPE_PARALLEL queues remains >> unaffected by this change. >> >> A side-effect of the tweaked DSW migration logic is that the migration >> latency is reduced, regardless if implicit relase is enabled or not. >> >> Signed-off-by: Mattias Rönnblom > > > 1) Update releases for PMD specific section for this new feature Should the release note update be in the same patch, or a separate? > 2) Fix CI issue as applicable > > https://patches.dpdk.org/project/dpdk/patch/20240524192437.183960-1-mattias.ronnblom@ericsson.com/ > http://mails.dpdk.org/archives/test-report/2024-May/672848.html > https://github.com/ovsrobot/dpdk/actions/runs/9229147658