From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0EA542DD6; Wed, 5 Jul 2023 10:02:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7C21406BC; Wed, 5 Jul 2023 10:02:46 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2056.outbound.protection.outlook.com [40.107.212.56]) by mails.dpdk.org (Postfix) with ESMTP id 42A8A40150 for ; Wed, 5 Jul 2023 10:02:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HWr10TyP1TbmtYx6eWeCzYiFOA0AJI0N5eiOnD89XxfRLOa+MYu9YedUglOk+Jjg7UvmDEyG+pgQkLxZ+bebCwQlLW4A42kp4DhuMOgEYLzHATbD4BVGoaGyTbH1M9gJUrxnPZjhKkbTQzyqh5g7LW/A7/dpqhLEed6GjVeiBKZ1D27Hp7y3fX/FL5ZQbxXjI6b4p1n0PtrxfGw48O9I0rF/JRWyidaFhpeJ+Zoy61h21Rpv1Eg69zIU3smZjzPzfYp0XVLe3yyC6IFKSFYqddlSmFY9gx4T1ZOl1HJrvB6hbyRDnMrEVKiHqfWubgGXMdfqMn+Czq8y5VkaKflH7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gQNJ6KQkjYdNqBb7sjOqXa2jnBUUFsmAPmvsD05uRvo=; b=AcE5FChqvgQbjA4OwOEUimUONYv1DlvK40CkcfiCXiTDRZrkPG17J4tX3qve1xn0whuMpcFNFM39nIEDOKMYC06HmDtjSOBBtSWRzGR9o5u6+k+v5XztBZ1Ph43wklwlu//WKSRi1bxhdp/35ltY/ojLU4CqzNQ9bHu3jV9ztf6Ac55l8aGsfFlCfUGNR7xahdPkdM92xb4wnlqsd753KEfkgxpau6QzXhXI5GRspzV45m8YzVGMvNlZIFP+GRT055ADfuLJUuUUQYRta0DPlbT8GiUnCH+A+OybCHEv3wjeHWBd3k3/Fqzziw/tp1mFY3jofytKtc1mhc1Gv+lKZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gQNJ6KQkjYdNqBb7sjOqXa2jnBUUFsmAPmvsD05uRvo=; b=1x+ISn84P8rb4w6uh7wmj8bWFdAXZXWH6OzX2BKwPtlrgIXTRilednYPE30vjDjuk0yp0oPen/3Y1q8FGHXE7pLcqw6mmR6oSZZ/AEpCVk0whxt2m87R+ayux6E2dnMxssZckf5mNDUYYODdcu+9dWTqpY8Bvf8QEPjZiwZPGTQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB5261.namprd12.prod.outlook.com (2603:10b6:5:398::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Wed, 5 Jul 2023 08:02:43 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8%3]) with mapi id 15.20.6565.016; Wed, 5 Jul 2023 08:02:43 +0000 Message-ID: <74fb4fc2-6497-0ba9-e95d-71da03afd76e@amd.com> Date: Wed, 5 Jul 2023 09:02:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port Content-Language: en-US To: "lihuisong (C)" , Jie Hai , Aman Singh , Yuying Zhang , Shiyang He , "Jiale, SongX" Cc: dev@dpdk.org, liudongdong3@huawei.com, alialnu@nvidia.com, "Mcnamara, John" , Qi Z Zhang , Thomas Monjalon , David Marchand References: <20230703110232.28494-1-haijie1@huawei.com> <20230704084507.12788-1-haijie1@huawei.com> <29d89a6b-49e0-8789-411f-6a89db177b91@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0174.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB5261:EE_ X-MS-Office365-Filtering-Correlation-Id: 472fd273-7032-4b9e-cb68-08db7d2e35f3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SwyS4GHWgolOQJQk5tgAGRGqyx2xNjZmJNY/J/NqFFgTYBURd8L1n3lMt7xA7az+/chsDptU13Mn6xXOxoI/CNohIefchNuRKfGK4CoXH/Sh9aIwfpqua1m5ifsBy3R6hoWpzV629wm5Q/kCPdC2AudNNn7tZMbbetZVkMF5KpRfUYUpbLGq8W2GFGqdqjZdH55WQBSbaDnSlF7gAhM4zFj1gI10e6BnhAUIdt08h9N20zEUFttCgGI3ndUhBh0Q9by0l9J1WXGlLUEVSwFzDOY1tv83ikQ+pFSGDVFPO+jBqWMtKPvlcQv3Yp1KdPB4UoXkqP85vzyPq8SJh4jzg6KOo3ZsEtzGctz+7VxVgu/tT1r0syXIoXbxE+JpVlSvkQwWCg4ObXeEOdvyVPJmzqJGmWBydyWpA/9uvF6/90epeCL3t5mJvOHzuG7qX7lYORIJ7bAh2YE6f44Qj1MymVAxSbASFLiji6pIFCpBE4hfSiAu+QZ/gxdeaRWQwBxnj7xrsl2W4tynVBxlK37+inYzoT/UI42GxCYNvWSc1AA2gByVVwno9ZXmJwTAGLbedLUg4o9EbcOp7DsUA6frkHjdipJPEL9S1yb19+SKoYAhmJ3tjBazdBUzeCbfBYrpK3H5/RMF+B/DOTz54UsnyA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(396003)(376002)(366004)(346002)(39860400002)(451199021)(8676002)(110136005)(54906003)(8936002)(478600001)(26005)(6666004)(41300700001)(36756003)(6486002)(7416002)(2906002)(31696002)(5660300002)(44832011)(31686004)(86362001)(4326008)(316002)(66556008)(6506007)(66946007)(66476007)(38100700002)(53546011)(6512007)(2616005)(186003)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUozUWZXcE5FelE4NmRNeHZpR3JFYUpDZFJWKysrckFtZ1FEcGF5UU5iYkFa?= =?utf-8?B?bVppRnREYkxtcFJSOC9FRGQwZU9zeFcrQko4YkFFT3ZydFBwNlNuM1l5b2Q3?= =?utf-8?B?VUo3ekphN09sUks1N0o4UFk1d3lVWjkwaC9LZWM5ZFVpZzdRTjB5K1VhYkNy?= =?utf-8?B?ZzRkYi9UQWFTbHFGSCsxNUZGd0hrQUtSazhROERUZkRBeVIyQThYNTlHdi9u?= =?utf-8?B?QUd0VnpndEZoc2tGZHRYYWxWTmRUOHh2bXM0NU53a1FId3FMdVNnSGNOVDg3?= =?utf-8?B?TFEyajBmMFBqRUpML3dxLzdTTGd4YVBJVURVWFhYUVJFVjFJL00zSTh5ajlO?= =?utf-8?B?bnhKSVNqbXdRd1dBSWdGcjFlU3pwMjU3MW1tVnhFeWlHOFRidi80eFl1c04y?= =?utf-8?B?VFJUU0tWNzVUQndUU05aVEM0YVpxZmNpaisxS01DT2Q1TXVXY1lSclZ2b0pm?= =?utf-8?B?R01GS1o3ZnI3b3dVUTUzVWRSVG9HYXFOWTlqVTFPbXVGVklaVElHSDhOckM1?= =?utf-8?B?NXhYZGlKekgwMDhReHdvUlNjeFkrNktUUXdKWlYwdjQ3ZDBHMmpNQlBGN3ZI?= =?utf-8?B?Tzl2UUFmai81RWhVQlY2a2EvZmZ1bkZDc01qWmNUZU5mc2g1ZFZ4MFRUUlY5?= =?utf-8?B?QjNpUXkzR2RqZFpjZSs4eE1DUHBXZ0JGaXNpemwzNThJM2NYbUU2V3N4RUcx?= =?utf-8?B?dTdzaldVV2w1YnR5VEpVN2NMeWVMSTFnTC9ZTUhxQmtNTDJJVXZEVG5pSEN6?= =?utf-8?B?K0Ryd01kS3g5UHg5ZW5GUG4zWmhORmZCZmxQOVNYYU9rVXdZbkZoeXk4TkFM?= =?utf-8?B?eGNGVUluVVpCVWswNFNzWmFVR0cxeE1acEtXakJoL3R0dHJYK1U2TWNvQ3lS?= =?utf-8?B?YmorakJEd3Z4NzRERjZxMFhwR1J5MG1zZXMwYnQyZVI3aVgrVG1wdjEwdy9L?= =?utf-8?B?UUl3SWgwRHhUQ1VZZHBpRUlmanhXVVgrNzZNS1hPT2ZoRnc1VDI3WElvZlBy?= =?utf-8?B?Zzc5bU5Rb3U3dmpoaG5RTkpkSGdXbXdXdGpIK1ZJWVR4akJJZk1tckRZTFAw?= =?utf-8?B?bURZOU1LQng2bnZ3UHA2QUxIbG55SXNlYlZNK25TNjFBL1NrUEN2NHMxSjFh?= =?utf-8?B?OTlubXFHZHJWcXRLUVJORTNrZFVmTS9vVjB6NDIyd2VrRU43ci84ZzMwalNT?= =?utf-8?B?V25lcmErMWdSSERrekVwaTlqR0RwSlFKNjI4cEVRVjNRR0ppUDdtaDZnRmUv?= =?utf-8?B?eU9HZk5vQmo2ZTNFbWV3TGJBS0NWOStXcVlXOVVTYkJmdTUyTUR6WFlsN1NO?= =?utf-8?B?TlJpOE45aERvTEdKK3pVaVNKS0NEK0N3cWlHZVhCdnIvaGpBVkJCN2JPOUFm?= =?utf-8?B?WkNwUHZ3NlNRNys5c0NSZ29nODJuTEJxWVZRVXVmUEkyRTNUY2YxaVN6TTll?= =?utf-8?B?VFBDZFI2R0VBMFExYTRhVXpuRzBPTGMyNXN3NXNiZ3pJK0pKeHdhbUhxR0lx?= =?utf-8?B?RzQwRGVRbTQxVmdhSG1xOGpWcVpUakl3Z1Fmc3VZNS96TG9DckM4Q3F1d1BM?= =?utf-8?B?TTNqaG9Zdjh1Z093WjUvdDV3K2E0aEt4dHpLU1RhbGVoTmRPUEFDOG44RWtu?= =?utf-8?B?N1BtRG1ML214aUtEcWpKeUwxanYrQUE1K3V4a0lTK3FNTHV1OElVeUUrWHps?= =?utf-8?B?TTZTRkhYdk80d2h4cVNpZWVDZjlDZ1A3OW9GRTZBZGJTRFMyaDdNaUd4bjhR?= =?utf-8?B?bjZBU2JSUVZldDBBT0w2UmVkeTByVmtFZnVkeTVBQmdNd0ZXUWVVMmhjNFJJ?= =?utf-8?B?dTJsRDZTc0l5RElPQnRJNWZ3TkFiNzBpWUtqd1BxcnZ2c0lHaEFKWHVIazB4?= =?utf-8?B?UVB3cnIxcmtpUGlMZTlNUjMxcGlwT2xqOFl5K0xTN2NKU1Q4WExINFRaMUUw?= =?utf-8?B?VDNNSU8rdU9XVVlGZm9oQjhxM3FlNjEzSUlJOWNmcUgzNXA1R1BOT0p6b0Rq?= =?utf-8?B?QVRSZXgyN0lNRnpoYkZaeDhHQ0l5MFNNaStEcVNLVTBJMmNyVUhRMmxTbWVB?= =?utf-8?B?UEFRUHNIRnp1U0xsSGJwL0x3UnJOMS83NnB3YlNXMlhvWEVSZVYxb09tbUZv?= =?utf-8?Q?JLAhWPAGippbv5sBgyTpFNayD?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 472fd273-7032-4b9e-cb68-08db7d2e35f3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 08:02:43.2322 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D+mn2n4kfLM8ZwoHePhGr/TNVhdShZ+i1hc13xACXt5io3ZeePPDhKv1HPypq8L3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5261 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/5/2023 4:16 AM, lihuisong (C) wrote: > > 在 2023/7/4 18:59, Ferruh Yigit 写道: >> On 7/4/2023 9:45 AM, Jie Hai wrote: >>> Function update_queue_state updates queue state of all queues >>> of all ports, using the queue num nb_rxq|nb_txq stored locally >>> by testpmd. An error on the invalid queue ID occurs if we run >>> testpmd with two ports and detach-attach one of them and start >>> the other port first. This is because the attached port has not >>> been configured and has no queues, which differs from nb_rxq|nb_txq. >>> The similar error happens in multi-process senoris if secondary >>> process attaches a port and starts it. >>> >>> This patch updates queue state of the specified port, which has >>> been configured by primary process. As the secondary process >>> cannot configure the ports, make sure that the secondary process >>> starts the port only after the primary process has done so. > Now look good to me. > Acked-by: Huisong Li >>> >>> Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling >>> all queues") >>> Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet >>> forwarding") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Jie Hai >>> >> The problem description and solution looks reasonable to me, but Intel >> testing still reporting the issue. >> >> There is a chance that the issue Intel side observing is different, >> waiting for more information from Intel test team. >> >> . Hi Song, As far as I understand this patch works with an update from ixgbevf driver, can you please confirm? And can we have the ixgbevf fix soon, to not block the -rc3? Thanks, ferruh