From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4237BA0546; Fri, 14 Feb 2020 08:59:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CEDF1BE8E; Fri, 14 Feb 2020 08:59:27 +0100 (CET) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 8952D1BE80 for ; Fri, 14 Feb 2020 08:59:25 +0100 (CET) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200214075924euoutp02c9c998033e9a93185c5d53ab735224f1~zNegNsQzG2890828908euoutp02e for ; Fri, 14 Feb 2020 07:59:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200214075924euoutp02c9c998033e9a93185c5d53ab735224f1~zNegNsQzG2890828908euoutp02e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1581667164; bh=Rz7pKH/U5hUQUX/uoVkc/TmiWK3qJlhN1Mupa5moI5c=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=Mj2q//YQNcdoxWQkci8Q0tDG5L+03P678tCZpZrjdnIjVdrlSQ0aD0bDsYLcLhspd GK/biXH9CaLX5lK2BYiIJFlvXHZJECh1duCcA/d92o8IpoOCIGduPMy1qdA1fEIZ6Y 2pcdYCHjXmT/sAuIP1ggqlWh6EBxEGFbq7vJ+k0U= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200214075924eucas1p27c2f23b79acb6c0a5f2a8bade1d98d02~zNegHLqCK0329003290eucas1p2E; Fri, 14 Feb 2020 07:59:24 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 82.ED.60679.C53564E5; Fri, 14 Feb 2020 07:59:24 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200214075924eucas1p1825d9e39f22125aab0fc8be1db2a1e1d~zNefnKUpU0279202792eucas1p1V; Fri, 14 Feb 2020 07:59:24 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200214075924eusmtrp1f1b59ac9884193f5927a6566ae41ba55~zNefmk5RG1786317863eusmtrp1w; Fri, 14 Feb 2020 07:59:24 +0000 (GMT) X-AuditID: cbfec7f4-0e5ff7000001ed07-8e-5e46535c4f06 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 8A.E7.07950.C53564E5; Fri, 14 Feb 2020 07:59:24 +0000 (GMT) Received: from [106.109.129.29] (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200214075923eusmtip29b97424f9d81ef5f55e36d568568b461~zNefS_Jlm3180931809eusmtip2R; Fri, 14 Feb 2020 07:59:23 +0000 (GMT) To: Maxime Coquelin , Tiwei Bie Cc: dev@dpdk.org, amorenoz@redhat.com From: Ivan Dyukov Message-ID: <75063e92-7d17-cc54-836f-8e7e88949d05@samsung.com> Date: Fri, 14 Feb 2020 10:59:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <4ab7f816-18b6-c098-81a1-57c36941e81c@redhat.com> Content-Language: ru-RU X-Brightmail-Tracker: H4sIAAAAAAAAA1WSazCUYRTHPe/77u5r2XotjZPLlDUilUv5oJlCF8b0qcZMusrGG+s+u+4+ xBjG7YMQY3OXMhhK7hm3XEY7SYYYQ8OMmpGiXCZsS7uerdG33/mf/znP+c88NCn8zDGhJWGR rDRMHCLi8qmWwa33p+54efg4jE7aOqe0zVHOy6uthPNgeifl3Jy4S7hRnttlVRzPys5FwnOl a4J7lbzFP+fPhkiiWam9iy8/sH/LN2KzA8U+UuWhRNRfjzKQLg2ME5QPtZMaFjLVCHYTXTMQ X83rCF7VbnJxsYZA2aL8N1G6WM/DjecImht/IlysIKhZa+BoXIbMeejJnyUyEE0bMV5QXuuo kUnGCuSv3+1ZuIwNKNJKCA0LGBeoai3dY0rtmUxK52n4EHMD8lt3EPYYwHDhAqVhXbVfNTJG 4J3XoX62l4PZGH609u5dDcwzHnzM2iHx1ZdBVaekMBvC16EmHmYzUORmafUE+NU4ycPDaQg+ VaRoTa7QtDTC04QB5gL0VQZiPABT3w3wuwcgp6WAxLIA0lKFeFAEPcNjWhlApdTHsics5Vbw spGFfF8w+b4w8n1hMB+B5OYnpFy9iWSOQ0OHPZaDoLmujMRsAylFxbz/7XhN93iqli0gL3Ne 67GGt51PyTKkV4OM2ShZaAArOx3GxtjJxKGyqLAAO7/w0Eak/nyKnaH1NtTx+34fYmgk0hdU n/DwEXLE0bK40D4ENCkyEryxUEsCf3FcPCsNvyeNCmFlfciUpkTGgjMVi3eFTIA4kg1m2QhW +rdL0LomiSg4trFr9NvADP/YyTQd85u3N/ML9B0fEtNHX5bY2m9ILIsee3Mz3K4kD/Q2jZX6 WaeET1/rlMSLFZIcxy8O7maqmB7LmLhoCydO9pRVi97GweJYxUT7pnLBnJ06vGqYsBbknTQ/ N3Np3EoncDv64ofiiLPD7i+WH/RUZeZ2FxKWpiJKFih2tCWlMvEfnEXOungDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsVy+t/xe7oxwW5xBl1H+SxadzxgsXj3aTuT xbHOPSwWWxv+MzmwePxasJTVY/Gel0we7/ddZQtgjtKzKcovLUlVyMgvLrFVija0MNIztLTQ MzKx1DM0No+1MjJV0rezSUnNySxLLdK3S9DL+Nb+m63go3rF9vc32BsYj8h3MXJySAiYSMx/ uY69i5GLQ0hgKaPE1tfngRwOoISExOsnzBA1whJ/rnWxQdS8ZZS4ubCXDSQhLGArcWDaXSYQ W0QgWOLdvCXsIDazgKrErN1nWUFsIYHDTBLTpnqA2GwCGhKnO+aB1fMK2Eks3T4fzGYBqr/e 2AnWKyoQIfF4YjsjRI2gxMmZT1hAbE6g+r/nLjFBzA+TOLStG2qXuMSH7QfZJjAKzkLSMgtJ 2SwkZRC2mcS8zQ+ZIWx5ieats4FsDiBbTWJZqxKy8AJG9lWMIqmlxbnpucVGesWJucWleel6 yfm5mxiBEbft2M8tOxi73gUfYhTgYFTi4XWwco0TYk0sK67MPcQowcGsJMJ7WNEtTog3JbGy KrUoP76oNCe1+BCjKdDPE5mlRJPzgckgryTe0NTQ3MLS0NzY3NjMQkmct0PgYIyQQHpiSWp2 ampBahFMHxMHp1QDo8kpQxaGmF/Lf96IlInrkxMN/p+2KmzOcxZfh1vFDcdsei5lPDh4eXPB q7UPthbc42hfubprtZzdUb3J7jvMuDe9DDM6NXfN+v4bN60idoVrztSaUmIrFNT1/b7p7qn7 mea9//aPx5Xl7bep/XxCyuKHLyycnHWEZZPWwell3/zn3Wi9tSUnfbYSS3FGoqEWc1FxIgCr ToVUzgIAAA== X-CMS-MailID: 20200214075924eucas1p1825d9e39f22125aab0fc8be1db2a1e1d X-Msg-Generator: CA X-RootMTR: 20200207112542eucas1p149c88c52b887aab888351eab73fe7639 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200207112542eucas1p149c88c52b887aab888351eab73fe7639 References: <20200207112526.11455-1-i.dyukov@samsung.com> <20200207112526.11455-2-i.dyukov@samsung.com> <20200212103528.GA786542@___> <4ab7f816-18b6-c098-81a1-57c36941e81c@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/virtio: add link speed devarg X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Maxime, 13.02.2020 16:54, Maxime Coquelin пишет: > Hi Ivan, > > On 2/12/20 11:40 AM, Maxime Coquelin wrote: >> >> On 2/12/20 11:35 AM, Tiwei Bie wrote: >>> On Fri, Feb 07, 2020 at 02:25:26PM +0300, Ivan Dyukov wrote: >>>> Some applications like pktgen use link_speed to calculate >>>> transmit rate. It limits outcome traffic to hardcoded 10G. >>>> >>>> This patch adds link_speed devarg which allows to configure >>>> link_speed of virtio device. >>>> >>>> Signed-off-by: Ivan Dyukov >>>> --- >>>> doc/guides/nics/virtio.rst | 7 ++ >>>> drivers/net/virtio/virtio_ethdev.c | 101 ++++++++++++++++++++++++----- >>>> drivers/net/virtio/virtio_pci.h | 1 + >>>> 3 files changed, 92 insertions(+), 17 deletions(-) >>> Maybe I missed something.. Why not enable the VIRTIO_NET_F_SPEED_DUPLEX >>> support directly? When that feature is supported and negotiated, >>> we will ignore this devarg? >> IMHO, yes. When VIRTIO_NET_F_SPEED_DUPLEX will be implemented and >> negotiated, this devarg will be ignored. >> >>> If we want this devarg, it looks better to support it in virtio-user >>> as well (most code is shared between virtio-PMD and virtio-user). >> That's a valid point, Virtio-user should also support it. >> Ivan, can you send a new revision with Virtio-user support as well? > Do you plan to submit the new revision today? I have a lot of work which is not related to opensource contribution. I need few days to prepare the patch. Best regards, Ivan > > Thanks, > Maxime > >> Thanks, >> Maxime >> >>> Thanks! >>> Tiwei >>> >