From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 96A3BA046B
for <public@inbox.dpdk.org>; Tue, 23 Jul 2019 15:56:39 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id CCCC01C012;
Tue, 23 Jul 2019 15:56:38 +0200 (CEST)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by dpdk.org (Postfix) with ESMTP id 7512B1C00D
for <dev@dpdk.org>; Tue, 23 Jul 2019 15:56:37 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga006.jf.intel.com ([10.7.209.51])
by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
23 Jul 2019 06:56:36 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,299,1559545200"; d="scan'208";a="174550292"
Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.83])
([10.237.220.83])
by orsmga006.jf.intel.com with ESMTP; 23 Jul 2019 06:56:33 -0700
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"Stojaczyk, Dariusz" <dariusz.stojaczyk@intel.com>,
David Marchand <david.marchand@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <1562795329-16652-1-git-send-email-david.marchand@redhat.com>
<BYAPR18MB24248F465CD67C4654F497F1C8C70@BYAPR18MB2424.namprd18.prod.outlook.com>
<3397bb38-115b-40e8-c208-006fa5dd7405@intel.com> <1862469.LujG46irEj@xps>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <751d0163-ed33-e05b-dd24-386055114384@intel.com>
Date: Tue, 23 Jul 2019 14:56:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <1862469.LujG46irEj@xps>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 23-Jul-19 11:25 AM, Thomas Monjalon wrote:
> 23/07/2019 11:57, Burakov, Anatoly:
>> A machine without an IOMMU shouldn't have picked IOVA as VA in the first
>> place. Perhaps this is something we could fix? I'm not sure how to
>> detected that condition though, i don't think there's a mechanism to
>> know that for sure. Some kernels create a "iommu" sysfs directories, but
>> i'm not too sure if they're 1) there for older kernels we support, and
>> 2) always there.
> [..]
>> On my machine, "/sys/devices/virtual/iommu" exists when IOMMU is
>> enabled, but doesn't exist if it isn't ("/sys/class/iommu" exists in
>> both cases, but is empty when IOMMU is disabled). Perhaps we could go
>> off that?
>
> Yes, good idea.
> We need to check how these sysfs entries are managed,
> and how old they are by looking at Linux code history.
>
Quick (and by no means thorough) Google reveals that IOMMU driver's
sysfs-related code dates back as far as kernel version 3.17:
https://elixir.bootlin.com/linux/v3.17.8/source/drivers/iommu/iommu-sysfs.c
I'm not a kernel code expert, but the code *looks* like it's creating an
IOMMU-related entry in sysfs. So, i take it we can be reasonably sure of
these entries' presence at least since v3.17 onwards? Do we support
kernels which don't have this code?
--
Thanks,
Anatoly