From: Luca Boccassi <luca.boccassi@gmail.com>
To: David Hunt <david.hunt@intel.com>, dev@dpdk.org
Cc: richael.zhuang@arm.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [20.11.3] test/power: fix CPU frequency when turbo enabled
Date: Fri, 13 Aug 2021 18:41:30 +0100 [thread overview]
Message-ID: <753fdf5fba68d8faf90b53a6d4fd8699c4a80d88.camel@gmail.com> (raw)
In-Reply-To: <20210813141830.15397-1-david.hunt@intel.com>
On Fri, 2021-08-13 at 15:18 +0100, David Hunt wrote:
> On arm platform, the value in "/sys/.../cpuinfo_cur_freq" may not
> be exactly the same as what was set when using CPPC cpufreq driver.
> For other cpufreq driver, no need to round it currently, or else
> this check will fail with turbo enabled. For example, with acpi_cpufreq,
> cpuinfo_cur_freq can be 2401000 which is equal to freqs[0].It should
> not be rounded to 2400000.
>
> This is a version of the patch for 20.11.3 that fixes this issue
> withouth the dependency of having the CPPC support applied first
> (modified version of 29343b9030e38e8c3519ba01cb66724d45b13dc8)
>
> Fixes: 606a234c6d360 ("test/power: round CPU frequency to check")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
> app/test/test_power_cpufreq.c | 25 ++++++++++++++++---------
> 1 file changed, 16 insertions(+), 9 deletions(-)
Acked-by: Luca Boccassi <luca.boccassi@microsoft.com>
Applied and pushed, thanks (next time, please don't include
dev@dpdk.org but only stable, given it's a backport - otherwise it gets
filtered).
--
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2021-08-13 17:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 14:18 David Hunt
2021-08-13 17:41 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=753fdf5fba68d8faf90b53a6d4fd8699c4a80d88.camel@gmail.com \
--to=luca.boccassi@gmail.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=richael.zhuang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).