DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] virtio: fix buffer leak on vlan insert
Date: Wed, 17 Apr 2019 09:56:47 +0200	[thread overview]
Message-ID: <7550b248-534a-8ffb-5aa3-37d576df59ac@redhat.com> (raw)
In-Reply-To: <20190405163115.5068-1-stephen@networkplumber.org>



On 4/5/19 6:31 PM, Stephen Hemminger wrote:
> The function rte_vlan_insert may allocate a new buffer for the
> vlan header and return a different mbuf than originally passed.
> In this case, the stored mbuf in txm[] array could point to wrong
> buffer.
> 
> Fixes: dd856dfcb9e7 ("virtio: use any layout on Tx")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> v2 - catch a couple more places.
>       The virtio code needs some refactoring to not have 3 copies of same
>       loop...
> 
>   drivers/net/virtio/virtio_rxtx.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 

Applied to dpdk-next-virtio/master.

Note that I fixed the commit title so that it passes check-git-log
script.

Thanks,
Maxime

  parent reply	other threads:[~2019-04-17  7:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-05  0:03 [dpdk-dev] [PATCH] " Stephen Hemminger
2019-04-05  0:03 ` Stephen Hemminger
2019-04-05  7:43 ` Jens Freimann
2019-04-05  7:43   ` Jens Freimann
2019-04-05 16:31 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2019-04-05 16:31   ` Stephen Hemminger
2019-04-08  9:21   ` Jens Freimann
2019-04-08  9:21     ` Jens Freimann
2019-04-17  7:16   ` Maxime Coquelin
2019-04-17  7:16     ` Maxime Coquelin
2019-04-17  7:56   ` Maxime Coquelin [this message]
2019-04-17  7:56     ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7550b248-534a-8ffb-5aa3-37d576df59ac@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).