From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 41D1A1D9E for ; Tue, 22 May 2018 23:45:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DC69221B32; Tue, 22 May 2018 17:45:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 22 May 2018 17:45:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=mTbQT8eD3GSW8GruLsJPO0PkyV JA1uTmj8wdPg2/nig=; b=jjsx+KErILUIqvhYNNoRLFyiHzFi44s+M2EwgPwdmo BVcPMvLIuRYShUvCSZWUA4VHn1jhy8/kJwHMAj1MRviri+0MEaQr8g7+Po5mq06E Bam6d+z+gAklBrZX1JKEZJhzJli3PX7yY9RrHgtOrBPxiFxSnLHgwcF16IWV4Bjk Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=mTbQT8 eD3GSW8GruLsJPO0PkyVJA1uTmj8wdPg2/nig=; b=XStIehGLL8Te4w/R+hiVHh I2fkZE2pS2T9pAv47NzYn0q3VXu7IVWFPuyM1bSNWCZ7jxAcqtue673Ul9RQ1RvZ BvP6xaIhAUdSgaAdT1PJHbuUNdbRDHBQBNotA5dDYvB+1+Gec7m9ig1M8KyRnJXR wFnflcMFmaBM9xy7/7m0XOdMD4Go5JKJMrEG0uFAW8I8T6HnZmkEvCi1eZoA8eFX VQv7UWxSDuYQ7LgjlMgdid6b2ER5BbWcXQTHSINxzeT0dM8V8vZ1pCMyqXYX7MG+ QB0aJVp2aW9t+b8f8BUM6AD4cyUqyF0izzzTafT553ujQTBg34OpcWX1AdAXXOqg == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0CBF1E4434; Tue, 22 May 2018 17:45:31 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , Baruch Siach Cc: "Mcnamara, John" , "Yigit, Ferruh" , "dev@dpdk.org" Date: Tue, 22 May 2018 23:45:31 +0200 Message-ID: <7564883.QMXTE167Kr@xps> In-Reply-To: <20161219171434.GA188176@bricha3-MOBL3.ger.corp.intel.com> References: <2dfce93f986deb95eb5ac4773e020005d45f0c48.1481629710.git.baruch@tkos.co.il> <20161219171434.GA188176@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] gitignore: ignore top level build/ directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 21:45:33 -0000 19/12/2016 18:14, Bruce Richardson: > On Mon, Dec 19, 2016 at 04:50:57PM +0000, Mcnamara, John wrote: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > > On Mon, Dec 19, 2016 at 03:05:20PM +0100, Thomas Monjalon wrote: > > > > 2016-12-13 12:02, Ferruh Yigit: > > > > > On 12/13/2016 11:48 AM, Baruch Siach wrote: > > > > > > RTE_OUTPUT defaults to build/. > > > > > > > > > > > > Signed-off-by: Baruch Siach > > > > > > > > > > There is a similar patch: > > > > > http://dpdk.org/dev/patchwork/patch/11637/ > > > > > > > > > > If you want you can review/comment that one too. > > > > > > > > Yes, sorry I've never commented above patch. > > > > > > > > I do not like filling .gitignore because I prefer seeing what is built > > > > or copied or whatever with "git status". > > > > What is really the benefit of .gitignore? > > > > > > I take the opposite view. I only like to see files that I actually care > > > about in the git status. Any build artifacts should be ignored by git as > > > they are not files that it ever should track. That way doing a build does > > > not change the status of the repo as git sees it. > > > > As a workaround I have the following in my .gitconfig: > > > > [core] > > excludesfile = ~/.gitignore > > > > Then I put the ignore rules in ~/.gitignore. > > > > John > > > Yes, I have something similar done, so this is not a problem for me > personally. I just find it strange that we don't make more use of > gitignore in DPDK. The file's name itself seems to imply that it should > be used to list out files that git should not track, and build output is > definitely one of those. I don't understand why we should hide the default build directory and not the other ones with different names. It would be perceived as inconsistent and confusing.