From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F2ABA0C53; Wed, 3 Nov 2021 14:16:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BCB341149; Wed, 3 Nov 2021 14:16:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B33FB41134 for ; Wed, 3 Nov 2021 14:16:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635945415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HRVdJEbJ5Di/EkiMjW4CcvBs5Y2uZ6ErAIRW5f6kMrY=; b=iK5rPaL2ZmDtpqPqgfbVhJtxmhOcjCZhGl1MvE57HDtneS9uhF+9H8ehbhUI+2wuNHDjmx KFb4IZqGMEKeoSDa3VTiY3ThkhgjwOfsmZx+UWCdu11qwdRByXKzALBRNOogTdXpF/I01b AVgIVyVC3zwt+3vs6nLZ/hxw6kDIpXo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-288-d9otM0ccMryqt5ttuSRNBQ-1; Wed, 03 Nov 2021 09:16:44 -0400 X-MC-Unique: d9otM0ccMryqt5ttuSRNBQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 63FF4846266; Wed, 3 Nov 2021 13:16:42 +0000 (UTC) Received: from [10.39.208.36] (unknown [10.39.208.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D25DF60C04; Wed, 3 Nov 2021 13:16:38 +0000 (UTC) Message-ID: <75726d5f-35b9-4d59-7bde-483cb1c5475e@redhat.com> Date: Wed, 3 Nov 2021 14:16:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: Lincoln Lavoie Cc: David Marchand , "Xia, Chenbo" , "dev@dpdk.org" , "Liu, Changpeng" , Thomas Monjalon , Aaron Conole , dpdklab , ci@dpdk.org, Owen Hilyard References: <20211102104748.57078-1-maxime.coquelin@redhat.com> <3a63bda9-2ff7-30bc-87b7-48e1324d1666@redhat.com> <242aa665-45b6-2441-4288-26a4056dc3e2@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdklab] Re: [PATCH] vhost: rename driver callbacks struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/21 14:11, Lincoln Lavoie wrote: > > > > On Wed, Nov 3, 2021 at 5:53 AM Maxime Coquelin > > wrote: > > > > On 11/3/21 09:38, Maxime Coquelin wrote: > > Hi David, > > > > On 11/3/21 09:36, David Marchand wrote: > >> On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo > wrote: > >>> Testing issues reported in patchwork is expected as SPDK uses > >>> this struct, so we can ignore it as SPDK will rename it when it > >>> adapts to DPDK 21.11 > >> > >> Please, no. > >> We can't simply say "ignore failure in CI". > >> > >> The SPDK build test must be disabled in CI first. > >> You can create a bugzilla and assign it to UNH lab. > >> Example: https://bugs.dpdk.org/show_bug.cgi?id=579 > > >> > >> Once done, we can merge this patch in DPDK. > >> > >> > >> In parallel, either prepare the patch or talk to SPDK guys to handle > >> this change. > >> Once this is done, update the bugzilla so that we can get SPDK build > >> tested again in CI. > > > > Thanks for the insights, I'll file a Bz and work with the SPDK team. > > The Bz has been filed: > https://bugs.dpdk.org/show_bug.cgi?id=876 > > > > Maxime > >> Thanks. > >> > >> > > SDPK tests have been disabled in the CI testing and shouldn't run for > any new patches.  Anything that was already in the queue will finish > out.  Bug ticket has been updated. Thanks Lincoln, as the patch wasn't merged yet, this API change will not impact other jobs already queued. > Who from the SPDK team "has the ball" on this item, so we know it's > being tracked and worked on? I think Changpeng Liu in Cc: is the right contact from the SPDK team for this. For my information, are the SPDK tests based on their main branch or on the last release? Thanks, Maxime > Cheers, > Lincoln > > > -- > *Lincoln Lavoie* > Principal Engineer, Broadband Technologies > 21 Madbury Rd., Ste. 100, Durham, NH 03824 > lylavoie@iol.unh.edu > https://www.iol.unh.edu > +1-603-674-2755 (m) >