From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96951A04F3; Fri, 6 Dec 2019 11:04:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C64FC1BF8D; Fri, 6 Dec 2019 11:04:56 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 099DA1BF88 for <dev@dpdk.org>; Fri, 6 Dec 2019 11:04:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575626694; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=seEdXpQGIOto40ue6mbRLtAQgPwOR4YVvl6xQn6aRJU=; b=RO5cQifWsWtq2EINCWeaYs0KysfeG7Q1I2CkbnYSyDnCS/J7VwklBmNebHOJ7ie7qpuSc8 s7f2agp3/5uOz1q8wx/JMHTwRxX9A4jDcuMNvMuJOS9GA986kC6jwo4emQZPbO84I5Kakn GetEdaWczBBGvlRa7/nDzeVmgjPW17U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-fttjU7l8OOCKUVkOjadfcQ-1; Fri, 06 Dec 2019 05:04:51 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C2DF38017DF; Fri, 6 Dec 2019 10:04:48 +0000 (UTC) Received: from [10.36.112.50] (ovpn-112-50.ams2.redhat.com [10.36.112.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 730CC10013D9; Fri, 6 Dec 2019 10:04:45 +0000 (UTC) To: Andrew Rybchenko <arybchenko@solarflare.com>, "Liang, Cunming" <cunming.liang@intel.com>, "Bie, Tiwei" <tiwei.bie@intel.com>, Matan Azrad <matan@mellanox.com> Cc: "Wang, Xiao W" <xiao.w.wang@intel.com>, Thomas Monjalon <thomas@monjalon.net>, "Wang, Zhihong" <zhihong.wang@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Shahaf Shuler <shahafs@mellanox.com>, Ori Kam <orika@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>, Slava Ovsiienko <viacheslavo@mellanox.com>, Asaf Penso <asafp@mellanox.com>, Olga Shern <olgas@mellanox.com> References: <AM0PR0502MB40195CDE1221262FEB8DBA04D25C0@AM0PR0502MB4019.eurprd05.prod.outlook.com> <20191206042745.GA706462@___> <D0158A423229094DA7ABF71CF2FA0DA34EEDB17A@SHSMSX104.ccr.corp.intel.com> <dcc4d77b-c03b-3dfc-0f09-72484157d019@solarflare.com> From: Maxime Coquelin <maxime.coquelin@redhat.com> Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <757e8f2b-5f34-56cc-ade8-670b31e54722@redhat.com> Date: Fri, 6 Dec 2019 11:04:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <dcc4d77b-c03b-3dfc-0f09-72484157d019@solarflare.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: fttjU7l8OOCKUVkOjadfcQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] discussion: creating a new class for vdpa driversxiao.w.wang@intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 12/6/19 10:05 AM, Andrew Rybchenko wrote: > On 12/6/19 8:32 AM, Liang, Cunming wrote: >> >> >>> -----Original Message----- >>> From: Bie, Tiwei <tiwei.bie@intel.com> >>> Sent: Friday, December 6, 2019 12:28 PM >>> To: Matan Azrad <matan@mellanox.com> >>> Cc: Wang, Xiao W <xiao.w.wang@intel.com>; Thomas Monjalon >>> <thomas@monjalon.net>; maxime.coquelin@redhat.com; Wang, Zhihong >>> <zhihong.wang@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Shaha= f Shuler >>> <shahafs@mellanox.com>; Ori Kam <orika@mellanox.com>; dev@dpdk.org; Sla= va >>> Ovsiienko <viacheslavo@mellanox.com>; Asaf Penso <asafp@mellanox.com>; = Olga >>> Shern <olgas@mellanox.com>; Liang, Cunming <cunming.liang@intel.com> >>> Subject: Re: discussion: creating a new class for vdpa >>> driversxiao.w.wang@intel.com >>> >>> On Thu, Dec 05, 2019 at 01:26:36PM +0000, Matan Azrad wrote: >>>> Hi all >>>> >>>> As described in RFC =E2=80=9C[RFC] net: new vdpa PMD for Mellanox devi= ces=E2=80=9D, a >>>> new vdpa drivers is going to be added for Mellanox devices =E2=80=93 m= lx5_vdpa >>>> >>>> The only vdpa driver now is the IFC driver that is located in net dire= ctory. >>>> >>>> The IFC driver and the new mlx5_vdpa driver provide the vdpa ops and >>>> not the eth_dev ops. >>>> >>>> All the others drivers in net provide the eth-dev ops. >>>> >>>> I suggest to create a new class for vdpa drivers, to move IFC to this >>>> class and to add the mlx5_vdpa to this class too. >>>> >>>> Later, all the new drivers that implements the vdpa ops will be added >>>> to the vdpa class. >>> >>> +1. Sounds like a good idea to me. >> +1 >=20 > vDPA drivers are vendor-specific and expected to talk to vendor > NIC. I.e. there are significant chances to share code with > network drivers (e.g. base driver). Should base driver be moved > to drivers/common in this case or is it still allows to have > vdpa driver in drivers/net together with ethdev driver? >=20 That's a good point. For example, for the Virtio vDPA driver, I placed it in th Virtio PMD directory, so that we can re-use the Virtio-pci layer. On the other hand, for the specific Virtio case, it may be preferable to have a common directory. Doing that, the Virtio-pci layer could be reused by Virtio PMD, Virtio vDPA, but also Virtio Crypto drivers. I plan to submit again my Virtio vDPA next week as it didn't make it in v19.11. I'll wait for an agreement on this topic before proceeding. Thanks, Maxime