From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 67E32322C
for <dev@dpdk.org>; Mon, 15 Jan 2018 12:24:48 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id E320420BCB;
Mon, 15 Jan 2018 06:24:47 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
by compute1.internal (MEProxy); Mon, 15 Jan 2018 06:24:47 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=3uc3uxIfqejddEkokWXbsbjtC4
WitX4dgmY8U80cdWc=; b=ExIF5FZqsFx7ykNwa2gEu8jVAhvVoXRybHPXpj6K0/
IbMYfM9ZUqHaHj7Y7W9KddScC5bq4Y3b3m4G277firh/veisBnlbzZdw3sPTd3HR
z03VMWFuN7R3LMeBeRCr+iOWzgbNwjGf4eOaD/TNhXpWlerXu/G+KFsNg8DfLIe2
E=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=3uc3ux
IfqejddEkokWXbsbjtC4WitX4dgmY8U80cdWc=; b=QOwckTqjI2nQFOzp7Qhnc1
QBMph+knQ+SRn86FiepJMd1hEFuq6hN0B3WD6GqaXUwVNewU4RqT0riNPH889+3w
UTEKaAveqMzNVqZZMiPwlkjOZRaj50cK0DdNJCdcGMlxIb/X+EbsP6KKBH3pD1fR
plqpCAqRf0409fjosCdTHY5I9ulObhmHIf8TtOpqemlZ5vkTUZk0IihmdHR+8UK1
kw82hkCncqEmAbKE4OBVdXiGhDM/LBPfsusYeFQlmDNsEnkozQVszhspyDgE7aSQ
5E8/8MtuoQtvr0XJbWVUcBeIlfkH+b3pZ7rmIpS4HmBHUqJYqx8zAIwDgmQ3LUqw
==
X-ME-Sender: <xms:f49cWi-Bm4MqYykIKtpcstpbQbb7CVFjGYkPmRh2leNu7pznAroJ0Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 9D9577E43A;
Mon, 15 Jan 2018 06:24:47 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
Date: Mon, 15 Jan 2018 12:24:16 +0100
Message-ID: <758014701.CxxNsLCgt3@xps>
In-Reply-To: <20171211231258.16494-1-sthemmin@microsoft.com>
References: <20171211231258.16494-1-sthemmin@microsoft.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] l3fwd: set cli back to unix style
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Jan 2018 11:24:48 -0000
12/12/2017 00:12, Stephen Hemminger:
> The l3fwd program became chatty, and the code looks cluttered in
> recent versions. DPDK programs should try for Unix (not VMS) style
> and not print messages for the options user selected. Also, errors should
> be printed on stderr. To make it easier to find code matching error
> messages; error strings should be placed in situ rather than saved
> as string vaiables.
>
> Fixes: 268888b5b020 ("examples/l3fwd: modularize")
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Applied, thanks