* [dpdk-dev] Incorrectly applied ethdev: fix queue start to 17.11
@ 2018-12-10 6:56 Andrew Rybchenko
2018-12-10 7:29 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Rybchenko @ 2018-12-10 6:56 UTC (permalink / raw)
To: Qi Zhang, Yongseok Koh; +Cc: dev, Ivan Malov
Hi,
Do I understand correctly that the following patch was incorrectly applied
on 17.11 since changes are done in queue stop functions instead of
queue start functions? If so, could you fix it, please. Also I think it
makes
sense to check other stable branches as well.
We observe regressions because of the changeset.
Andrew.
commit d48890a39af7ae5c2d79dad02dd3ea3df8b6db82
Author: Qi Zhang <qi.z.zhang@intel.com>
Date: Thu Mar 22 20:59:01 2018 +0800
ethdev: fix queue start
[ upstream commit 239c9b435ad4abcac89b5d2480a0c21ce8b8288f ]
Device must be started before start any queue.
Fixes: 0748be2cf9a2 ("ethdev: queue start and stop")
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] Incorrectly applied ethdev: fix queue start to 17.11
2018-12-10 6:56 [dpdk-dev] Incorrectly applied ethdev: fix queue start to 17.11 Andrew Rybchenko
@ 2018-12-10 7:29 ` Zhang, Qi Z
2018-12-14 20:10 ` Yongseok Koh
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Qi Z @ 2018-12-10 7:29 UTC (permalink / raw)
To: Andrew Rybchenko, Yongseok Koh; +Cc: dev, Ivan Malov
Your understand is correct, I saw the issue happens on both 17.11 and 16.11 both
From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
Sent: Monday, December 10, 2018 2:57 PM
To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yongseok Koh <yskoh@mellanox.com>
Cc: dev@dpdk.org; Ivan Malov <Ivan.Malov@oktetlabs.ru>
Subject: Incorrectly applied ethdev: fix queue start to 17.11
Hi,
Do I understand correctly that the following patch was incorrectly applied
on 17.11 since changes are done in queue stop functions instead of
queue start functions? If so, could you fix it, please. Also I think it makes
sense to check other stable branches as well.
We observe regressions because of the changeset.
Andrew.
commit d48890a39af7ae5c2d79dad02dd3ea3df8b6db82
Author: Qi Zhang <qi.z.zhang@intel.com><mailto:qi.z.zhang@intel.com>
Date: Thu Mar 22 20:59:01 2018 +0800
ethdev: fix queue start
[ upstream commit 239c9b435ad4abcac89b5d2480a0c21ce8b8288f ]
Device must be started before start any queue.
Fixes: 0748be2cf9a2 ("ethdev: queue start and stop")
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com><mailto:qi.z.zhang@intel.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com><mailto:konstantin.ananyev@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] Incorrectly applied ethdev: fix queue start to 17.11
2018-12-10 7:29 ` Zhang, Qi Z
@ 2018-12-14 20:10 ` Yongseok Koh
0 siblings, 0 replies; 3+ messages in thread
From: Yongseok Koh @ 2018-12-14 20:10 UTC (permalink / raw)
To: Zhang, Qi Z, bluca; +Cc: Andrew Rybchenko, dev, Ivan Malov
Will take care of this.
Adding Luca for 16.11.
Thanks!
Yongseok Koh
On Dec 9, 2018, at 11:30 PM, Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>> wrote:
Your understand is correct, I saw the issue happens on both 17.11 and 16.11 both
From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
Sent: Monday, December 10, 2018 2:57 PM
To: Zhang, Qi Z <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>; Yongseok Koh <yskoh@mellanox.com<mailto:yskoh@mellanox.com>>
Cc: dev@dpdk.org<mailto:dev@dpdk.org>; Ivan Malov <Ivan.Malov@oktetlabs.ru<mailto:Ivan.Malov@oktetlabs.ru>>
Subject: Incorrectly applied ethdev: fix queue start to 17.11
Hi,
Do I understand correctly that the following patch was incorrectly applied
on 17.11 since changes are done in queue stop functions instead of
queue start functions? If so, could you fix it, please. Also I think it makes
sense to check other stable branches as well.
We observe regressions because of the changeset.
Andrew.
commit d48890a39af7ae5c2d79dad02dd3ea3df8b6db82
Author: Qi Zhang <qi.z.zhang@intel.com><mailto:qi.z.zhang@intel.com>
Date: Thu Mar 22 20:59:01 2018 +0800
ethdev: fix queue start
[ upstream commit 239c9b435ad4abcac89b5d2480a0c21ce8b8288f ]
Device must be started before start any queue.
Fixes: 0748be2cf9a2 ("ethdev: queue start and stop")
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com><mailto:qi.z.zhang@intel.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com><mailto:konstantin.ananyev@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-14 20:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-10 6:56 [dpdk-dev] Incorrectly applied ethdev: fix queue start to 17.11 Andrew Rybchenko
2018-12-10 7:29 ` Zhang, Qi Z
2018-12-14 20:10 ` Yongseok Koh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).