From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B724A0C43; Tue, 14 Sep 2021 18:37:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86A494068F; Tue, 14 Sep 2021 18:37:31 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id E8CE84003C for ; Tue, 14 Sep 2021 18:37:29 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10106"; a="218877606" X-IronPort-AV: E=Sophos;i="5.85,292,1624345200"; d="scan'208";a="218877606" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2021 09:36:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,292,1624345200"; d="scan'208";a="472068400" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 14 Sep 2021 09:36:59 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 14 Sep 2021 09:36:58 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 14 Sep 2021 09:36:58 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.45) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 14 Sep 2021 09:36:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HwC0wyoexbPHtziW1PY/gTs4EV6h7GaSF0C8+L55hv4MxrM04ap1Zdn8tLUmOshL+OAnumHvG8vEYmbqqNGZqYGn+Ez45uWGk7xfuS2PNOBFoJc8kyhEImFILtk1inOivyNqXjO+bR7AF1dZetW9wGU6hyhLH6zkiFKCwFl/Ydm9psWMJu6DcoiipTSlsnLOBh4I6SepOEd/KPeowd92FgEO9OhlNaME9JCAZYvCz3FhhZMRd3x/Atthpi+eFegDBjwAaLys96lOFrmAV6OlGm6pkNrYxAgGjBJPj/rg5IjyuPcLNVgYkDqwVggHXm3B08b1bbQgGPM5ExCYa71r7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5K61TAQ5gGydj+oZTHG6vZPSP5obpjnGIGZC12rSbpU=; b=nQKSylAG91hfWcU4To/7x7layxVcVMqIanmLdrSRq3R+XxIRIjmI3EVyW8gB2COIOVlWiceaspzWKwILHcscatYo6DcjQWJMNrJqDBfSHI7L9MdXxEEC9fwSOUAQ0KxT4dmr8nFS27mgZ1OVqpAwCfDCr9gpLm1WTANZ8k2Xxeuj02Qz3tXnadNy2/7LLDN1nKAgbH2UarQndRwVzzKdMPRuHXZIV4o1Csdt3ZTMmSTl+vHLCIqmSVx98hM4/CEu8L1+v7UdNp7CD+LaiFFAK6gO6/5FmkUhXbEgagGRd+3dmzyH8Z/cLQWpVIj9HyV1UsAwEs6yvLQdAEBmhdueKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5K61TAQ5gGydj+oZTHG6vZPSP5obpjnGIGZC12rSbpU=; b=lCDNH/pPLp/x3VriBi59c+IJVuiOzkPFgmO9TqS/9pqXGx/ekbCh8Bw/vXh+ib6JhX5lj5RWzyN187F4UIIf8RjcQ5VdGL4dzWV9soqTwP3XO+lHuX5ydf1FhomwKC8MnzVOZVhqfg9MP6TA4Cl5KiY5sEE/z81IPUVCkGs+Ibs= Authentication-Results: xilinx.com; dkim=none (message not signed) header.d=none;xilinx.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5176.namprd11.prod.outlook.com (2603:10b6:510:3f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Tue, 14 Sep 2021 16:36:57 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4500.019; Tue, 14 Sep 2021 16:36:57 +0000 To: Andrew Rybchenko , Xiaoyun Li CC: , Xueming Li , Viacheslav Galaktionov , Andy Moreton References: <20210827063935.1834143-1-andrew.rybchenko@oktetlabs.ru> <20210831161242.3465395-1-andrew.rybchenko@oktetlabs.ru> <78232368-50f3-a03e-aedf-b7f0a8249792@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <7591e9b6-feea-e7e9-ff07-3c35d1243031@intel.com> Date: Tue, 14 Sep 2021 17:36:51 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0157.eurprd04.prod.outlook.com (2603:10a6:10:2b0::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0157.eurprd04.prod.outlook.com (2603:10a6:10:2b0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 14 Sep 2021 16:36:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: edf72c9b-93b3-4cd3-c884-08d9779dde58 X-MS-TrafficTypeDiagnostic: PH0PR11MB5176: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J+Q3TSZMJw8/C0WtY58Pe209ivvLZ7z2RLIu9HyHii2T/0x9hJKsldZumdmmsmOmt4iDde2KmBK4zUHypiRt0WOT9XUOe357q+OBIgvUXpKoKE3JeyZfsLTgxySQ95zbA+ZWtil5EflASFtC+EAzi+6UEhKDD6//vLI+X8Fgd98o8q6UNAAeFPbUkniaC7j8pi7hye86pue2M1ACv/34NG8SVvqzU9pkm3tCru3krmWGWTggPErxnEj3bMc+Nqki6JOuXZYR4Vtn19avWDT90eK8QoLWijka72A36k8Gbndr9BGaGUusIln8lPX6DIOOTevMINpN/1kl86214DwcaZgEI5Sls/71IBaUBthr1S54iVzJerbsUTfhLta5Jpii/PyKdJogK1b6ab5XSSxZWmBwLjFXzsNcWJjLp8SlD9rrMY4OaXmO6sw7DD9uTLI8bEnPS/bpUF7b2cXvs5aaVoUcuA9V+cwuOud2TR20l3RdrvCi4VLn24vm+vxkuj47g5gIB6p8us1Y7t6Z3IbJqKPu1fr4ys4voAMj3v9S2gQTTy7LyWbDMY12v7p9jijg9uWXJVccfoJ3tTv2mvUEg3W1Nss5jW8yogkQv0qdceIGq9/ycc22Pt1rgjeQCXkS1Tdvhi9xaJg4Uc64ZH6SG10+/jJJF2thdsJLa2lgd8M1e/cJWZYpd5TpHGxUt/MBofzGT/fhsBx7wwQFyvOAJg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(6486002)(5660300002)(956004)(6636002)(2616005)(66556008)(54906003)(4326008)(16576012)(316002)(66476007)(110136005)(66946007)(26005)(38100700002)(53546011)(186003)(44832011)(478600001)(31696002)(31686004)(36756003)(86362001)(2906002)(6666004)(8676002)(8936002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3dtYU5VYzJ5R1Mvd05uY0NXR1lWOTNuOUNNQzZwazNTRHZtc3VCMFdrNkNN?= =?utf-8?B?UnNNTUVVc29mSVpTTEdlYStBWVhONjBqTDV2ZkVzV3ROK0NIQlF0MkhBdDVX?= =?utf-8?B?cjFiS2RkclFGcXd4K050QVJBaHNJM2E3cnliQ0loS3lSM0NGZVVsRy9FZG9V?= =?utf-8?B?Y01ZV29tTjZHc3JwUXYwVEQ5QVJTbE8ycVQrS0NjMVFVd0tNRTRuQUMxeHRX?= =?utf-8?B?RlQ3UDJIVGMzd0ZQZ21BdU9EUVp4VW5BWC80cldZckZKeDhOMGY1bkZjZW1W?= =?utf-8?B?RGJ6UmlRaVd5QWlEdnozLy9BclR1cGYra0YyVDltVU9QMGtveXdaSXFQZGJO?= =?utf-8?B?V2Vwbm1LOUtiMjF4S1kvdWpnaytCWldIeGtQVVBWbjJudWxJTmc4Q3hyZUlV?= =?utf-8?B?RTBtelBmUVA0RWdmeEFhS2hMR0szSWlEZllmTnorU2FmSjJ2T3BieWRYUTJZ?= =?utf-8?B?a2xSVmRlcjg5QUtKQjRmSTFIWHp4em9nUXhaTkhHcldEbnQxZi9FSmxnRUlR?= =?utf-8?B?ZGg4d1ZySzN6TzhJWG43dXd0Mm9mV2tjelhySFN3Vk5hOGR5MC8vMzdSSTBv?= =?utf-8?B?VmdZYXlqZ21lNFI0Q0NTb2xmalFUazI2OE1LQUNTaWRXMGs3Mit5aUlZNXVZ?= =?utf-8?B?Qmt1LzFxRGVoakdGUFRNWWlUKzlKU1pIdE5uNmU5UmI2bGtrcFlvVWZ5azlQ?= =?utf-8?B?TUc0YjRTV1RWaVJNU25aenZ4NGJRWnBYZWwxNmlZMnRLTnlwOUwxSzZFVlZw?= =?utf-8?B?eDBEaml3ellSeUNqUjc0NGQyMTdCVys2aEQrK21CcjJMMmMyS1VnOXppd1RP?= =?utf-8?B?MjhOZmowMm56anJZZ1FxQWZrZXhXYmZraERmY3RCUCt4azNoL3pMMDcwZkgw?= =?utf-8?B?a3JMemc3aW1HMFFHMzNkWDQ0R3phZ0RGUHBMZEJvdDJWUVhxVDFqYjgxaExG?= =?utf-8?B?akpoOFdidjgyRllLVjNLcjNwQk42cHZUeWtrTUdFT3Y4WWFySzR1by81L1di?= =?utf-8?B?UllKQm45ZzhMTWR6Y2hhK2lrVE05OHNrcVRDQTZ5YXhBdHNScXkyeHhNb3dq?= =?utf-8?B?NnJGWFIrbjFERnFKS3Q0djRVTE0yU21vNTllV0YzZ2xZczl0T0RCUU5lUTU3?= =?utf-8?B?QnVWRFdvQzVnNGM2c1FlWGRqaUpBWW9SSlpMYUR5NDR3U0lIMEpDekoxd3dh?= =?utf-8?B?MGJoMkEzVG9tNnlwbWdsOU5aTVVMSDU1NXR1OERjTTlyMGNqdm1kTloreEl1?= =?utf-8?B?S093REN4Uk1xNGRJUDNOV09vc2FEUWg1Qmc0MXZNaEVnaXJWTDRRb3ZmU29a?= =?utf-8?B?K0JsU0V1R2wxK3hZWXRzOXVWUHBJQ0RXdjNXN0xBY3Z2NUZGY0Q4R091UDk0?= =?utf-8?B?eUZQQkZOd3NwZmMyWEFCNXYrNFVvOVNGVjlIREVwVVFDc3hXblNLbjg0NDVt?= =?utf-8?B?RlVqMDJTMUNpM0VqVEJCdE00b0tKdXJ5RDcxNVhJanIvNUV6RU9ldXJUa1Vj?= =?utf-8?B?ZTR0dTF4aVQyWm91dmJiNlg3L3FzaHRGajBFdlgxZlpNazNUUVpka2hkVmtt?= =?utf-8?B?bVBodkZ6RUF1OFk5RTBzYjBuS1dBV29PdWtjcWhNQVNNaHY4VEFmOU1nY0U3?= =?utf-8?B?V3pCNmZEak1RUkRHNTlXcW9EaDRkRHdEVklrRThMZUxTQSt5MWx0Vm0zbkhG?= =?utf-8?B?MXRYVVk3TGxHblVRdjhNYUVTR0EvSGlhby9URUR3YXhMT2NiMlZYeG52Qzdw?= =?utf-8?Q?eLr0TChqZ9c5TSJ4J+Xemr6CgbP3ORpkI6s9sFe?= X-MS-Exchange-CrossTenant-Network-Message-Id: edf72c9b-93b3-4cd3-c884-08d9779dde58 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2021 16:36:57.4731 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iA9gg0UKPV3e+Tn49jUQg+zW+b4Uhe/3tdcNsQBSSxV65D83pHKOzvuOgI9QWeqAw9A4XEDVPE8K+n8eNeyvsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5176 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: add command to print representor info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/14/2021 5:17 PM, Andrew Rybchenko wrote: > On 9/14/21 6:52 PM, Ferruh Yigit wrote: >> On 8/31/2021 5:12 PM, Andrew Rybchenko wrote: >>> From: Viacheslav Galaktionov >>> >>> Make it simpler to debug configurations and code related to the representor >>> info API. >>> >>> Signed-off-by: Viacheslav Galaktionov >>> Signed-off-by: Andrew Rybchenko >>> Reviewed-by: Andy Moreton >>> --- >>> v2: >>> - change output format to log just one line per range >>> >>> app/test-pmd/cmdline.c | 135 +++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 135 insertions(+) >>> >>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >>> index 82253bc751..ae700f9dd1 100644 >>> --- a/app/test-pmd/cmdline.c >>> +++ b/app/test-pmd/cmdline.c >>> @@ -236,6 +236,10 @@ static void cmd_help_long_parsed(void *parsed_result, >>> " Show port supported ptypes" >>> " for a specific port\n\n" >>> >>> + "show port (port_id) representor info\n" >>> + " Show supported representors" >>> + " for a specific port\n\n" >>> + >> >> What do you think extending existing "show port info #" command instead of >> creating a new command for it? > > My fear with such approach is that output of the "show port > info #" is already too long and adding representors info > there will make it even much longer. > That is fair concern, what about extend existing command with a new keyword to just print representor info: "show port info # representor" >> Since "show port info #" is a well known command, it can simplify the usage. >> When port is representor port it can display additional info. >> > > Just to be clear: it will output information for "backer" > (or parent) port which should be used to create representors. >