From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E069BA0093; Thu, 8 Dec 2022 20:43:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99C7C410D2; Thu, 8 Dec 2022 20:43:44 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id B17064003F for ; Thu, 8 Dec 2022 20:43:42 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3637B5C00DF; Thu, 8 Dec 2022 14:43:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 08 Dec 2022 14:43:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1670528620; x= 1670615020; bh=Iq6/iY5o0wFMFrmbukPdqNP07AGUNH2Mx+h1ANqI2S0=; b=J qfcb8PAFJes7oep7F1psPKJ9kY/7VGW/Ao3aiic2qb/e2kACu6YphNz2EFHFcykA /7QL04DvDFptO+JZrJ3iwoQDGsB4PsBQh67VPEOLp+OiLHJU1Tgy+4Zf2mDmv9Zz cV1hVy8IbbLKvxX+yXHRHQdq7u2iI39jfITWNig2UX7iQ1eu+c+ciw1tiW33FXAH iBahP2QbFNihss0G6xxZPyXS+eQhp3O0GUHixBdALFovrIS6Av+wQ2p+JswCKy8v CrRRlDLhVYQjfRG53WXaDiUfKVFREVfVVagteeM/CgqHo0wFMMWIv+LtiqmKaUy3 L9pPbmonZ6cQoyOgHLPeg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1670528620; x= 1670615020; bh=Iq6/iY5o0wFMFrmbukPdqNP07AGUNH2Mx+h1ANqI2S0=; b=B fArijCMk+2tayjbP2UuaCsEOQW3CO3UP7X5+VIjP/chtYF3Te4ZGamxriqMyBQD7 FqEzvAlJYM6NeVLiFl8MBDcoe1VKyvJtfeEgjRwz1zZaSLBnPG68zxUItcobBAhp 971vNzPJnesEcizoEVE/v8muprOScTTvLmEyVAsFh4RiQK1P5O7qVOEismI+XzAa l6vCCJrUmZd+QIARj5qGKVESahGCC5Zp1iYgiE9zjcZYh4epYSGdFNL8voeBCWN2 XF2k6M/fIXqh2XZ5WjJIY9mkf6cmm30k6rbfg2dqNsvfljClp0EuRcLUZlMy6zZj Aa/gRe2DlA+HssEl+ehsA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddtgddufedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Dec 2022 14:43:39 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit , Bruce Richardson , Akhil Goyal Cc: David Marchand , "dev@dpdk.org" Subject: Re: [EXT] [PATCH 2/2] devtools: configure source repo to use as ABI reference Date: Thu, 08 Dec 2022 20:43:37 +0100 Message-ID: <7594922.lvqk35OSZv@thomas> In-Reply-To: References: <20221206122341.3046688-1-ferruh.yigit@amd.com> <20221206122341.3046688-2-ferruh.yigit@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/12/2022 19:14, Akhil Goyal: > > By default 'test-meson-builds.sh' script clones the repository which the > > script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') > > as a reference for ABI check. > > > > This patch enables selecting different repository to close for reference > > using 'DPDK_ABI_REF_SRC' environment variable. > > > > It is possible to put these variables to 'devel.config' config file, or > > provide via command line, like: > > ` > > DPDK_ABI_REF_SRC=~/dpdk-stable/ \ > > DPDK_ABI_REF_VERSION=v22.11.1 \ > > DPDK_ABI_REF_DIR=/tmp/dpdk-abiref \ > > ./devtools/test-meson-builds.sh > > ` > > > > When 'DPDK_ABI_REF_SRC' is not defined, script behaves as it did > > previously. > > > > Other alternative to using 'DPDK_ABI_REF_SRC' variable is adding that > > other repo as a new 'remote' to the exiting git repository. > > > > Signed-off-by: Ferruh Yigit > > --- > > Acked-by: Akhil Goyal > > Worked for me, but I still needed to clone the dpdk-stable repo manually. > I was hoping, test-meson-build.sh would do that by itself. > Had it been a tag in same repo, it would have been straight forward as before. > I would still suggest to add a tag v22.11.1 in main branch and all can use that instead of v22.11. First, v22.11.1 exists already in dpdk-stable. Second, vXX.YY.z tags are supposed to be only in dpdk-stable. > The fix that we are talking about is a mandatory one for each one to use for ABI checks, > dpdk-stable patches are not mandatory for the users. You could have dpdk-stable as a remote in your main DPDK directory. If you don't want to do that, you could refer to the commit SHA1 of the fix I think.