From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id DF11E1B3FE for ; Mon, 25 Dec 2017 09:31:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Dec 2017 00:30:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,453,1508828400"; d="scan'208";a="16387647" Received: from jguo15x-mobl3.ccr.corp.intel.com (HELO [10.67.68.80]) ([10.67.68.80]) by fmsmga001.fm.intel.com with ESMTP; 25 Dec 2017 00:30:46 -0800 To: Stephen Hemminger References: <1505880732-16539-3-git-send-email-jia.guo@intel.com> <1509567405-27439-1-git-send-email-jia.guo@intel.com> <1509567405-27439-2-git-send-email-jia.guo@intel.com> <20171101224144.7e0854bf@shemminger-XPS-13-9360> Cc: bruce.richardson@intel.com, ferruh.yigit@intel.com, gaetan.rivet@6wind.com, thomas@monjalon.net, konstantin.ananyev@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com, jingjing.wu@intel.com, dev@dpdk.org, helin.zhang@intel.com From: "Guo, Jia" Message-ID: <759cbdfd-0c1d-03f9-e27e-c437f1b14aed@intel.com> Date: Mon, 25 Dec 2017 16:30:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20171101224144.7e0854bf@shemminger-XPS-13-9360> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 1/2] eal: add uevent monitor for hot plug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Dec 2017 08:31:07 -0000 On 11/2/2017 5:41 AM, Stephen Hemminger wrote: > On Thu, 2 Nov 2017 04:16:44 +0800 > Jeff Guo wrote: > >> + >> +static int >> +dev_uev_parse(const char *buf, struct rte_eal_uevent *event) >> +{ >> + char action[RTE_EAL_UEVENT_MSG_LEN]; >> + char subsystem[RTE_EAL_UEVENT_MSG_LEN]; >> + char dev_path[RTE_EAL_UEVENT_MSG_LEN]; >> + char pci_slot_name[RTE_EAL_UEVENT_MSG_LEN]; >> + int i = 0; >> + >> + memset(action, 0, RTE_EAL_UEVENT_MSG_LEN); >> + memset(subsystem, 0, RTE_EAL_UEVENT_MSG_LEN); >> + memset(dev_path, 0, RTE_EAL_UEVENT_MSG_LEN); >> + memset(pci_slot_name, 0, RTE_EAL_UEVENT_MSG_LEN); >> + >> + while (i < RTE_EAL_UEVENT_MSG_LEN) { > Might be simpler, safer, clearer to use rte_strsplit here. > > And then have a table of fields rather than open coding the parsing. > i think your point must be make sense , but it hardly use rte_strsplit here , because the tokens which need to parse is splited by '\0', even more multi adjacent '\0' in the buf witch come from the uevent massage. >> f+ for (; i < RTE_EAL_UEVENT_MSG_LEN; i++) { >> + if (*buf) >> + break; >> + buf++; >> + } >> + if (!strncmp(buf, "libudev", 7)) { >> + buf += 7; >> + i += 7; >> + event->group = UEV_MONITOR_UDEV; >> + } >> + if (!strncmp(buf, "ACTION=", 7)) { >> + buf += 7; >> + i += 7; >> + snprintf(action, sizeof(action), "%s", buf); >> + } else if (!strncmp(buf, "DEVPATH=", 8)) { >> + buf += 8; >> + i += 8; >> + snprintf(dev_path, sizeof(dev_path), "%s", buf); >> + } else if (!strncmp(buf, "SUBSYSTEM=", 10)) { >> + buf += 10; >> + i += 10; >> + snprintf(subsystem, sizeof(subsystem), "%s", buf); >> + } else if (!strncmp(buf, "PCI_SLOT_NAME=", 14)) { >> + buf += 14; >> + i += 14; >> + snprintf(pci_slot_name, sizeof(subsystem), "%s", buf); >> + } >> + for (; i < RTE_EAL_UEVENT_MSG_LEN; i++) { >> + if (*buf == '\0') >> + break; >> + buf++; >> + } >> + } >> + >> + if (!strncmp(subsystem, "pci", 3)) >> + event->subsystem = UEV_SUBSYSTEM_PCI; >> + if (!strncmp(action, "add", 3)) >> + event->type = RTE_EAL_DEV_EVENT_ADD; >> + if (!strncmp(action, "remove", 6)) >> + event->type = RTE_EAL_DEV_EVENT_REMOVE; >> + event->devname = pci_slot_name; >> + >> + return 0; > Function always returns 0, why is it not void?