From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id A79ED7EC7 for ; Wed, 1 Aug 2018 16:36:18 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E48D18197001; Wed, 1 Aug 2018 14:36:17 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-113.ams2.redhat.com [10.36.117.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1C661C640; Wed, 1 Aug 2018 14:36:16 +0000 (UTC) To: "Dumitrescu, Cristian" , "dev@dpdk.org" Cc: Andy Green , "Singh, Jasvinder" References: <43ec6b34-b68c-618e-ab14-1f1b85f3315c@warmcat.com> <3EB4FA525960D640B5BDFFD6A3D891268E78265A@IRSMSX107.ger.corp.intel.com> From: Kevin Traynor Organization: Red Hat Message-ID: <759ea3b9-17f9-3d32-3964-978cfb00efc2@redhat.com> Date: Wed, 1 Aug 2018 15:36:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E78265A@IRSMSX107.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 01 Aug 2018 14:36:17 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 01 Aug 2018 14:36:17 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'ktraynor@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] Stable ABI status of rte_meter_[t|s]rtcm_profile_config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 14:36:18 -0000 On 08/01/2018 03:30 PM, Dumitrescu, Cristian wrote: > > >> -----Original Message----- >> From: Kevin Traynor [mailto:ktraynor@redhat.com] >> Sent: Wednesday, August 1, 2018 11:48 AM >> To: dev@dpdk.org; Dumitrescu, Cristian >> Cc: Andy Green ; Singh, Jasvinder >> >> Subject: Re: [dpdk-dev] Stable ABI status of >> rte_meter_[t|s]rtcm_profile_config >> >> On 05/28/2018 04:31 AM, Andy Green wrote: >>> Hi - >>> >>> Between 18.02 and the putative 18.05 there were changes in the way the >>> meter stuff deals with its config. >>> >>> I updated the related code in lagopus, but I get warnings about using >>> the new APIs (it's the same for rte_meter_trtcm_profile_config()) >>> >>> ./dpdk/meter.c: In function 'dpdk_register_meter': >>> ./dpdk/meter.c:119:7: warning: 'rte_meter_srtcm_profile_config' is >>> deprecated: Symbol is not yet part of stable ABI >>> [-Wdeprecated-declarations] >>> rte_meter_srtcm_profile_config(&lband->sp, ¶m); >>> ^ >>> In file included from ./dpdk/meter.c:27:0: >>> /home/agreen/lagopus/src/dpdk/build/include/rte_meter.h:86:1: note: >>> declared here >>> rte_meter_srtcm_profile_config(struct rte_meter_srtcm_profile *p, >>> ^ >>> ./dpdk/meter.c:132:7: warning: 'rte_meter_srtcm_profile_config' is >>> deprecated: Symbol is not yet part of stable ABI >>> [-Wdeprecated-declarations] >>> rte_meter_srtcm_profile_config(&lband->sp, ¶m); >>> ^ >>> In file included from ./dpdk/meter.c:27:0: >>> /home/agreen/lagopus/src/dpdk/build/include/rte_meter.h:86:1: note: >>> declared here >>> rte_meter_srtcm_profile_config(struct rte_meter_srtcm_profile *p, >>> >> >> Hi Cristian, >> >> Are these API still to be considered experimental in 18.08, or the tags >> can be removed? >> >> Kevin. > > No, we should remove the experimental tag on these functions. > ok, I just did a quick compile tested patch. Will send. >> >>> >>> As far as I can see this api change is not optional, it changes the >>> parameters for related apis to require a struct prepared with these new >>> apis. >>> >>> -Andy >