From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <hemant.agrawal@nxp.com>
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
(mail-db5eur01on0042.outbound.protection.outlook.com [104.47.2.42])
by dpdk.org (Postfix) with ESMTP id B8888AAB7
for <dev@dpdk.org>; Wed, 21 Mar 2018 07:28:14 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=eOgtHOai+jouaOWaclaI26ER9hsCtoNbLwu8bQGGvJU=;
b=uwoqbZ4j29Lz2mfNpbufiASdHjSzTjHDa/4HLmF46g3cgrs4FXxgpQxLKxt9pavtf07Wu1wY45Vip8YpAwhUCXrIu9/4tWjv7E+SpW0ySRL7yC0sl78elMVNpLP0F2bl2519UzaXfqhcozDEzjjWGWrzv+FbJ1YYCZwg8dm2OTc=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=hemant.agrawal@nxp.com;
Received: from [192.168.43.33] (106.199.76.61) by
AM2PR04MB0756.eurprd04.prod.outlook.com (2a01:111:e400:8411::16) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.588.14; Wed, 21 Mar
2018 06:28:11 +0000
To: Shreyansh Jain <shreyansh.jain@nxp.com>, ferruh.yigit@intel.com
Cc: dev@dpdk.org, hemant.agrawal@nxp.com, nipun.gupta@nxp.com,
akhil.goyal@nxp.com
References: <20180312092547.18472-1-shreyansh.jain@nxp.com>
<20180313054431.19556-1-shreyansh.jain@nxp.com>
<20180313054431.19556-3-shreyansh.jain@nxp.com>
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Message-ID: <75a5309c-a3ff-135f-7756-b50220b4c74e@nxp.com>
Date: Wed, 21 Mar 2018 11:57:58 +0530
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180313054431.19556-3-shreyansh.jain@nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Originating-IP: [106.199.76.61]
X-ClientProxiedBy: PN1PR0101CA0014.INDPRD01.PROD.OUTLOOK.COM
(2603:1096:c00:e::24) To AM2PR04MB0756.eurprd04.prod.outlook.com
(2a01:111:e400:8411::16)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 16b3ba27-6783-417f-6822-08d58ef4ec0f
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603328)(7153060)(7193020);
SRVR:AM2PR04MB0756;
X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0756;
3:4Tor16cD0DwXKg9tHf3IhSa3s6A4eesQ0FAb7c/IvEDhMhL9C1eRdMnL/y6E5yTfULTFKPwJb93yEh4VcgjD7fQVKBQMo05MtR22kL4uwOUI83IJfs0N6GwmPIFEPeb7/A7+KTrwj3LtkMsL9M6AolNV4j/NJWEZM3FipaXOOgINpb118poe9jMuLwVRfue52KzRlKUqDA2gWsS1U6bU18S7PNC9BiQlwCXRKLNWPXh3XUPqp8l55yT8Twr7yL4V;
25:ygC2iHswD/AhBZ5/cEmPNlPYHus+SUUpJWguFooOj4+1dA4e3QRasl90rU5g4kdhbYGxYSy+iLG6nk1Xswcwztxrc+Fxibehd36HImB85i5CrpRKkSkM5apIBLZ9AcqUZsZTT9+D9L+IdyFm6U3Q6byocmFwVHNEGNAbjLvR1zoO1QrY1tehB3w1kTOblhLQJpI5HlKFan0//mCT0R4bjxUdUajOyydeUFIX4RzU+IX4H1971h2iXicz+tkVq2pwq8Du4pE8lWoSSjDDmqFCm8XNpxaZ2RFO2RHGAJu+D/a7B8J+Z+hZ2okP6SFYvGW9ADu/w72hbDUAztUZfV8ukA==;
31:tgW3lEXedwc5Auv8tHlD6bHPYitYMb6+CZQThefZ/Bh21mr2jLChH4gVG/51H4zA66SkwdiNqhk/f5QN7naPJvNYtId5g6Dzkk4gy+OnzFUVtWi/li17bSfXEReWi2M8OP8pWslk7QN1xkTi7H96Z9ZjogEfiuFmijEXK5WrmeGV7qMjxUY/nj0qUlUBTnOkCKUT+HFUyM7YXmbx6uK83vom/rdVekz1zTXVSnuuic4=
X-MS-TrafficTypeDiagnostic: AM2PR04MB0756:
X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0756;
20:48aq0lEOWBu0olg2PW4UhE/lyYAq3qmi4gyn9o1fdRbpA30ogfJ7jIjiHEamRiWBMd/7khVmqQNDZKkqMRWM4inyG1BDrt7SodcbwKBKk0rf0qVqfh5pQMmDRr/ojMhaWtFlaPGFw86X2H/BJdEa+XotvEn2nZsiUau3ZXVvaOVpJghrPJSgKtHeX87JNrlj0MQcEkUhJYZlEVV61ADbLYsHG7HQFJWM6/BGnMwy+uvnfWvW+zABWz006gHFrNOhE98+gRZjibh8pzmhT6vd75FfdK4/J1OR3RoONbT828FG4Y266twDakE1XcwtX8D7b1tHiQUfPtXxeXDeEI5eseIDdzm+xzmFyQcYbfqyCGYSHJ/sQUJg2ZHDjqoSbw/GDSRQFWc9za3LpuFbl5OTCzRaooGEhytv0CitZt+DWTjf6dkNeqNnIgmqR9gjVMEJ910CnylOWLk8U/4soenW72XTZO/fovjRlDTNAALyOMXCIPJn0kHgpGaeNbIj931i;
4:SAClvm8Lol+TIbVfA91/zz68A9QI7NsFuAjOPsbjoWwe04//GUgwRENkoJKqrkckVnzQrlUQGtb9R0syl3DxDwsQJJD1uGIeM8mNJyWR4x+jHMXDv6P4CDHTHV4pxIZfaYtQAVd49OPQk5QBemLIW/jwsxkX5YtUyfmOD9rlBeH+bqCywdKksAbAbp+eRHB9EX92SYCR1F0xJ/ZkEiMVeEkHHrIC66H3atQ+4jfskDMsPWIBxsOylDEvOpaxfoHt8ktZZ/DGsTxroSk8bPHeOYqo+BRSAM4KqRDsWWb4gm0MjatOpLHQ7Iu4ghqPvmCyiEloHZB4iO1k3xsyy7/JFK4WI1Im1a+wdcutXm4cQ5Q=
X-Microsoft-Antispam-PRVS: <AM2PR04MB0756934C0D554F00631EAE8689AA0@AM2PR04MB0756.eurprd04.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(275809806118684);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231221)(944501319)(52105095)(6055026)(6041310)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011);
SRVR:AM2PR04MB0756; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0756;
X-Forefront-PRVS: 0618E4E7E1
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(6049001)(376002)(366004)(39860400002)(396003)(346002)(39380400002)(199004)(189003)(5660300001)(47776003)(77096007)(5009440100003)(66066001)(65806001)(65956001)(16526019)(117156002)(64126003)(50466002)(106356001)(105586002)(6116002)(3846002)(26005)(7736002)(305945005)(65826007)(230700001)(25786009)(229853002)(4326008)(8936002)(58126008)(67846002)(31686004)(6246003)(478600001)(31696002)(52146003)(2486003)(68736007)(2906002)(8676002)(6486002)(81156014)(6666003)(2950100002)(86362001)(81166006)(23676004)(52116002)(53936002)(76176011)(97736004)(386003)(36756003)(53546011)(316002)(16576012);
DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0756; H:[192.168.43.33]; FPR:;
SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
Received-SPF: None (protection.outlook.com: nxp.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTJQUjA0TUIwNzU2OzIzOlZaZU0xWjZ2RHo4aEJnQXAzejIvUU1vV2JD?=
=?utf-8?B?Mmc5VmZXTEU3MVc2dXh3L0xjQ21TT3k4MHRzd2NjYUdtelhiTitYblcwaEp0?=
=?utf-8?B?YUdhUTF4Y255b1dwNmFBbXh4d0xlTnB1K0x1ZTFpTE55S21GeEdzZTNpbUFh?=
=?utf-8?B?OFh0SnZjamZGVWNqcjA3YmNPM0dybWswZnhkc2loU3B3elQ3OG5KczR6Q1k3?=
=?utf-8?B?a01YZFRkTkwrUGE0ZnIyMGhsMk5RaVVYNkdOcUE3d1dncXRHb2RGZzcwTFIw?=
=?utf-8?B?b2x3a3RTcWlWRTNQWHFQMERmU3Y5a2V4UktKV3RWSFBSWHk0SUp0NStoYUw2?=
=?utf-8?B?TTVaTkpqK2Fic1U1UW1WRjBJOGYyb014R3pOSFRLb01CSWhRdml5cXdJVk95?=
=?utf-8?B?RWYwS1pyVHVyT2ZzbkNua1VFS2tnWFdSdm5USGJ4L2dYdXFKOGJPdGx6L1o1?=
=?utf-8?B?NzlsNytBUkpEN3F5NXFRYkRBY2dEUU5LeDVMUm5lVnVOQUdMNkVTTzBRYTc1?=
=?utf-8?B?VVFmd1BLTzRXZ21CeGdkYmF2WklxTnNHVG5iZ3lzQVpIZTZLQWxZTHA5RXpZ?=
=?utf-8?B?eHJ6OE94bk82Y0kvcFpSWnFpR21JODlwYjl6aDAwWnUybTY2bGkwNWNmZFZq?=
=?utf-8?B?dTBWdy8yaVVjbXB5ckNzSWJBYU05UUR5d2FaSDNuT1dCR3JmV3VoVFlMbWJF?=
=?utf-8?B?cnczWUdDTFRuTldSa2xIVUNEcDVwb0lQYVhxbjlyRXE3Y0lKYU9HMjV4ZkZj?=
=?utf-8?B?bHVkV2N2UnNna3JTVjE4dzFLeDFvTk5xTGdmaXZkR1RqMDRPYmk2OHMwcml0?=
=?utf-8?B?NFR0OEFlZFFqQXNmS24yNlZkYUoyVUNNYmc4K2ZHY2lDYXI3d3AvdGxldTFX?=
=?utf-8?B?WlV2eTRWZGtIV2tDSlRvZ1JoQ2JvRUhiSUZrY2lYTWFtZHl6RUNuRGdFZ0sx?=
=?utf-8?B?QXhqbFFScjFmeEV0V0ZFNGFRekpMS1gwZDNMc2VkdWs2bm9hTVlBeWNGaXUy?=
=?utf-8?B?ZlFOQ0NHaGc3TWp6SG4wNFdCc29FOTdxbW9OSHZKbEFBWGFsbW1oVmYvV0ZF?=
=?utf-8?B?MGdvaVdPUVNEQ2dCdzlGTjhPalN2QkVLc1dCMUJyVk9hQUlaT1hqa0tXYWhr?=
=?utf-8?B?UXVTSXltTHFpSWx3bFRZbFhTT25KdlBFdjFQVXM0U09tNnh6aURxSmMzMmlr?=
=?utf-8?B?eVJQT0cyN3IrelpRcGwzL3FMNnF0S3FkZTBFYjhxVEJoQ3k5amtkYjU3YS91?=
=?utf-8?B?Q2hCNElvYmtCWGlib3hMTlAvNG1uaWNsYVlYYXdXcHI0SzhtQ09XVnJpMnRK?=
=?utf-8?B?U2kvZnpIeGQxcDQvdnJCSjBzSG5aODRzTDlmZVg1czJrbWZkRnRORmVWRkJQ?=
=?utf-8?B?bUV5aGw0emNoRnI3V3lib0xsZzM2dDBtQ3RVWUo4b1A2V1l1NEMyMXFxZUJn?=
=?utf-8?B?RmtJblN5NGVjcTdMOVAxM25kQmxIa3V4RzlFSGZYQXNkRTdrTkx0ME14VDRr?=
=?utf-8?B?eDhUTnVQMEsrT1N0ODdBZksyOVZwckQwMzZlS0tzbUpEMW44QS9SWUM0L0JW?=
=?utf-8?B?RDBlSnVnWE9yOW9IRlUzb0U0cm92d2pmdWlMRm0yMTd1amF0YVp0LzVVd20w?=
=?utf-8?B?Y0xXRzM0SEd3OWFBWml5aVozeHBGU1RtT0JTWmFEUzltREJKMGtBUExtSGpZ?=
=?utf-8?B?c3NnUVM4OEFlTm5SSkcrRXRYTjB0WFNtcTNEMWFoUDdPTG5XbnVNcXo2SDdZ?=
=?utf-8?B?WUZoTzBhRUQ2RGZyWnl6dThzMzdDeXI3SkdBZExGb1diUmNsYkRKS2RQZEd3?=
=?utf-8?B?TTVtV2xlM1lKbHkwL0FQNENWejgzbzF6V29zYmNyTU9mNklWTEltQjFmYTFE?=
=?utf-8?Q?zb6YsLiPgiA=3D?=
X-Microsoft-Antispam-Message-Info: 7NPRDIhe79L4Md9npHiFg5flWl2XuFWQfzn8tTdmZ2bOf3q0voUxb8G8BZW16AjVwl1D53pBgQGyUPZGvdLS5J4UEkMpHryp/YNJyya7ZpRPCBAJV2APn3olzzVOvyLLvGeqn4s4P7hDzSiY1lDSVgLYc7R2JQswdwBIVX5RCNA/ke0XyKXAL4srbRVdeIla
X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0756;
6:nUdUf7HPrbkx8QDBJMrpd+QHp/Fe8g17f9RuSQ2hC+bx0MH/d85OGSUZ5BBbefMp1HV+fjoT9C5GiVZYLD6Yydrwz5aRcmZLmaSqjcXODP+LJ2o392ThqyWjRAm1YT/v3S4/qHrVsvLUityM/XT/coxeDQmhtJ5iLvQyFSZBLHRvH3W9niDveUmGbuZRJjyrPpef16OD7cY7zC864n/SLkt/ZFjS55K66oiW3HrnAOKYg+cEfTgW/ruV/VwkpSAHJoynQPrX1IIHyEoUeI7hPP2vbTj44O76hYuK0TJKKsjZcKGjcMiL4Mspwa/LVyWSS44f9JIXYhL8rnFpknRy4edLkwgBOIcrVWzcz+irQfc=;
5:iSzUP6SNVwiiJEBDD1w7Rchib9OO1VbDMrZB6uQP4u7Ihx4PCrdEuttOUJlPsQGJR6SS4zV2m3ttIp7+hyIiFg1QZ7uYX+TVz1fkkMHi8nCRt0Ez6wFLW8T/7/3eM9xxtrhUKTBQDbLJOzOcrTJf9hlvvLJJAxupbJYxJVrhwwQ=;
24:dlY5YPg3T+jfP82uuCprOFQmNQA76k0tn699/mEjZkTvm19NnDcWXSYr1sRPuZplwiCej3B6sEraUYyRcoINICXri4JGiR7SNAHd67BrZZI=;
7:bb1m7J+RHPUyg215hcn4i4q0cgM5K5caRGLBIzVrskHD7FlKyw2yyGQcCOHoTVzRS58gFMBVIkm34rkdgutPJYa/MIuXUquVZcygkpuuXw4yKsoSlLOvRC5YqA09d9F2neQzIFG7FuqYzTLMZjtkhgkRslwEQ9Bh4SVr+WtNCbt30IiWfp1h3FyHTNFMYUoKYzFblLvK9dzPppdHqqwiYo93ayW0huJRQCucPnJ6xio6v/z773kNI/hZYGAEOG9Z
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2018 06:28:11.0609 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 16b3ba27-6783-417f-6822-08d58ef4ec0f
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0756
Subject: Re: [dpdk-dev] [RESEND v2 2/7] mempool/dpaa2: change to dynamic
logging
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Mar 2018 06:28:14 -0000
Hi Shreyansh,
On 3/13/2018 11:14 AM, Shreyansh Jain wrote:
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
> drivers/mempool/dpaa2/Makefile | 6 ---
> drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 60 +++++++++++++++++----------
> drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h | 38 +++++++++++++++++
> 3 files changed, 75 insertions(+), 29 deletions(-)
> create mode 100644 drivers/mempool/dpaa2/dpaa2_hw_mempool_logs.h
>
> <snip> ..
diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> index 1a618ae1b..6e8b7068e 100644
> --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
> @@ -27,10 +27,14 @@
> #include <portal/dpaa2_hw_pvt.h>
> #include <portal/dpaa2_hw_dpio.h>
> #include "dpaa2_hw_mempool.h"
> +#include "dpaa2_hw_mempool_logs.h"
>
> struct dpaa2_bp_info rte_dpaa2_bpid_info[MAX_BPID];
> static struct dpaa2_bp_list *h_bp_list;
>
> +/* Dynamic logging identified for mempool */
> +int dpaa2_logtype_mempool;
> +
> static int
> rte_hw_mbuf_create_pool(struct rte_mempool *mp)
> {
> @@ -44,30 +48,30 @@ rte_hw_mbuf_create_pool(struct rte_mempool *mp)
> avail_dpbp = dpaa2_alloc_dpbp_dev();
>
> if (!avail_dpbp) {
> - PMD_DRV_LOG(ERR, "DPAA2 resources not available");
> + DPAA2_MEMPOOL_ERR("DPAA2 resources not available");
Can you change it to "DPAA2 pool not available ..."
> <snip> ..
>
> @@ -280,8 +284,8 @@ rte_dpaa2_mbuf_alloc_bulk(struct rte_mempool *pool,
> * in pool, qbman_swp_acquire returns 0
> */
> if (ret <= 0) {
> - PMD_TX_LOG(ERR, "Buffer acquire failed with"
> - " err code: %d", ret);
> + DPAA2_MEMPOOL_ERR("Buffer acquire failed with"
> + " err code: %d", ret);
> /* The API expect the exact number of requested bufs */
> /* Releasing all buffers allocated */
> rte_dpaa2_mbuf_release(pool, obj_table, bpid,
> @@ -293,7 +297,8 @@ rte_dpaa2_mbuf_alloc_bulk(struct rte_mempool *pool,
> DPAA2_MODIFY_IOVA_TO_VADDR(bufs[i], size_t);
> obj_table[n] = (struct rte_mbuf *)
> (bufs[i] - bp_info->meta_data_size);
> - PMD_TX_LOG(DEBUG, "Acquired %p address %p from BMAN",
> + DPAA2_MEMPOOL_DP_DEBUG(
> + "Acquired %p address %p from BMAN\n",
> (void *)bufs[i], (void *)obj_table[n]);
> n++;
> }
> @@ -301,8 +306,8 @@ rte_dpaa2_mbuf_alloc_bulk(struct rte_mempool *pool,
>
> #ifdef RTE_LIBRTE_DPAA2_DEBUG_DRIVER
you have maintained "RTE_LIBRTE_DPAA2_DEBUG_DRIVER" flag here, but you
are removing it in next patch from config?