From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98A8E4234F; Thu, 12 Oct 2023 15:56:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 862F6406A2; Thu, 12 Oct 2023 15:56:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A5A73402F2 for ; Thu, 12 Oct 2023 15:56:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697118976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HgVZy3e7AkeMswJxG67yxTelsh0WmIbOGLH9ihdVjtQ=; b=ICyU4Zf9RUrjeoDkp/N9oiJrQPrL3AVUTP9bChzusqUouj51MhhZt0sUjnLGYSgxIVj0pR YhBO9Pz8Gzt8snu2iolCiM3sCy7/htnG021UPfxNYKwkQIrpgfiZsMQ/a1uWuVkjRRugo1 f/FVmN4HTaMt3ekQDf0jI9XUy6xaGVc= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-411-oj28O2TCOzW7qRT6pJtE_w-1; Thu, 12 Oct 2023 09:56:09 -0400 X-MC-Unique: oj28O2TCOzW7qRT6pJtE_w-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 42CC83C17098; Thu, 12 Oct 2023 13:56:09 +0000 (UTC) Received: from [10.39.208.36] (unknown [10.39.208.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6804B400F5B; Thu, 12 Oct 2023 13:56:08 +0000 (UTC) Message-ID: <75afcc78-7e72-1e80-3bb2-61cbae126321@redhat.com> Date: Thu, 12 Oct 2023 15:56:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2] net/virtio: fixed missing next flag when sending packets in packed mode From: Maxime Coquelin To: "liufengjiang.0426" , dev@dpdk.org Cc: chenbo.xia@intel.com, zhangziqian.1@bytedance.com References: <20231009130609.2987-1-liufengjiang.0426@bytedance.com> <20231010020828.2128-1-liufengjiang.0426@bytedance.com> <16321d7a-ee73-c1bf-4818-2d6553d066d1@redhat.com> In-Reply-To: <16321d7a-ee73-c1bf-4818-2d6553d066d1@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, On 10/10/23 09:12, Maxime Coquelin wrote: > Hi, > > Thanks for investigating the issue and proposing a fix! > > On 10/10/23 04:08, liufengjiang.0426 wrote: >> When the packets is sent in packed mode, and the packets data and >> virtio-header are divided into two desc, set the next flag of >> virtio-header desc >> >>>> Fix the warning that a single line of commit log exceeds 75 chars > > The changelog should not be part of the commit message. > >> >> Bugzilla ID: 1295 >> Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues") >> >> Signed-off-by: liufengjiang.0426 > > Could you please sign-off with your full name? Gentle reminder. No need to resubmit, just reply here with your full name. Thanks! Maxime > > >> --- > > The changelog should be placed here. > >>   drivers/net/virtio/virtqueue.h | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/virtio/virtqueue.h >> b/drivers/net/virtio/virtqueue.h >> index 9d4aba11a3..4e9f2d0358 100644 >> --- a/drivers/net/virtio/virtqueue.h >> +++ b/drivers/net/virtio/virtqueue.h >> @@ -672,6 +672,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx >> *txvq, struct rte_mbuf *cookie, >>            */ >>           start_dp[idx].addr = txvq->hdr_mem + >> RTE_PTR_DIFF(&txr[idx].tx_hdr, txr); >>           start_dp[idx].len = vq->hw->vtnet_hdr_size; >> +        head_flags |= VRING_DESC_F_NEXT; >>           hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr; >>           idx++; >>           if (idx >= vq->vq_nentries) { > > Otherwise, the fix look good to me. > With above small changes, it will be good for me. > > Thanks, > Maxime