[dpdk-dev] [PATCH] eal: fix duplicate function declaration

[dpdk-dev] [PATCH] eal: fix duplicate function declaration

[Kevin Laatz]

The rte_eal_get_runtime_dir() function is currently being declared in two
header files.

This API was made public in commit 6911c9fd8fbe, adding it to rte_eal.h. To
make it public, the 'rte' prefix was added to the function so it needed to
be modified in the original location of the declaration, eal_filesystem.h.
By only modifying, and not removing the decalration, it is now a duplicate.

This patch removes the declaration from eal_filesystem.h.

Fixes: 6911c9fd8fbe ("eal: export function to get runtime directory")

Reported-by: Anatoly Burakov <anatoly.burakov@intel.com>
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
 lib/librte_eal/common/eal_filesystem.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/librte_eal/common/eal_filesystem.h b/lib/librte_eal/common/eal_filesystem.h
index b3e8ae5ea..6e0331fdb 100644
--- a/lib/librte_eal/common/eal_filesystem.h
+++ b/lib/librte_eal/common/eal_filesystem.h
@@ -25,10 +25,6 @@
 int
 eal_create_runtime_dir(void);
 
-/* returns runtime dir */
-const char *
-rte_eal_get_runtime_dir(void);
-
 #define RUNTIME_CONFIG_FNAME "config"
 static inline const char *
 eal_runtime_config_path(void)
-- 
2.17.2

Re: [dpdk-dev] [PATCH] eal: fix duplicate function declaration

[Burakov, Anatoly]

On 14-Nov-18 11:14 AM, Kevin Laatz wrote:
> The rte_eal_get_runtime_dir() function is currently being declared in two
> header files.
> 
> This API was made public in commit 6911c9fd8fbe, adding it to rte_eal.h. To
> make it public, the 'rte' prefix was added to the function so it needed to
> be modified in the original location of the declaration, eal_filesystem.h.
> By only modifying, and not removing the decalration, it is now a duplicate.
> 
> This patch removes the declaration from eal_filesystem.h.
> 
> Fixes: 6911c9fd8fbe ("eal: export function to get runtime directory")
> 
> Reported-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly