* [PATCH v1] dts: correct typos in conf.yaml
@ 2024-08-13 17:17 Dean Marx
2024-08-13 18:20 ` Nicholas Pratte
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Dean Marx @ 2024-08-13 17:17 UTC (permalink / raw)
To: probb, npratte, jspewock, luca.vizzarro, yoan.picchi,
Honnappa.Nagarahalli, paul.szczepanek, juraj.linkes
Cc: dev, Dean Marx
correct docstring error in conf.yaml showing incorrect
example pci address for TG nodes
Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
---
dts/conf.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dts/conf.yaml b/dts/conf.yaml
index 7d95016e68..ca5e87636e 100644
--- a/dts/conf.yaml
+++ b/dts/conf.yaml
@@ -39,13 +39,13 @@ nodes:
number_of: 256
force_first_numa: false
ports:
- # sets up the physical link between "SUT 1"@000:00:08.0 and "TG 1"@0000:00:08.0
+ # sets up the physical link between "SUT 1"@0000:00:08.0 and "TG 1"@0000:00:08.0
- pci: "0000:00:08.0"
os_driver_for_dpdk: vfio-pci # OS driver that DPDK will use
os_driver: i40e # OS driver to bind when the tests are not running
peer_node: "TG 1"
peer_pci: "0000:00:08.0"
- # sets up the physical link between "SUT 1"@000:00:08.1 and "TG 1"@0000:00:08.1
+ # sets up the physical link between "SUT 1"@0000:00:08.1 and "TG 1"@0000:00:08.1
- pci: "0000:00:08.1"
os_driver_for_dpdk: vfio-pci
os_driver: i40e
@@ -59,13 +59,13 @@ nodes:
arch: x86_64
os: linux
ports:
- # sets up the physical link between "TG 1"@000:00:08.0 and "SUT 1"@0000:00:08.0
+ # sets up the physical link between "TG 1"@0000:00:08.0 and "SUT 1"@0000:00:08.0
- pci: "0000:00:08.0"
os_driver_for_dpdk: rdma
os_driver: rdma
peer_node: "SUT 1"
peer_pci: "0000:00:08.0"
- # sets up the physical link between "SUT 1"@000:00:08.0 and "TG 1"@0000:00:08.0
+ # sets up the physical link between "SUT 1"@0000:00:08.0 and "TG 1"@0000:00:08.0
- pci: "0000:00:08.1"
os_driver_for_dpdk: rdma
os_driver: rdma
--
2.44.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] dts: correct typos in conf.yaml
2024-08-13 17:17 [PATCH v1] dts: correct typos in conf.yaml Dean Marx
@ 2024-08-13 18:20 ` Nicholas Pratte
2024-08-19 9:29 ` Luca Vizzarro
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Nicholas Pratte @ 2024-08-13 18:20 UTC (permalink / raw)
To: Dean Marx
Cc: probb, jspewock, luca.vizzarro, yoan.picchi,
Honnappa.Nagarahalli, paul.szczepanek, juraj.linkes, dev
Good catch!
Reviewed-by: Nicholas Pratte <npratte@iol.unh.edu>
On Tue, Aug 13, 2024 at 1:17 PM Dean Marx <dmarx@iol.unh.edu> wrote:
>
> correct docstring error in conf.yaml showing incorrect
> example pci address for TG nodes
>
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
> ---
> dts/conf.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/dts/conf.yaml b/dts/conf.yaml
> index 7d95016e68..ca5e87636e 100644
> --- a/dts/conf.yaml
> +++ b/dts/conf.yaml
> @@ -39,13 +39,13 @@ nodes:
> number_of: 256
> force_first_numa: false
> ports:
> - # sets up the physical link between "SUT 1"@000:00:08.0 and "TG 1"@0000:00:08.0
> + # sets up the physical link between "SUT 1"@0000:00:08.0 and "TG 1"@0000:00:08.0
> - pci: "0000:00:08.0"
> os_driver_for_dpdk: vfio-pci # OS driver that DPDK will use
> os_driver: i40e # OS driver to bind when the tests are not running
> peer_node: "TG 1"
> peer_pci: "0000:00:08.0"
> - # sets up the physical link between "SUT 1"@000:00:08.1 and "TG 1"@0000:00:08.1
> + # sets up the physical link between "SUT 1"@0000:00:08.1 and "TG 1"@0000:00:08.1
> - pci: "0000:00:08.1"
> os_driver_for_dpdk: vfio-pci
> os_driver: i40e
> @@ -59,13 +59,13 @@ nodes:
> arch: x86_64
> os: linux
> ports:
> - # sets up the physical link between "TG 1"@000:00:08.0 and "SUT 1"@0000:00:08.0
> + # sets up the physical link between "TG 1"@0000:00:08.0 and "SUT 1"@0000:00:08.0
> - pci: "0000:00:08.0"
> os_driver_for_dpdk: rdma
> os_driver: rdma
> peer_node: "SUT 1"
> peer_pci: "0000:00:08.0"
> - # sets up the physical link between "SUT 1"@000:00:08.0 and "TG 1"@0000:00:08.0
> + # sets up the physical link between "SUT 1"@0000:00:08.0 and "TG 1"@0000:00:08.0
> - pci: "0000:00:08.1"
> os_driver_for_dpdk: rdma
> os_driver: rdma
> --
> 2.44.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] dts: correct typos in conf.yaml
2024-08-13 17:17 [PATCH v1] dts: correct typos in conf.yaml Dean Marx
2024-08-13 18:20 ` Nicholas Pratte
@ 2024-08-19 9:29 ` Luca Vizzarro
2024-08-19 13:29 ` Jeremy Spewock
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Luca Vizzarro @ 2024-08-19 9:29 UTC (permalink / raw)
To: Dean Marx, probb, npratte, jspewock, yoan.picchi,
Honnappa.Nagarahalli, paul.szczepanek, juraj.linkes
Cc: dev
Nice one.
Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] dts: correct typos in conf.yaml
2024-08-13 17:17 [PATCH v1] dts: correct typos in conf.yaml Dean Marx
2024-08-13 18:20 ` Nicholas Pratte
2024-08-19 9:29 ` Luca Vizzarro
@ 2024-08-19 13:29 ` Jeremy Spewock
2024-09-10 8:16 ` Juraj Linkeš
2024-09-11 18:52 ` [PATCH v2] dts: correct typos in user config docstrings Dean Marx
4 siblings, 0 replies; 8+ messages in thread
From: Jeremy Spewock @ 2024-08-19 13:29 UTC (permalink / raw)
To: Dean Marx
Cc: probb, npratte, luca.vizzarro, yoan.picchi, Honnappa.Nagarahalli,
paul.szczepanek, juraj.linkes, dev
Took me a few reads to even find the differences, haha.
On Tue, Aug 13, 2024 at 1:17 PM Dean Marx <dmarx@iol.unh.edu> wrote:
>
> correct docstring error in conf.yaml showing incorrect
> example pci address for TG nodes
>
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
Reviewed-by: Jeremy Spewock <jspewock@iol.unh.edu>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] dts: correct typos in conf.yaml
2024-08-13 17:17 [PATCH v1] dts: correct typos in conf.yaml Dean Marx
` (2 preceding siblings ...)
2024-08-19 13:29 ` Jeremy Spewock
@ 2024-09-10 8:16 ` Juraj Linkeš
2024-09-11 18:52 ` [PATCH v2] dts: correct typos in user config docstrings Dean Marx
4 siblings, 0 replies; 8+ messages in thread
From: Juraj Linkeš @ 2024-09-10 8:16 UTC (permalink / raw)
To: Dean Marx, probb, npratte, jspewock, luca.vizzarro, yoan.picchi,
Honnappa.Nagarahalli, paul.szczepanek
Cc: dev
The subject should be more specific. We don't want a bunch of commits
with the same subject.
On 13. 8. 2024 19:17, Dean Marx wrote:
> correct docstring error in conf.yaml showing incorrect
> example pci address for TG nodes
>
This should be a regular sentence that starts with a capital letter and
ends with a dot
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
With those two changes,
Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] dts: correct typos in user config docstrings
2024-08-13 17:17 [PATCH v1] dts: correct typos in conf.yaml Dean Marx
` (3 preceding siblings ...)
2024-09-10 8:16 ` Juraj Linkeš
@ 2024-09-11 18:52 ` Dean Marx
2024-09-18 20:31 ` [PATCH v3] " Dean Marx
4 siblings, 1 reply; 8+ messages in thread
From: Dean Marx @ 2024-09-11 18:52 UTC (permalink / raw)
To: probb, npratte, jspewock, luca.vizzarro, yoan.picchi,
Honnappa.Nagarahalli, paul.szczepanek, juraj.linkes
Cc: dev, Dean Marx
Correct docstring error in conf.yaml showing incorrect
example pci address for TG nodes.
Fixes: 55442c14297c ("dts: improve documentation")
Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
Reviewed-by: Nicholas Pratte <npratte@iol.unh.edu>
Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
Reviewed-by: Jeremy Spewock <jspewock@iol.unh.edu>
Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
dts/conf.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dts/conf.yaml b/dts/conf.yaml
index 7d95016e68..ca5e87636e 100644
--- a/dts/conf.yaml
+++ b/dts/conf.yaml
@@ -39,13 +39,13 @@ nodes:
number_of: 256
force_first_numa: false
ports:
- # sets up the physical link between "SUT 1"@000:00:08.0 and "TG 1"@0000:00:08.0
+ # sets up the physical link between "SUT 1"@0000:00:08.0 and "TG 1"@0000:00:08.0
- pci: "0000:00:08.0"
os_driver_for_dpdk: vfio-pci # OS driver that DPDK will use
os_driver: i40e # OS driver to bind when the tests are not running
peer_node: "TG 1"
peer_pci: "0000:00:08.0"
- # sets up the physical link between "SUT 1"@000:00:08.1 and "TG 1"@0000:00:08.1
+ # sets up the physical link between "SUT 1"@0000:00:08.1 and "TG 1"@0000:00:08.1
- pci: "0000:00:08.1"
os_driver_for_dpdk: vfio-pci
os_driver: i40e
@@ -59,13 +59,13 @@ nodes:
arch: x86_64
os: linux
ports:
- # sets up the physical link between "TG 1"@000:00:08.0 and "SUT 1"@0000:00:08.0
+ # sets up the physical link between "TG 1"@0000:00:08.0 and "SUT 1"@0000:00:08.0
- pci: "0000:00:08.0"
os_driver_for_dpdk: rdma
os_driver: rdma
peer_node: "SUT 1"
peer_pci: "0000:00:08.0"
- # sets up the physical link between "SUT 1"@000:00:08.0 and "TG 1"@0000:00:08.0
+ # sets up the physical link between "SUT 1"@0000:00:08.0 and "TG 1"@0000:00:08.0
- pci: "0000:00:08.1"
os_driver_for_dpdk: rdma
os_driver: rdma
--
2.44.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3] dts: correct typos in user config docstrings
2024-09-11 18:52 ` [PATCH v2] dts: correct typos in user config docstrings Dean Marx
@ 2024-09-18 20:31 ` Dean Marx
2024-09-19 9:33 ` Juraj Linkeš
0 siblings, 1 reply; 8+ messages in thread
From: Dean Marx @ 2024-09-18 20:31 UTC (permalink / raw)
To: probb, npratte, jspewock, luca.vizzarro, yoan.picchi,
Honnappa.Nagarahalli, paul.szczepanek, juraj.linkes
Cc: dev, Dean Marx
Correct docstring error in conf.yaml showing incorrect
example pci address for TG nodes.
Fixes: 55442c14297c ("dts: improve documentation")
Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
Reviewed-by: Nicholas Pratte <npratte@iol.unh.edu>
Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
Reviewed-by: Jeremy Spewock <jspewock@iol.unh.edu>
Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
dts/conf.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dts/conf.yaml b/dts/conf.yaml
index 7d95016e68..ca5e87636e 100644
--- a/dts/conf.yaml
+++ b/dts/conf.yaml
@@ -39,13 +39,13 @@ nodes:
number_of: 256
force_first_numa: false
ports:
- # sets up the physical link between "SUT 1"@000:00:08.0 and "TG 1"@0000:00:08.0
+ # sets up the physical link between "SUT 1"@0000:00:08.0 and "TG 1"@0000:00:08.0
- pci: "0000:00:08.0"
os_driver_for_dpdk: vfio-pci # OS driver that DPDK will use
os_driver: i40e # OS driver to bind when the tests are not running
peer_node: "TG 1"
peer_pci: "0000:00:08.0"
- # sets up the physical link between "SUT 1"@000:00:08.1 and "TG 1"@0000:00:08.1
+ # sets up the physical link between "SUT 1"@0000:00:08.1 and "TG 1"@0000:00:08.1
- pci: "0000:00:08.1"
os_driver_for_dpdk: vfio-pci
os_driver: i40e
@@ -59,13 +59,13 @@ nodes:
arch: x86_64
os: linux
ports:
- # sets up the physical link between "TG 1"@000:00:08.0 and "SUT 1"@0000:00:08.0
+ # sets up the physical link between "TG 1"@0000:00:08.0 and "SUT 1"@0000:00:08.0
- pci: "0000:00:08.0"
os_driver_for_dpdk: rdma
os_driver: rdma
peer_node: "SUT 1"
peer_pci: "0000:00:08.0"
- # sets up the physical link between "SUT 1"@000:00:08.0 and "TG 1"@0000:00:08.0
+ # sets up the physical link between "SUT 1"@0000:00:08.0 and "TG 1"@0000:00:08.0
- pci: "0000:00:08.1"
os_driver_for_dpdk: rdma
os_driver: rdma
--
2.44.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3] dts: correct typos in user config docstrings
2024-09-18 20:31 ` [PATCH v3] " Dean Marx
@ 2024-09-19 9:33 ` Juraj Linkeš
0 siblings, 0 replies; 8+ messages in thread
From: Juraj Linkeš @ 2024-09-19 9:33 UTC (permalink / raw)
To: Dean Marx, probb, npratte, jspewock, luca.vizzarro, yoan.picchi,
Honnappa.Nagarahalli, paul.szczepanek
Cc: dev
On 18. 9. 2024 22:31, Dean Marx wrote:
> Correct docstring error in conf.yaml showing incorrect
> example pci address for TG nodes.
>
> Fixes: 55442c14297c ("dts: improve documentation")
>
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
> Reviewed-by: Nicholas Pratte <npratte@iol.unh.edu>
> Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
> Reviewed-by: Jeremy Spewock <jspewock@iol.unh.edu>
> Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
Applied to next-dts, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-09-19 9:33 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-13 17:17 [PATCH v1] dts: correct typos in conf.yaml Dean Marx
2024-08-13 18:20 ` Nicholas Pratte
2024-08-19 9:29 ` Luca Vizzarro
2024-08-19 13:29 ` Jeremy Spewock
2024-09-10 8:16 ` Juraj Linkeš
2024-09-11 18:52 ` [PATCH v2] dts: correct typos in user config docstrings Dean Marx
2024-09-18 20:31 ` [PATCH v3] " Dean Marx
2024-09-19 9:33 ` Juraj Linkeš
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).