From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Long Li <longli@microsoft.com>,
wangyunjian <wangyunjian@huawei.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
"jerry.lilijun@huawei.com" <jerry.lilijun@huawei.com>,
"xudingke@huawei.com" <xudingke@huawei.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/netvsc: fix txq leak in error path
Date: Fri, 9 Oct 2020 12:36:38 +0100 [thread overview]
Message-ID: <76016872-6d1d-ea2f-b281-dec89af764d4@intel.com> (raw)
In-Reply-To: <BYAPR21MB11596B362F3172D09C34BBD9CE080@BYAPR21MB1159.namprd21.prod.outlook.com>
On 10/9/2020 4:53 AM, Long Li wrote:
>> Subject: [dpdk-dev] [PATCH v2] net/netvsc: fix txq leak in error path
>>
>> From: Yunjian Wang <wangyunjian@huawei.com>
>>
>> In hn_dev_tx_queue_setup() allocated memory for txq, we don't free it
>> when error happens and it will lead to memory leak.
>>
>> We can check for tx_free_thresh at the beginning of the function to fix it,
>> before calling txq = rte_zmalloc_socket().
>>
>> Fixes: cc0251813277 ("net/netvsc: split send buffers from Tx descriptors")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>
> Acked-by: Long Li <longli@microsoft.com>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2020-10-09 11:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 13:44 [dpdk-dev] [PATCH] " wangyunjian
2020-09-30 22:27 ` Long Li
2020-10-02 14:25 ` Yunjian Wang
2020-10-07 2:06 ` [dpdk-dev] [PATCH v2] " wangyunjian
2020-10-09 3:53 ` Long Li
2020-10-09 11:36 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76016872-6d1d-ea2f-b281-dec89af764d4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=haiyangz@microsoft.com \
--cc=jerry.lilijun@huawei.com \
--cc=kys@microsoft.com \
--cc=longli@microsoft.com \
--cc=stable@dpdk.org \
--cc=sthemmin@microsoft.com \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).