From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 6A629C458 for ; Wed, 17 Jun 2015 16:02:18 +0200 (CEST) Received: by wiga1 with SMTP id a1so140735173wig.0 for ; Wed, 17 Jun 2015 07:02:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Q24udm66mVp0uchyzCr8V2SgttikC6JGBOD9sJQCC60=; b=L1oD30UgELJfNg38jYKeXvlRW1azq4Mukh5ReUBEPtwyTvJTZBXwYPxQeyvucHGGDm y9RCsrypCTpsxeXaRHzbo4TonFXqF1/SveXHq3x0AbLw9mszhz8UTNbgWmDLGpvCy36S wjCdaM3xo3+fT8SiuYQtSB80YRarl04txzgOjMwjOaJXZ2P74Kcq4MFOzvctMnIgwhRD Eeepgg1SBGAhS1ehC2vyenyMnF3vJ/ys5KudxE7rfLsZ4XKRXOTT+7e36syRQH2KEyGR PU9LkcWlZMp3jojijeFGzBIAEmrU/KLedxBGhw4LDZAz8VMpDaUa+/CVkEUQVXPu6meD PD7A== X-Gm-Message-State: ALoCoQmcXuJnk/LcYvftBWMnREgK/9mCCVEhmtIb5ArSlfa8u/8n9SLdqQ+i05ClmgPwGeAPwCc9 X-Received: by 10.180.82.135 with SMTP id i7mr56183890wiy.68.1434549738314; Wed, 17 Jun 2015 07:02:18 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id l6sm26162499wib.18.2015.06.17.07.02.17 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jun 2015 07:02:17 -0700 (PDT) From: Thomas Monjalon To: Maryam Tahhan Date: Wed, 17 Jun 2015 16:01:18 +0200 Message-ID: <7603426.jST2jPJP37@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <20150609172954.173d26d0@urahara> References: <1433862646-91880-1-git-send-email-maryam.tahhan@intel.com> <1433862646-91880-2-git-send-email-maryam.tahhan@intel.com> <20150609172954.173d26d0@urahara> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/7] ethdev: add additional error stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 14:02:18 -0000 2015-06-09 17:29, Stephen Hemminger: > On Tue, 9 Jun 2015 16:10:40 +0100 > Maryam Tahhan wrote: > > > Add MAC error and drop statistics to struct rte_eth_stats and the > > extended stats. > > Signed-off-by: Maryam Tahhan > > --- > > lib/librte_ether/rte_ethdev.c | 4 ++++ > > lib/librte_ether/rte_ethdev.h | 4 ++++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > > index 5a94654..a439b4a 100644 > > --- a/lib/librte_ether/rte_ethdev.c > > +++ b/lib/librte_ether/rte_ethdev.c > > @@ -136,6 +136,10 @@ static const struct rte_eth_xstats_name_off rte_stats_strings[] = { > > {"rx_flow_control_xon", offsetof(struct rte_eth_stats, rx_pause_xon)}, > > {"tx_flow_control_xoff", offsetof(struct rte_eth_stats, tx_pause_xoff)}, > > {"rx_flow_control_xoff", offsetof(struct rte_eth_stats, rx_pause_xoff)}, > > + {"rx_mac_err", offsetof(struct rte_eth_stats, imacerr)}, > > + {"rx_phy_err", offsetof(struct rte_eth_stats, iphyerr)}, > > + {"tx_drops", offsetof(struct rte_eth_stats, odrop)}, > > + {"rx_drops", offsetof(struct rte_eth_stats, idrop)} > > Are these really generic enough to put them in ethdev? No, as explained here: http://dpdk.org/ml/archives/dev/2015-June/019550.html Please rework. Thanks