From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D901B43A3B; Thu, 1 Feb 2024 19:56:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BA44402F2; Thu, 1 Feb 2024 19:56:51 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2058.outbound.protection.outlook.com [40.107.220.58]) by mails.dpdk.org (Postfix) with ESMTP id 1FFDB402B9 for ; Thu, 1 Feb 2024 19:56:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y5/616spnAncau6VDpAu/uy752AdvOzLI75NBTlYjTcCXgmhZFmvY8Ks14gcRx/rMoxjQeY1TtTogMbPwqxJfJ8flf/L5Gy8RQkJEw/9ysybK4tPtUn4u/05KdJz12+7Pm5bdP7tTIYE9WaIqVL+g1kWlZKaHjEdRWJOWwFB6KQ3D/JjW3zYQF9VodpmeglRLZhP5sw5ZV7ME7gAIlkLfnrXn1lJ8LUOKNuVVglGsW5i9IIWXk6uPXMISCXBNqljUfbSiqm6Mcv1CnO+GdTWWMQZRxi+g3HQx7bvtmef7YIo6sGpwA3o5MmEFTYm+3s7fkWvERA3c9PMxK/Ajeom5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ULfVg+X/A7n26rodXMyd0G+bokhUtMZAYi9KPpkPy/c=; b=N5dyhUDfbF/pbB9hmBS22vBomG3QRn1b34MEnQJmlsS7ZmI9iEo/1qK3RqUEATd2VnYRS/mjntJ8/Nxz0b2P/QIwyiMO+9lh+vMjMQALs8DRopn+7z+1uyQLuHOAhPMtBmKRENr1M4VOjXJpAokmYkRSb18axkWC0LYEDiBvZCRZPobVzJlbuUNfGOjzikT5qnB0kcwz79rtZTQJhp0KJHfv6fXUIcDPMo/RfkC519zvj/oljGL9NslfKZy7VMcjbADbz5MNto+7aTxelXRO61NbLmd53nfUkKOuMqjz0SboLzcCyFDmd3s81KSkoU37Peg3mldCC98oq2RK3gezow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ULfVg+X/A7n26rodXMyd0G+bokhUtMZAYi9KPpkPy/c=; b=x2BKjeYShjpsqNc/UA/dilotKLPHJCjLSJivDmX+dYT03Y/rwSEe/JWTyFJrMs7bDVyf0ViYDr1+nCHKM5GYpVTS7JESp3tZIS3kPHCTB6vNMibBCiZ66X4VI+ezSQDTkRrfHU8i7vRib5SxugmESoD9Uh0F2uliNSM7v/qOT94= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ2PR12MB7918.namprd12.prod.outlook.com (2603:10b6:a03:4cc::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.11; Thu, 1 Feb 2024 18:56:45 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7270.010; Thu, 1 Feb 2024 18:56:45 +0000 Message-ID: <76142ac0-c55a-41bd-bd1d-294be18919eb@amd.com> Date: Thu, 1 Feb 2024 18:56:22 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE Content-Language: en-US To: Suanming Mou Cc: dev@dpdk.org, orika@nvidia.com References: <20231214031227.363911-1-suanmingm@nvidia.com> <20240201122922.474250-1-suanmingm@nvidia.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240201122922.474250-1-suanmingm@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0220.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ2PR12MB7918:EE_ X-MS-Office365-Filtering-Correlation-Id: 07a4ee6b-e0fd-4943-8d58-08dc23577df7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2Elgh9HjoZgzVk+yC4AfsL/uAwdY/IL8sIvgNs6UidWexTjsr2FnL7rPJmzOAEeR2N4F9FVrVb5tu31n0Mq1CISO+bTq3365I79UCkzKp4FErZmJsCUsvB6dcui2Ls/NrHmRfSGkwJIloSRSPamAaYv1a/rgn4PqVcuK8hqQbHDO0MDrIXJifpXgJbCa/vOU5TKalf6u4q4S1gtH/gKXfYyBIoWkskYbjDEgfLdPiDxaXAWcJovRB0MiqU+LU5kjQzVWJzCyAMaJuhSMAYF33p6Lc88YPfQBW/XjuFOWki1nsePcXFNKCrPFVS2qGGmlX2JhY3vwe2B3cwUMT4it4J9a4DD3rOYqHrJffKdQP8utOGg+Tr25YQnmfzY/ZokskripSmNLBubg/YE1IcG/oW3VwRx2TkZj5t6ek12uNpl+xT3alIjuIJQ42o0FrIm8uBlMmoDQz8ePYFRAycz5qgsQQ9Ub9a+/N2Jzyyobe+/oiDvbBo4LVjpuHaMKxHtF5CXXWzkCy9K+fmKr3oZ0uWvakm4Gy7Tw+jHcfvS8Sh8krx8gQ5dFEzlsD/3eHuTD/m1xPztKOu/1fbst/yeCCG9yy67nsOEQzsTkFJLPMNjoPenK+drHBTW6mwvjItRs4ATB8BFLNFo3HGVYNpotdw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(366004)(39860400002)(396003)(376002)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(41300700001)(6512007)(26005)(2616005)(38100700002)(8676002)(44832011)(8936002)(4326008)(5660300002)(6666004)(6486002)(2906002)(478600001)(53546011)(6506007)(66476007)(66556008)(316002)(6916009)(66946007)(31696002)(86362001)(36756003)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTNDZnhaQ0xEV0l3VXBncThuYXdBS2hnakZNTTZzNno3dy9tYzZKUFlWSXo5?= =?utf-8?B?d2FkVDVubHhyY0pzemRUNzA4SkNYVURnOFNCRGkvTXhyTDcxZEQzN0xkQTI4?= =?utf-8?B?aUlxT0RIQ1FUOVlDTWpBSXpiUnVHNjhDTnFkaTBKeU5CcjBFYlZCNzRZYjRE?= =?utf-8?B?N3dwWlNMRyt4UHdRR0ZMSzkvbWhzc2IvTklISGtKZWRVQTVhRDN3Q2czU2ZY?= =?utf-8?B?eTVJbXhQTzI4d2dKMktabjFOeE9nK0VVc1hPSjkwSldFR2d2OUpwTHdNcE5i?= =?utf-8?B?WDd0STNXWUZ1YzQ5ZVJWQ0dDNXBjRFNTT3BwZThFc0pKSmRsc3phbTZBQ0cx?= =?utf-8?B?OUxPL040T3U4LzZ5VFVSeVI0WVFVVlZIcTNUd1R4aytHMG5lKzVFNEFqVkl5?= =?utf-8?B?S1pCT0xaaDg0UkNobmRSbWQ2QVdNOVJkdHNDWHZJTVVVN1RSbkhDS3o3TURk?= =?utf-8?B?US9QSmxURTBERW1IY3cwWGEwa2FvamcxRDVvdWRrSm54b2RSNUY2MEREK1JT?= =?utf-8?B?OHR5MmR3Yytwc0FkS2I3cjVaQ3dSOU9qcWhEdnMxcVlZaXlyTm4veEJNZVlH?= =?utf-8?B?OU9LSDJPYXBxelVESndSUkcwSHpmU3pTUUJyL0xjQVlyQjFyS3FyWlYyTEdB?= =?utf-8?B?cHpGZmxqTzJsbTduT29NbHBRdFVQYUo1S2FiNTV1VFVicEgzak5raGorWFVl?= =?utf-8?B?R0w0TktuSzlqRXJlNjEwYzB6SFQ2dlRVd1ZGU3VGSGVNeDlTbU5zVjdxb2hF?= =?utf-8?B?V3IvZ2tyWTYzQzIyMnhwMnY5K1I4N3FXMFRZY09qSFgxOU9KTFN6THU4V2tj?= =?utf-8?B?WDRQVUY1ZHFKUkordkJNcVIvbDhtQ25lWW1rUGdObVNQOVdKN2RobjdpWW1a?= =?utf-8?B?YTIxYVc3cjY3QW1jQmNyYUt4bUFCZlhRYlFRSklGbWF3cFJzQmhvVlBJOTF3?= =?utf-8?B?N2ZvcW9tdDhWWmtnVm04WDJYcG0veVhMYUM0NnFYY3EyQTBlWmJaRUtKWFlV?= =?utf-8?B?VFk5Z3loQ3YvRlVlYmV4Njhqb244aG1EOXVaYUFjK0pLUFJLTklsdU50amtN?= =?utf-8?B?ZVMxUnJ5alE3RXk0S0hJUWx3czZyV3Vja3NlU0NLaW1oNUJ5YU42U1Z2emhQ?= =?utf-8?B?eGR5dURDc05wZ3FCUk8xMXRxWUFyRUNFUFFhREFoRUxNcW9FMmNZUGlUSE9w?= =?utf-8?B?WkxUZklGdGV1U2lCN1hiZHJXZjJENWd1SW41bVg3azhqd3cwMHhCUlEvemNZ?= =?utf-8?B?YU1mYTl0bElVbDMyeEFXdlhpSkcvQ1pHdE45amN2VDByeUt6ZzJUNnNrcWh3?= =?utf-8?B?K25tODFZMHk3VEN4NndhYXJXcEY3SW1GN1IvTlJQYURTTk5DYXBrdXRhWWds?= =?utf-8?B?cUdqajBoRU9oeHFyODZkc2hVTUdzQmpEdHJyOU43OXIvTUFIeWNhWHV1K2du?= =?utf-8?B?WUtCZHBzbGwzZkxXL0ltTHdEK3U1bkNVNHRyTXEvMXN5ckZZaUI5S1BqaFBk?= =?utf-8?B?SG1VQUFxMmV2SERsR0JuUWNBMVNWSWdnbk9JVnQ1UkVJSkhJMzhyK3NSdXMz?= =?utf-8?B?Q3dSdVhXaWE4T0ZZWFdVbFFJQTNGWkZSZkNLVndhSXZpK0loZ2JEc1JNQVp2?= =?utf-8?B?TFd3bmdnWkhrckpaWkFRbGh2VEZadmR2cm9VbytzcCthSVBDYjVsUHlqQWFx?= =?utf-8?B?NXc0ZFFjakdzeWFram5CNVU4TFpPTExoTUgxUXBUTENYWVFOcFJWN3Q1dW5G?= =?utf-8?B?dVhMa1Ruek1KVnRrdWMvd1VPMXRtaG9leUNOZG5hZUJnTU5xL05qWWFWcUpD?= =?utf-8?B?WEhFVzhTbk82TnB6S0NoZ2ppbTM4Ziswd3dUSGJjR0pVMWNiSy95WVlJK2lt?= =?utf-8?B?bHo4enFmdHdZVzkzUUQrQlhUTVhPU1J2OVgyTzl6YWhvUFgzejhJSUFuRFds?= =?utf-8?B?bG92SUtDTlFLeXdZMEQwbDZ4OGs4Y3B1SlQrTHViZlViMzV4ZTdCblYrVXUr?= =?utf-8?B?UzZGYXFTUWhwTzJDM0dyMHNFUlQ5L0ZlQ2tHK1VWU2U5YTNIRnpwdm9INk1I?= =?utf-8?B?bEJxYk9LdThJMVpwYmVFL0I5V2FqeStnNWN1ZlI4b3lLVEVOQjVhME9SOW1T?= =?utf-8?Q?YspQbTwndrLtsA+0xvdkkmBzQ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07a4ee6b-e0fd-4943-8d58-08dc23577df7 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 18:56:45.6463 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 19OvT52CDc8qLnfPinJsz8Pgm0q/Fl95Mxl/OIM69pd+8STjnnH2qMBPrN3TTwsN X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7918 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/1/2024 12:29 PM, Suanming Mou wrote: > The new item type is added for the case user wants to match traffic > based on packet field compare result with other fields or immediate > value. > > e.g. take advantage the compare item user will be able to accumulate > a IPv4/TCP packet's TCP data_offset and IPv4 IHL field to a tag > register, then compare the tag register with IPv4 header total length > to understand the packet has payload or not. > > The supported operations can be as below: > - RTE_FLOW_ITEM_COMPARE_EQ (equal) > - RTE_FLOW_ITEM_COMPARE_NE (not equal) > - RTE_FLOW_ITEM_COMPARE_LT (less than) > - RTE_FLOW_ITEM_COMPARE_LE (less than or equal) > - RTE_FLOW_ITEM_COMPARE_GT (great than) > - RTE_FLOW_ITEM_COMPARE_GE (great than or equal) > > V5: > - rebase on top of next-net > - add sample detail for rte_flow_field. > > V4: > - rebase on top of the latest version. > - move ACTION_MODIFY_PATTERN_SIZE and modify_field_ids rename > to first patch. > - add comparison flow create sample in testpmd_funcs.rst. > > V3: > - fix code style missing empty line in rte_flow.rst. > - fix missing the ABI change release notes. > > V2: > - Since modify field data struct is experiment, rename modify > field data directly instead of adding new flow field struct. > > > Suanming Mou (3): > ethdev: rename action modify field data structure > ethdev: add compare item > net/mlx5: add compare item support > Mostly looks good, please find comments on a few minor issues on patches.