From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C829441C24; Mon, 6 Feb 2023 19:46:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C96D410D1; Mon, 6 Feb 2023 19:46:32 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id D33B240156 for ; Mon, 6 Feb 2023 19:46:31 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 517255C00DD; Mon, 6 Feb 2023 13:46:31 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 06 Feb 2023 13:46:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675709191; x= 1675795591; bh=Mp9Pj8OPgLPLLtSgVeV1dLSGdJV2ovK9qyZ/ZD3Uo0M=; b=u Noz3SB0k7zFaPvE8n4U7+eNMXgbhuiiVzS/ezLrBskzxMlNTHNiq9Gr/avAAzcS1 gA7UEDson2hxhsq5mZko6LPPJucZ9uvZuumDnGyf+s3B2Me9fHMjl7ysDmsI9UlJ 40Ok2Ry2RHNUadV7cIzar5aX7yisCHfqONXPK/x+kp7RS9GYqAGiKV8Y0af6IKt9 gjuhEfE1hxuyMfK9sgY1K9GrezSMFo9Auj5GmhH557HbEKx6873pERRUbFo2UsXB iWACRRCbowexCq678gaA5xX/Lut9UKDru7wC8o7nPDwElc4LTtgBiWU3P2jU4+4S /94i2MfSbbx70e75c0VCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675709191; x= 1675795591; bh=Mp9Pj8OPgLPLLtSgVeV1dLSGdJV2ovK9qyZ/ZD3Uo0M=; b=F 3miKK5GLQjXzNYh11m7S95MCOq4mGu4pi6G0uQ/9Mrav5NEZEz5a3jxHuc5kyo7v Utw7GO04C/vtBFVNGolt5Cv867KiXWAj/7K+Qk4FMubXDBwV/AObJjr/urSRbnVy DwvI50CsypNmM/HsjaEDvpoakxupbF4psxjJE+PElNv/EIfgR2tRpWmL3xstaRy8 iJhkKmhoD4vxDuJAAgCRUgmf0WqWwSlYWozRtFOKt5vjji7SSZLlSknvN944d+qo rpr0kg5BBAqe6jFQTgK0bmoeZ9+FkbY6H5QtMZcmCvtZIi/2umOWTHYd8sXjg3NN CBzQoCVIXyllMmqb8ZJmQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegiedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Feb 2023 13:46:30 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger , Sinan Kaya Cc: Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org Subject: Re: [PATCH v3 10/10] bus/vdev: check result of rte_vdev_device_name Date: Mon, 06 Feb 2023 19:46:28 +0100 Message-ID: <7618783.lvqk35OSZv@thomas> In-Reply-To: References: <20230120044140.95975-1-okaya@kernel.org> <4942344.1oUyQt6lIG@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 06/02/2023 17:01, Sinan Kaya: > On Sun, 2023-01-22 at 21:51 +0100, Thomas Monjalon wrote: > > 20/01/2023 17:47, Stephen Hemminger: > > > On Thu, 19 Jan 2023 23:41:40 -0500 > > > okaya@kernel.org wrote: > > > > > > > diff --git a/lib/ethdev/ethdev_vdev.h b/lib/ethdev/ethdev_vdev.h > > > > index 364f140f91..6d94a65d97 100644 > > > > --- a/lib/ethdev/ethdev_vdev.h > > > > +++ b/lib/ethdev/ethdev_vdev.h > > > > @@ -34,6 +34,8 @@ rte_eth_vdev_allocate(struct rte_vdev_device > > > > *dev, size_t private_data_size) > > > > { > > > > struct rte_eth_dev *eth_dev; > > > > const char *name = rte_vdev_device_name(dev); > > > > + if (name == NULL) > > > > + return NULL; > > > > > > Please add a blank line after declarations and before code. > > > For some reason the DPDK version of checkpatch suppresses this > > > warning. > > > > The check of "name" is related to the line above, > > so I don't think we should insert a blank line. > > While I'm waiting for maintainer feedback, let me know which > way I should go. I can update this for next rev. It's just a matter of taste, not a big deal. I think you can keep it as-is.