From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nbfkord-smmo02.seg.att.com (nbfkord-smmo02.seg.att.com [209.65.160.78]) by dpdk.org (Postfix) with ESMTP id 42F0F2BA7 for ; Thu, 24 Nov 2016 15:46:33 +0100 (CET) Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id a4df6385.2b9290646940.1692264.00-2469.3764681.nbfkord-smmo02.seg.att.com (envelope-from ); Thu, 24 Nov 2016 14:46:34 +0000 (UTC) X-MXL-Hash: 5836fd4a57cd6776-32f93a086eef5788985861229be4014137bd21ac Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) over TLS secured channel with ESMTP id 64df6385.0.1692262.00-2372.3764677.nbfkord-smmo02.seg.att.com (envelope-from ); Thu, 24 Nov 2016 14:46:31 +0000 (UTC) X-MXL-Hash: 5836fd4745f032d6-fe31401ca66f7ef875cffefffa145307163da6d0 Received: from [192.168.38.17] (84.52.89.52) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 24 Nov 2016 14:46:25 +0000 To: Ferruh Yigit , References: <1479740470-6723-1-git-send-email-arybchenko@solarflare.com> <1479740470-6723-34-git-send-email-arybchenko@solarflare.com> From: Andrew Rybchenko Message-ID: <761a631e-db77-6b0b-a59a-71f01e7c3e71@solarflare.com> Date: Thu, 24 Nov 2016 17:46:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [84.52.89.52] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-22718.003 X-TM-AS-Result: No--9.679800-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.1 cv=UI/baXry c=1 sm=1 tr=0 a=8P+NB+fYZDP74ap4g4d9Kw==] X-AnalysisOut: [:17 a=RB3BGLmKESwA:10 a=L24OOQBejmoA:10 a=zRKbQ67AAAAA:8 a] X-AnalysisOut: [=9ZPw4ZbOCNdYJN0XucQA:9 a=pILNOxqGKmIA:10 a=QyXUC8HyAAAA:8] X-AnalysisOut: [ a=iNNNxVtGsUlIOOQmYbgA:9 a=fzyhpxC6IcGyHGd-:21 a=_W_S_7Ve] X-AnalysisOut: [coQA:10 a=PA03WX8tBzeizutn5_OT:22 a=avl4LiGQNoF5OB0DmCJ7:2] X-AnalysisOut: [2] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [193.34.186.16] Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 33/56] net/sfc: add device configure and close stubs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 14:46:34 -0000 On 11/23/2016 06:26 PM, Ferruh Yigit wrote: > On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: >> Reviewed-by: Andy Moreton >> Signed-off-by: Andrew Rybchenko >> --- > <...> > >> diff --git a/drivers/net/sfc/efx/sfc.h b/drivers/net/sfc/efx/sfc.h >> index 01d652d..d040f98 100644 >> --- a/drivers/net/sfc/efx/sfc.h >> +++ b/drivers/net/sfc/efx/sfc.h > <...> >> @@ -131,7 +147,7 @@ sfc_adapter_unlock(struct sfc_adapter *sa) >> } >> >> static inline void >> -sfc_adapter_lock_destroy(struct sfc_adapter *sa) >> +sfc_adapter_lock_fini(struct sfc_adapter *sa) > Why not do proper naming in 32/56 at first place? Thanks, will be fixed in v2. > <...>