From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4661A054F; Tue, 16 Mar 2021 11:37:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 798EF2427C1; Tue, 16 Mar 2021 11:37:34 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id AE4704069F for ; Tue, 16 Mar 2021 11:37:33 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 1612A58094B; Tue, 16 Mar 2021 06:37:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 16 Mar 2021 06:37:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= HmPYDc4P/ZP+uAlJ8pIwLiNv283w/xHPzHJ2SAx7gCk=; b=ft7Ym4YVsxQND2oK 5/e4LelMQHVnT42E3n7ybt+B1GF6xv+y5T4R2cGBWiTh3ovt270t4/pvQUtIx9aB F7kuK4nOF8Rcg2s8muFqMD5HuDp8S5FzpkIl30PZ/PlWFLavyyLwSgWkDde9DNx/ ZIyCHpFg348jZievaGFs9gphTYy8c9o71JOppDkw9qWUsnFanD4d+fRM+T+kvbem obz7AZ/Y8Z5gxpHPdyhY00UuowF9yMv7ik7g89yWIDPOx9x8AHQc6r1OwHp+MkmX BctLeM1eXEsCwUkRBWLlxcxuzJC7kjSWJE07zk8cGUbNDQW+XMTyCVRu8l+5bJ9Z n1ep8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=HmPYDc4P/ZP+uAlJ8pIwLiNv283w/xHPzHJ2SAx7g Ck=; b=NBBtDBe8LF58tmnMvnmPgrVNBXibHxdQ9eMoSRNwuQN+mLwKT0YGC6qSg Q6HJAcHTIwfAzYFNKnUwGcpvvbvcjUWRsY/NO02u+7u6FM2m0HOqmsbQBGZb1KbC bwfIeTVtV0vidw0kkqUZxmfwMI1oNXldie21t4d4TJCXT7ZV49aU6FR50XHEeuKm Vhb0dCVippFjOeopFH7infSaM25NjylsZik/VVO/3ugTGSUCgtWVNse8fA3dsMmY Nbly2tiHbo7Pg5LPLOiIcJKM35fo7+iefs4WJ5gvneazpUDU3vXhccYwwM61x/TG WDVirAJWPhwEFNMNpXB1py3FVXrWA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefvddgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0AE4E240054; Tue, 16 Mar 2021 06:37:29 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Ferruh Yigit , Pallavi Kadam , Dmitry Malloy , Narcisa Ana Maria Vasile , Stephen Hemminger , Tyler Retzlaff , Declan Doherty , Fiona Trahe , Ashish Gupta , Ray Kinsella , david.marchand@redhat.com, bruce.richardson@intel.com Date: Tue, 16 Mar 2021 11:37:28 +0100 Message-ID: <7623219.0ubQs4pKDL@thomas> In-Reply-To: <20210310235421.23259-1-dmitry.kozliuk@gmail.com> References: <20210303225121.16146-1-dmitry.kozliuk@gmail.com> <20210310235421.23259-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] doc: announce API changes for Windows compatibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/03/2021 00:54, Dmitry Kozlyuk: > Windows socket headers define `s_addr`, `min`, and `max` macros which > break structure definitions containing fields with one of these names. > Undefining those macros would break some consumers as well. > > Example 1: > > #include > #include > struct in_addr addr; > /* addr.s_addr = 0; ERROR: s_addr undefined by DPDK */ > > Example 2: > > #include > #include > struct rte_ether_hdr eh; > /* eh.s_addr.addr_bytes[0] = 0; ERROR: `addr_s` is a macro */ > > It is proposed to rename the conflicting fields on DPDK side, > because Win32 API has wider use and is slower and harder to change. > > New names are left unspecified, open suggestions: > > * `struct rte_ether_hdr` (by Stephen Hemminger): > > * `s_addr` -> `ether_shost` > * `d_addr` -> `ether_dhost` (for consistency) I prefer "addr" over "host". > * `struct rte_param_log2_range`, `struct rte_crypto_param_range`: > > * `min` -> `minimum` > * `max` -> `maximum` > > For `s_addr`, a workaround is possible to use it until 21.11. > For `min` and `max`, no workaround seems available. If cryptodev or > compressdev is going to be enabled on Windows before 21.11, the only > option seems to use a new name on Windows (using #ifdef). I think we have enough work on ethdev until 21.11.