[dpdk-dev] [PATCH] eal: copy optarg when parsing mempool ops name

[dpdk-dev] [PATCH] eal: copy optarg when parsing mempool ops name

[Andrew Rybchenko]

From: Ivan Malov <ivan.malov@oktetlabs.ru>

The code aimed to pick and remember the value of
mempool ops name from EAL command line arguments does not
copy the string and remembers the pointer provided
by getopt_long() directly. The latter could be clobbered
later and result in reading wrong mbuf pool ops name
by rte_mempool library.

Typically, this flaw could be avoided by using strdup()
to remember the string value of the option.

Fixes: a103a97e7191 ("eal: allow user to override default mempool driver")
Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Cc: stable@dpdk.org

Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 lib/librte_eal/bsdapp/eal/eal.c   | 3 ++-
 lib/librte_eal/linuxapp/eal/eal.c | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index a63f11f31..3ba328ad6 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -380,7 +380,8 @@ eal_parse_args(int argc, char **argv)
 
 		switch (opt) {
 		case OPT_MBUF_POOL_OPS_NAME_NUM:
-			internal_config.user_mbuf_pool_ops_name = optarg;
+			internal_config.user_mbuf_pool_ops_name =
+			    strdup(optarg);
 			break;
 		case 'h':
 			eal_usage(prgname);
diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index e2c0bd649..34d94121a 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -593,7 +593,8 @@ eal_parse_args(int argc, char **argv)
 			break;
 
 		case OPT_MBUF_POOL_OPS_NAME_NUM:
-			internal_config.user_mbuf_pool_ops_name = optarg;
+			internal_config.user_mbuf_pool_ops_name =
+			    strdup(optarg);
 			break;
 
 		default:
-- 
2.14.1

Re: [dpdk-dev] [PATCH] eal: copy optarg when parsing mempool ops name

[santosh]

On Friday 04 May 2018 04:01 PM, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
>
> The code aimed to pick and remember the value of
> mempool ops name from EAL command line arguments does not
> copy the string and remembers the pointer provided
> by getopt_long() directly. The latter could be clobbered
> later and result in reading wrong mbuf pool ops name
> by rte_mempool library.
>
> Typically, this flaw could be avoided by using strdup()
> to remember the string value of the option.
>
> Fixes: a103a97e7191 ("eal: allow user to override default mempool driver")
> Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> Cc: stable@dpdk.org
>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---

Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>

Re: [dpdk-dev] [PATCH] eal: copy optarg when parsing mempool ops name

[Thomas Monjalon]

07/05/2018 07:42, santosh:
> 
> On Friday 04 May 2018 04:01 PM, Andrew Rybchenko wrote:
> > From: Ivan Malov <ivan.malov@oktetlabs.ru>
> >
> > The code aimed to pick and remember the value of
> > mempool ops name from EAL command line arguments does not
> > copy the string and remembers the pointer provided
> > by getopt_long() directly. The latter could be clobbered
> > later and result in reading wrong mbuf pool ops name
> > by rte_mempool library.
> >
> > Typically, this flaw could be avoided by using strdup()
> > to remember the string value of the option.
> >
> > Fixes: a103a97e7191 ("eal: allow user to override default mempool driver")
> > Cc: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> > Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > ---
> 
> Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>

Applied, thanks