From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 9C9A54B4B for ; Fri, 15 Dec 2017 13:04:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Dec 2017 04:04:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,404,1508828400"; d="scan'208";a="3063254" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga006.jf.intel.com with ESMTP; 15 Dec 2017 04:04:07 -0800 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 15 Dec 2017 12:04:07 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by irsmsx112.ger.corp.intel.com ([169.254.1.12]) with mapi id 14.03.0319.002; Fri, 15 Dec 2017 12:04:06 +0000 From: "Nicolau, Radu" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "Yigit, Ferruh" , "pascal.mazon@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] net/tap: renamed netlink functions Thread-Index: AQHTdZlgD7racs0uREixBwmUzkl7A6NETMmAgAABYHA= Date: Fri, 15 Dec 2017 12:04:05 +0000 Message-ID: <763A2F19A5EFF34F8B7F1657C992EE297B303D27@IRSMSX104.ger.corp.intel.com> References: <1513337677-29923-1-git-send-email-radu.nicolau@intel.com> <20171215115816.GA12540@bricha3-MOBL3.ger.corp.intel.com> In-Reply-To: <20171215115816.GA12540@bricha3-MOBL3.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDUwYTNjNmItN2Q3Ny00NzM2LWE0NjAtZjEzZmI5MjBiYTYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImVBMnVZVWZxbU9ySm1adkpVVzM1OWdxOXp3d1wvK2htTGg1czJIZ3dCUENZPSJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/tap: renamed netlink functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2017 12:04:11 -0000 > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, December 15, 2017 11:58 AM > To: Nicolau, Radu > Cc: dev@dpdk.org; Yigit, Ferruh ; > pascal.mazon@6wind.com > Subject: Re: [dpdk-dev] [PATCH] net/tap: renamed netlink functions >=20 > On Fri, Dec 15, 2017 at 11:34:37AM +0000, Radu Nicolau wrote: > > Functions like nl_recev and nl_send name clash functions in the libnl > > library (https://www.infradead.org/~tgr/libnl/). > > All functions declared in tap_netlink.h were decorated with tap_ for > > consistency. > > > > Signed-off-by: Radu Nicolau > > --- >=20 > If these are publicly accessible functions should they not have an "rte_" > prefix? They are all local.