From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id CB114397D for ; Fri, 15 Dec 2017 17:34:31 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Dec 2017 08:34:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,405,1508828400"; d="scan'208";a="12142376" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by FMSMGA003.fm.intel.com with ESMTP; 15 Dec 2017 08:34:29 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by IRSMSX154.ger.corp.intel.com ([169.254.12.83]) with mapi id 14.03.0319.002; Fri, 15 Dec 2017 16:34:28 +0000 From: "Nicolau, Radu" To: Stephen Hemminger CC: "dev@dpdk.org" , "Yigit, Ferruh" , "pascal.mazon@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] net/tap: renamed netlink functions Thread-Index: AQHTdZlgD7racs0uREixBwmUzkl7A6NEleQAgAAC2JA= Date: Fri, 15 Dec 2017 16:34:28 +0000 Message-ID: <763A2F19A5EFF34F8B7F1657C992EE297B303ECB@IRSMSX104.ger.corp.intel.com> References: <1513337677-29923-1-git-send-email-radu.nicolau@intel.com> <20171215081956.29362ae1@xeon-e3> In-Reply-To: <20171215081956.29362ae1@xeon-e3> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjRkM2E2Y2UtOWRiYi00ZTU5LThiNmEtMjU0MjgwOGM4MzY4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InRWRVphQVwvVkZRUG9COVpkNWd4UHhWWHY0bTBzek9zY0JWeU1sdkh1VVBBPSJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/tap: renamed netlink functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2017 16:34:32 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, December 15, 2017 4:20 PM > To: Nicolau, Radu > Cc: dev@dpdk.org; Yigit, Ferruh ; > pascal.mazon@6wind.com > Subject: Re: [dpdk-dev] [PATCH] net/tap: renamed netlink functions >=20 > On Fri, 15 Dec 2017 11:34:37 +0000 > Radu Nicolau wrote: >=20 > > Functions like nl_recev and nl_send name clash functions in the libnl > > library (https://www.infradead.org/~tgr/libnl/). > > All functions declared in tap_netlink.h were decorated with tap_ for > > consistency. > > > > Signed-off-by: Radu Nicolau > > --- >=20 > This make sense to fix, but name clash should only matter if tap PMD and > libnl were statically linked in same application. Wouldn't that be a lice= nse > violation. The tap PMD is statically linked, but libnl is not, still this leads to sym= bol names clashing. Application that needs the functions from libnl (silent= ly) ends up with the ones in tap PMD.