* [dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session
@ 2018-01-23 12:32 Fan Zhang
2018-01-23 15:04 ` Nicolau, Radu
0 siblings, 1 reply; 3+ messages in thread
From: Fan Zhang @ 2018-01-23 12:32 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch
Fixes: 3da37f682173 ("examples/ipsec_secgw: create session mempools for ethdevs")
Some NICs do not have the rte_security context, this patch fixes the segment fault
caused by this.
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
examples/ipsec-secgw/ipsec-secgw.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
index 3a28fcceb..c67f79db9 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -1384,10 +1384,16 @@ cryptodevs_init(void)
max_sess_sz = sess_sz;
}
for (port_id = 0; port_id < rte_eth_dev_count(); port_id++) {
+ void *sec_ctx;
+
if ((enabled_port_mask & (1 << port_id)) == 0)
continue;
- sess_sz = rte_security_session_get_size(
- rte_eth_dev_get_sec_ctx(port_id));
+
+ sec_ctx = rte_eth_dev_get_sec_ctx(port_id);
+ if (sec_ctx == NULL)
+ continue;
+
+ sess_sz = rte_security_session_get_size(sec_ctx);
if (sess_sz > max_sess_sz)
max_sess_sz = sess_sz;
}
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session
2018-01-23 12:32 [dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session Fan Zhang
@ 2018-01-23 15:04 ` Nicolau, Radu
2018-01-23 15:28 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: Nicolau, Radu @ 2018-01-23 15:04 UTC (permalink / raw)
To: Zhang, Roy Fan, dev; +Cc: De Lara Guarch, Pablo
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang
> Sent: Tuesday, January 23, 2018 12:32 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session
>
> Fixes: 3da37f682173 ("examples/ipsec_secgw: create session mempools for
> ethdevs")
>
> Some NICs do not have the rte_security context, this patch fixes the
> segment fault caused by this.
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Radu Nicolau <radu.nicolau@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session
2018-01-23 15:04 ` Nicolau, Radu
@ 2018-01-23 15:28 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2018-01-23 15:28 UTC (permalink / raw)
To: Nicolau, Radu, Zhang, Roy Fan, dev
> -----Original Message-----
> From: Nicolau, Radu
> Sent: Tuesday, January 23, 2018 3:05 PM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang
> > Sent: Tuesday, January 23, 2018 12:32 PM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Subject: [dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session
> >
> > Fixes: 3da37f682173 ("examples/ipsec_secgw: create session mempools
> > for
> > ethdevs")
> >
> > Some NICs do not have the rte_security context, this patch fixes the
> > segment fault caused by this.
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
>
> Acked-by: Radu Nicolau <radu.nicolau@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-23 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-23 12:32 [dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session Fan Zhang
2018-01-23 15:04 ` Nicolau, Radu
2018-01-23 15:28 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).