From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C9E5A00C5; Thu, 27 Oct 2022 17:38:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1588D42BF9; Thu, 27 Oct 2022 17:38:14 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id D7D4341153; Thu, 27 Oct 2022 17:38:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666885093; x=1698421093; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=30e6neqUVPUjfMGz0KYpvhrGqzc9C366R/5MavfCWEk=; b=g7BB/UrwulXs7FyTQNixPcfeRNj/BUcAC+Qt0i1HFQcMme0DXFUx+GYq Ff9HWcPoxXgP3TlHzJOrFCRJKvyJ2Vpb4PZGe9Wmn5ysIyvy4VisjA9sR qWVv6uEkeJbGUphcdshmkALDUiINwqXuVIr75uToA0dbqdw/BUrrgzpDV 7hhCTGLCycGWBd1otWRCZFCubiylAg2e1dsQF0R4gdGeGCj1rvq9coXYT RsJCMag17JA0faYT9lQ2mVl8momzcE/0EM731ixq6EWKzq0RNu+o/ba23 Sz6jlgefIJUp4zqJsMi282wpD3AxjyiPsu+Vz0dBmpAEO51o+r5wvk0zt w==; X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="334889757" X-IronPort-AV: E=Sophos;i="5.95,218,1661842800"; d="scan'208";a="334889757" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 08:38:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="757742323" X-IronPort-AV: E=Sophos;i="5.95,218,1661842800"; d="scan'208";a="757742323" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP; 27 Oct 2022 08:38:11 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 27 Oct 2022 08:38:10 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 27 Oct 2022 08:38:10 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 27 Oct 2022 08:38:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oKcmQDOPyQyJHdW+LT/aBmf7p3Wo70SiTMLQPkMWrPb7TeTjT1g1NIcgP8ylE//UefDemoADkBnP1ApqaZxS8whTPs21PgXhDcfGOg3WPJakl6+kK8cMncS70p5X/ie5Wf5KLjsTVqGYGjHZfdqFxdgTUUIPvvJBiCHJW60J2STTMJQtItcOSJIOhIFHfAmoBAmsRkPg3w8sU1x2GfA265iDHQJEVpIJbTDAgaY/RD2kO1YFClJkpzZzaD2G1QWIEHYcIyYXtncFg8Sop1O2s/CQ+kysNDrCPSBx26BNjvUdrAKEiETtQm2Z2Pt2Nu8eP2RjAOZ5teDoBcTa6kI/tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ENMJl+mg54SpcIfSyRPe+53XyYYxPkvYKGFjKxOr9Jc=; b=E5pFdmlhrWH6KMVZQkPcJoTQm1vqlYc8q0AWBBfYmI4o+r2aDDUjK5Cb4mCBJUSdnCmBPUmAcHbscYI4Z/swjR9Wmq6d4PJd+sx/jIPwGCoRz4EKKUlXZdv1P2kBXqeYaAkNlCbWynPf9y7iPqk//KrkGF9sJsaH+BAqN+sccxo3R0GZN3uIRHOKZKu6QevYNS16C/mmrIAbVtPOLsT3o/klrW/PDV2xx8chbPhC2cdDE/764zTA5uX0/cZnvavXsOYo6Hki8sCMDCI7nCI7nlqGw46XY2jX/KCV374EVNDaaGPVBBr4umHOasRRNXpJjJCQsabFSVEQjahq45qDSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by PH7PR11MB6772.namprd11.prod.outlook.com (2603:10b6:510:1b6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Thu, 27 Oct 2022 15:38:07 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::1965:b85f:cb8d:824a]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::1965:b85f:cb8d:824a%7]) with mapi id 15.20.5769.014; Thu, 27 Oct 2022 15:38:07 +0000 Message-ID: <7642a965-4e9b-d302-7bf8-c333f3afb661@intel.com> Date: Thu, 27 Oct 2022 21:07:57 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] app/testpmd: fix testpmd receive jumbo frame packets Content-Language: en-US To: Jie Wang , CC: , , , , References: <20221025020510.117132-1-jie1x.wang@intel.com> From: "Singh, Aman Deep" In-Reply-To: <20221025020510.117132-1-jie1x.wang@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN3PR01CA0055.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:99::10) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB0062:EE_|PH7PR11MB6772:EE_ X-MS-Office365-Filtering-Correlation-Id: f25247b1-e502-47c7-3534-08dab8313ee5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ba46WvAZuQ9PtbIZ2B+a0xXmk/5nJdP/sx8pzQ8hzGAzO0vwxXpWTjyELy3VSpe8rDG+nwYWqa3qc6BpA4RCiosvBK9AOx6uafxDkC1z1UdetM8IDc+vbzC4OP+FmyIUsGE+8urSzXAmRO97Wfza0bH9YgpXpjzvdNaVjcII97BFrblHgy7JLhZWLRXkXsLISQd5RG39Gq7u5uJOdgVg/hOxXD3VROMICC/3SBhFSOYp5SaLkGAGhnDQIaJmYuJzMqNNxJjexStqdhQYSByXll5yQfRYuTFL5PSCzHIbMnUxbcHWxKWD+hOCbn/5Qab5WPSiA4gIs7CXKEsOAaKTwRKv3Jup3/XvIM0ccR64ADZ1iuDqnpLd8R4rGNJBIgKysGb50VNe4iZ02tyh/JWS/u/3ui55Mg86zg1mqDr2/0lsnypYVi0+KKtlDzOzz5VtvQ0W9G3MN2FrZIx1PZv/zICF3bcluZFzZipeECCt3TmroV/PKoJ+jWk071b15Ej/EE+HlVbDYsXcH+G5ifmp7Pqst2z1jorg/KQ/Idj07EsMD9L0AgTvoLQ7BJK7dUFKrieKFXg2yezBL8BiK+1Tqr4Ijbw8VxxfrOeiyQEsLA8Rn4A2aL0logSV+athiCCF/tsqZM2uSCB2+yoEZU9gG/PuAousF7Xn4Cz0PHQLOtF/tFH2C0TKGT6tblNamUF0KxCdPwUhEIGR9ZUkjwfnTJSCcRc3ah9TC+mtK8Uh2jjdo1cAYLiCMdRva8V9DRCciba4G/xlZ2U3fTbFPkSlFLmpjriBL/H3qcLgM/FjUYE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(39860400002)(376002)(136003)(366004)(396003)(451199015)(82960400001)(86362001)(6506007)(41300700001)(36756003)(26005)(31696002)(6512007)(8676002)(4326008)(53546011)(2616005)(478600001)(66946007)(66556008)(6486002)(450100002)(6666004)(8936002)(316002)(66476007)(5660300002)(2906002)(38100700002)(186003)(31686004)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGRXbVJnaU9COXFBbnNyaGZVa09adjZoTVkySFBQaVhVL1BVQUFidzZqUjRm?= =?utf-8?B?eEpiNWM4WVE0RFZrcW9kQVp2MnNSU0VaOFVmYzlJcG81RTRLRFBRVlQ2SVJQ?= =?utf-8?B?a2M0RWJidklQNmJiME5FMFZkMjdQa2FQaHd3OFhiTXRWVUtTN1VYK2poSkJu?= =?utf-8?B?QTZ1SVdRcFdyUGdsK25vL1phYzk3aHY4cHdtRldoYXczc2IyRUQ5SWNRQWJs?= =?utf-8?B?Sm1tQzBvSWdZcW5ySEs2a0t4Q0xjUnNoQTNzNi9EYXNZcXF5QThnVHRxZCta?= =?utf-8?B?dnlETE54T09FT1U5K1RTaXBwbk1VaDhDN2ptMlFRSGN0THcrMUExNUc3WWV3?= =?utf-8?B?eldDYzQvU3J1MU9ZMHpxNTYxdHhBMXFXQjFiS21yNjhhNVZ3cUFpNlhxNkda?= =?utf-8?B?WFhTOUZXdEdmNVVQcjZqcFhTS3dYTGo1UElPY2pVVVJVenlVYTN2Qk9DcWoy?= =?utf-8?B?aWNXblFHTUdhL2FOQUxCTFNyRit6STdaVXYvbHovL1o0WlBCOWcyQm9TTVkw?= =?utf-8?B?VlhLQUJDS21pM2xBam5QRnh3ZUx6Q0x3T3p2TXlrTmxpRHM3TURFdWRFUGhI?= =?utf-8?B?NDR1S0hwUXNnK0lNdWZaV0VDclQ1dGpWWjFnMkxKZ3g1MThJa21VdnJlbWJr?= =?utf-8?B?TzBweGFoYkN2bnd0TFBpSlE2NHd0MW40em42MVpqclR5c3JINlRCc0lOL3A2?= =?utf-8?B?bDcycm96MDU5dUlIVFBwd0RvTTc0Z0oyNU5Dei9INkQ0TlYreGcvaExETU5y?= =?utf-8?B?LzZOZ1RrN2JpT2c3aklJN29hYzE2TVdJNUQ1NFBROHpZYlRKU0hXNHBiaDNr?= =?utf-8?B?RUhROEo1eFNPazVpU1ZsdDJzeXNNMFQzZDRVcklnL0lYMG5GSjc1dkwxck5R?= =?utf-8?B?SkZ6a2pPQ2FORHhheGpUczE5WCtRQlYyTkRYWWI2WXhVNU1YUkcxelVzVUNX?= =?utf-8?B?RmgzM0dkSmg0S3FuVVQralRMNFVrcUdJcFlPbGVVcUhqQUtZdGp2eTdqenEr?= =?utf-8?B?VlUwZlFSRGU1RWZ3QjF0OUFocE5RNEZOVDM0UDJwKytlMzBlTXlIdzJkSnJZ?= =?utf-8?B?OGEycnhCRFYzQUdXL3V4cnpZSjN3bUZ3YnJEMUhsRFRNOFV4dGxoYVpwTm9W?= =?utf-8?B?R1drbFM0SmVZZ1lWWVFCQzA0Q0laMklQa1l5NmdOS1dNUnRtZlZ6OEZPRHVZ?= =?utf-8?B?NXVDUFZuMnJ4SXhGTGYxak8rVnVJaGZtYWtVL0Z1bVJ1ZEpwNzZNSzZMVHJ0?= =?utf-8?B?WjV4dFJaVHF3NkdQUUtUeUxmanVUMEVsKzhlbzlhUEhSQlNtVW9NTFBWNVMz?= =?utf-8?B?YzZjMi9XNDZFZFVtVDBLSUQwY0pPTGN1V0d2OUdxbXY5aWQyVHN6UGUxa0w1?= =?utf-8?B?Ynd2TktheU0xSW5ETXgySU9MSGdzMFMxaWVTVGthOGNIcmFXZFJRTnVPN0Zu?= =?utf-8?B?VXdibTg3NlNpS01od3RFZ0Y0NElqVjhTanc2Sm81ZWZlLzQwbmgxS3ZpNGMz?= =?utf-8?B?Q0w2SDJpWU1TRU1PT0JaYmhaS0ZwSDJoTnRCN0R0MHhJOVpyUDZGZlpUeUxx?= =?utf-8?B?M2lUMU1YU0JUY2tCdms4Mkt2cWxkeVBNZEJIb01PS0JqOWZwOVl3a0UxNFov?= =?utf-8?B?akZoejJrTWd6S1R0MjBZSXpZUXpCQjhmRzdWR3grRWFka1dRa2NFZTdEUFZa?= =?utf-8?B?WlRuTVF4Z3hENEhjODQvVWJPRVZzOE8rOER0d2daNU82bXZtRTFrSGYzdjc0?= =?utf-8?B?azVNc2xUQ0VUd2JpM28vZDF3MTlxeDYxblJuTnNQTlR2ekt4OTdxSFRpeG5q?= =?utf-8?B?T1pqRWkyaENVUk1nR3Q2aklEQU5iMmxhR0tyYzV2eGdoOG9hTWF5ZG45SEY0?= =?utf-8?B?aU42aExuSVRseE1pN1Ercm1pU2JpcW9GRjBxYi9xSU1lWU1IMlljdGdBRlpp?= =?utf-8?B?Yk50WDVzQTlhQ2c3T2o3WXFGYzB1b29ETGpvLzJQMk8rQmtNdmtPVWxEdEZl?= =?utf-8?B?dXIyTWhPSE9wMWR4eVRzQ1NORW01aUhqaDladmc5WmxPNDgyOWthOVlyNjA0?= =?utf-8?B?RG9STkJNSTJMMnJwcE1wRlFuQXUybmVBS1BVbzIraUd6OEtmU0h0V3NYdlZL?= =?utf-8?B?TnlmenQ3eUFNNW8zOGhKUzllOS9Sb1dXNnBhbUJSQWxHdVllNGovekNySG56?= =?utf-8?B?WWc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: f25247b1-e502-47c7-3534-08dab8313ee5 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 15:38:07.6025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mFQM8f33RFEp8r7TAFlMGDJ02wsYP8tt3GSwsK8E0O7bJ9kbNBum/gKHiVb2CraSxiSaHZ3kjHlgkPi210lK+w9bP9iZOJnp8ze1RgSxE6Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6772 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Jie, Thanks for the patch. On 10/25/2022 7:35 AM, Jie Wang wrote: > For NIC I40E_10G-10G_BASE_T_X722, when testpmd is configured with > link speed, it cannot receive jumbo frame packets. Why only the jumbo frame are effected and not other pkts. > > Because it has changed the link status of the ports if it was > configured with link speed. If we configure to same link speed, will it still have issue ? > > When exiting testpmd that it automatically stops packet forwarding > and stops all the ports. But it doesn't update the link status of the > ports. If stop the ports first that it will update the link status. > > This patch fix the error that testpmd will update the link status of > the ports when it exits. > > Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and SIGTERM") > Fixes: 284c908cc588 ("app/testpmd: request device removal interrupt") > Cc: stable@dpdk.org > > Signed-off-by: Jie Wang > --- > app/test-pmd/testpmd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 97adafacd0..c348a3f328 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3548,7 +3548,7 @@ pmd_test_exit(void) > } > #endif > if (ports != NULL) { > - no_link_check = 1; > + no_link_check = 0; > RTE_ETH_FOREACH_DEV(pt_id) { > printf("\nStopping port %d...\n", pt_id); > fflush(stdout); > @@ -3675,7 +3675,7 @@ rmv_port_callback(void *arg) > need_to_start = 1; > stop_packet_forwarding(); > } > - no_link_check = 1; > + no_link_check = 0; Well, here we are undoing a previous change done for 284c908cc588 Won't that issue come back. > stop_port(port_id); > no_link_check = org_no_link_check; >