From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0041.outbound.protection.outlook.com [104.47.37.41]) by dpdk.org (Postfix) with ESMTP id 4673C968 for ; Tue, 30 Aug 2016 06:59:59 +0200 (CEST) Received: from BY2PR03CA065.namprd03.prod.outlook.com (10.141.249.38) by CY4PR03MB2440.namprd03.prod.outlook.com (10.168.163.142) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9; Tue, 30 Aug 2016 04:59:56 +0000 Received: from BL2FFO11FD047.protection.gbl (2a01:111:f400:7c09::101) by BY2PR03CA065.outlook.office365.com (2a01:111:e400:2c5d::38) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9 via Frontend Transport; Tue, 30 Aug 2016 04:59:56 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD047.mail.protection.outlook.com (10.173.161.209) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.587.6 via Frontend Transport; Tue, 30 Aug 2016 04:59:57 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u7U4xqtJ019536; Mon, 29 Aug 2016 21:59:53 -0700 To: Ferruh Yigit , References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-23-git-send-email-shreyansh.jain@nxp.com> <57C467A1.8070606@intel.com> CC: , , , From: Shreyansh Jain Message-ID: <76483514-d12e-2d86-b928-d5276d54e56f@nxp.com> Date: Tue, 30 Aug 2016 10:29:53 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <57C467A1.8070606@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131170067975043002; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(24454002)(189002)(199003)(377454003)(2906002)(93886004)(47776003)(4326007)(65806001)(305945005)(50986999)(50466002)(36756003)(65956001)(33646002)(105606002)(64126003)(106466001)(586003)(8676002)(65826007)(23746002)(81156014)(69596002)(81166006)(7846002)(31686004)(54356999)(76176999)(19580405001)(19580395003)(83506001)(626004)(8936002)(68736007)(5660300001)(11100500001)(104016004)(2950100001)(4001350100001)(77096005)(189998001)(97736004)(86362001)(230700001)(8666005)(31696002)(5001770100001)(92566002)(87936001)(85426001)(356003)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2440; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD047; 1:xZ9PjwnXvrfa4t3JcuPAO2qbiwY2nKFrkVe+FlinmutX7qXtIeCmB0fO+NkYre2xUR9eYnh94tyc2/SoVbPWGzMhtCGio/e237knhAujoF9iwJAHQd0gvwWjtwE2dRSLEnMTFTKV7bvP3p3XdpiMCCyqEOyeBPHnCEYenb13YWJdeKCanqlfc+P62KOW19DMWBlJDFi1lzTxwNtAO212d72Qr6AMmjijYUBtjBkd7gWYjTdi2uWU6Y0h0zI4NGTlXOlbpO4ax6+/CvoUJEqeqyYIfsL8I/R6cW4DnEfFHHg3r7BcEz08ahky3nhgXg8ALzciSMqR7HHPFSQ9Bbj5QAJzLIUm57FNyEA7HV9R724fBzj4QaDEEkRnIV+0BghQ7QcBfmr6cluq6w7Af4WheusWdxJb35p5dDFzddQOH9gaG5lTR23djwHSb4mdQXxRatQnR7A6YHSX6SoWjYz94XAmrcpUbSJm75siMVrvkZhTCkgDeT5s0HkN0BcFbmZatsF7k1ZRIjGENtmX/6k1Sjf/7t2XH94g1LKaKQc0+rLgHF0n5/GSDq2uFjRFZDcyydA6+3KYB3vBFzoKBRLbOGYzOUAqSjdNiiuEmIKq+818dH+10JwGZs4PZ/Fp++JXqwHghxU+/dgMEvYbkiso7A== X-MS-Office365-Filtering-Correlation-Id: 5c94011f-ddef-414b-f7ba-08d3d0927d47 X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2440; 2:A3Z+7/C9W8AN+5cflpiJaDzEyYiFwOzmOyS2f/wzU3XZJipPgZSl8YK+EJsEu3Us2sGAS2Fx08Q2n9BtbQWtnwly9pZhgRz4kF7GGyRFr7muIkqG7YZAIN7ZhUi7eSovwq67VXK35uBaBeR4vLwS0JLv69K88lts+lhYtSoYo9BzaZzUwmhZ+1Sc98tgzwA9; 3:G06MJWzoCtlTa5mI9tSVegd+KjBiu4Pc4QOCXBvmaeRfr3Zj8i87DDdKGF/Ttp8ttscOZNXTqQFdFVhKuJTzdSNR1hAfPsHnl9BKGHJ+0TWV/Ypbe9Jwu3lrTUOWKuCtt6VK04tL7WQ6eVP26X6hnNDSWjD+nnR5UF9r/FtON6Tu5z98kd7BmzPfqqECgQ/aQpwgeLESF8PATgNvx1iUoR2C1/zNqDroq1HFwZ2+Rh8= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR03MB2440; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2440; 25:7ux3BH5Wl6EqgO3rOGopRc/IE3lZDkBg4fAKuC8GVezueOs/ua7rfWU4d2wF63y/Kq9nHxsbSWBp925RIXPLa+kaamhqUbdIbjDW8JQaycY+Y+DtQexwA9CGzsAeRlyE6hcGh5pW0OWfqOWaksxena2IegFXhV7H68vmfOYmR51Je4hWThsbG1/epn6B5bWKPiDyxX7t0f8px3YtP9CyiMmrERdZO7KurhOzX2c2X+eMZw3IPqFS+B1txyQylRdqdxKycUd3EDqvXgqnBNeXJp4opK2plULTtprmyn/1LupR6FfgM38d7wS/1myRntQK50HaIM5Pmj3/ps4TVwi2HYi1KJyV8w6aj+AcmreigP84tHFvjelKJpcNUgDixKz43D5/Kn+bR2gUDfeJ/CCqOHUdZTgAae8dSJPIuzuPbeDkjbnP6DK+Q1UDFBN6WNtg+uoPsRbCvUtqWRxmUXz4A5fYu4l6YRQyeBC5WexW9Hj9Dc2TYPXTHX8Vo14xVkdglVjtY6MiZGNZFnz1wguWpZfqfFnt4TxKG3OXpJ8p+SWufgU0QV3khrbxtRNX7C/MhdlLpJW/m3gBL5OImanDRQAvQHt9ptb8+e9Nt+u8zsZNGcdnxfH6y9c8A6wOtyv+wnyazMB+s26YekbJdePtRC69m1OOYbwINH6Bkw5YP7fl/2fSsm9lTqzAhuaVpHcsZFtPuLR9KILI4AsdO8+SKw==; 31:E5M4Z839aGv3MJjHUivRLA2EI5AeVQzCSzHe4yIwF9HRzFIHrJciSC3ptHZB4efxZkp5SSdsxo5NJNsoJ5EH65L3VVBUIy7lAu1eosRb5grR8YiZaVY6IW+wRTPRCNc8MIA/z1ALm6QT9ihQuqh8J+7QKifzndfxu0Gf0v14uwQTEpWlg3WuSxiN1Fw2bGVRQXyjMawB0wt1AlzQi3Yl7MJxcrFJsWDoInfkXPMWXno= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(13018025)(8121501046)(5005006)(3002001)(10201501046)(6055026); SRVR:CY4PR03MB2440; BCL:0; PCL:0; RULEID:(400006); SRVR:CY4PR03MB2440; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2440; 4:VxASehWKMLcazTC3ugssRwRNP8neq2svOofPzgsaBtfMuqjp06u7PMjolHW5h78Vd0U6WSOM5DZ2GIejmrXOOLmu6Ypc56l7a7f4dsksWxDZfeBKoc4w5uS/DPPVin8KAaVP92dSPrB3yhFGRLoJtVMfIAtHDL+ir++AdcTNmYcCh00x4GeDeUQFga/pzUcIJ6OoRHS1PHAIyDlHNl6bKveT1FgZ2sgbVtZFxxHR7jLVD8eDhnUerkbXKt4oIaYbZnxEmvpx+FuJDeYMvMPU2IIxK3dRXWHWO310U00k4VWI2y4QZq6ePtuqhr91phmISW6FvdEn1dTbVWj3AZjo2wFI9BK0QgAJZEBjcRikoZivHYChEewC1N4PFE9TKjouqv9MF9svc8H5G9+/RxjgBcBjDJ/4AJjBVpvJIflBE4SeAbcYvZ8FjheJEL/G9hVWdw8b/CFHm81MZIDyMFnmQPnemTFAEc4TbdkyZgCw6vGt0JFgwbTu70CTGj1/6CdL0bXaXYhxNjrS9sq3UFTGh0adkSeFKBO5EKtuNzYmqSI= X-Forefront-PRVS: 0050CEFE70 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY4PR03MB2440; 23:S2+OAhsMpsYHlVBeytoYAWNoIjvHaTAFydmd6?= =?Windows-1252?Q?fNj8ycoDQqp6ew2+EkjUymPz4hrAUw4bL5+KggDpsLlQBfhc0eyHBrAw?= =?Windows-1252?Q?Dl9UzGGVu+Va8ZMKAMq5udgdmCy9bNeWTtcWERed9e9+2aohi/AcTVO2?= =?Windows-1252?Q?RmyPK6FFqflw6r3nkIgKnSRqAXFaWuSejw4sqOrBTzlAY4P+ZDLBO8B1?= =?Windows-1252?Q?NCckD5nsJy39G9TWDL8SMV+f+e+bgd3pq0qwjehlXeAsNk+5GGyZcZMs?= =?Windows-1252?Q?MF/b5IVPcm8lG3hw/JW2MrkVOy02X9lI4s2LPVon7tBWWXmF0so20P+G?= =?Windows-1252?Q?qisoK4q9SyXVqQy2pfRXM+xVIeTpjVe+h6js/NIKA2w4YWa81FrhRbJQ?= =?Windows-1252?Q?6MTF7kMtSHq/aTPCiG7yRp33FdYOokHn4bc/PKgvTk+N1QyV4njfayoe?= =?Windows-1252?Q?1uCJoV7N5GprUwEja6opMGVG58A49joUwZDimsTNdjjtlOIYOgYA2wOC?= =?Windows-1252?Q?YY6SdAKuibPGbohZomeSp4TZSCmPBmfbUcCX+IKsGzZ7gSIYd5T1ALtb?= =?Windows-1252?Q?WUUAJVVm3LY/ezP81MnTX183c34tIh9LB1O7Fee+vXijOCF738cPHjp3?= =?Windows-1252?Q?WPbNSQV93bv4diTcn2V807Sf2VGSoaZKVOQbWqHDYw/puhXEwGdxr2z1?= =?Windows-1252?Q?jAtjSeARBOPkSnj04lI6glvez7QLnlFoNANuPupAL0QXfJ8qzvoWAlso?= =?Windows-1252?Q?uK5IL2HOGQiWxGzms3XxEUge0IIKaVEP+PJ+aOoi8IFxI0oYxpFqRDr6?= =?Windows-1252?Q?UzUxtz3gcWpjym0mmxzMA+S8BkXZcoXueUhAINf1LZT1VsRI+orAOQ6b?= =?Windows-1252?Q?v+CBitYKuXamFdTZ9K3QtS+5yTz9tBLkGuJZKXvGgA6e7U6NkQ5dnRbU?= =?Windows-1252?Q?MU5UHPDiMLVubjX5p28KaW9m+6pPyBE84MSM04PwFPQVo1vqIa/e7tHj?= =?Windows-1252?Q?KDGgkAHe0rOrp9nvhJFVAPGlh1WicpHK3wmoCmru1QX3LVwyXJAoaJvN?= =?Windows-1252?Q?KgSaU/ulFCARDNQUE7BZOrl4ROuyDl/ejXP5hMH5tJZF0Kb3Ly4FopdD?= =?Windows-1252?Q?y7L/8xnAJoS4Dg5ZH/JJ0ROXtraoagaG84c8Z00O+jh+xabSbYWa5kqw?= =?Windows-1252?Q?4xUtt+D2Aih/E6Ae7JMrXwzvghl6SduQeQB2UYPJ8gFVWGIbQTc9YDEP?= =?Windows-1252?Q?AKrTWKQLl5CwEKeBRkE64uv7/JzosznnMR6xiAVOO+ZQxZ04Bz1q36Tr?= =?Windows-1252?Q?O7wyDWiyscLyQl918a1rcnWUfs1Un06lW41wwOGqgQBQAZF3sdtsAI8j?= =?Windows-1252?Q?eLVR7xMDfT7PfOGTvGLpTaHubo7lTq5EdTy7HLcT793HN2mvRsbIq/6I?= =?Windows-1252?Q?E6QBmrppuylvv+7lf7RbrCju/ZgtJV8GyahWpL0jgkYa7v8QumjPN2bi?= =?Windows-1252?Q?BNvFMdYdYYeaj7nko9InyUKPYYP2q7OkpbK8DhyPPVF6fERK7STvL6ob?= =?Windows-1252?Q?oXejc6N+Pb91cE=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2440; 6:4itSgyHb2UZCzAdf9gYtpPH3NyGc3LolbqOjL2i2zC0d9N0fVdxSVyTq+a60GlgX3BGTIWqaAawOS4WJkqTrF0/j7cMUNcil8ZjkU88MCqrSKTmTmcKLeqhXQJpzPPF+Prt20SRef06t/chs2Ogc4i45Ggbcpitxcxkm0kXqbSrymUesFaIUHfj10pwNBh3i+/236QyFN34afVhXdJfTNIuG7f1AKejH3PkE1BZhzBfTYGqHnWlfLU29R5rYwa14wLsbwZjTVB+MPQxhC4DLkMWezIfGYM9UNF4egED8co0=; 5:hSpOaVOZoL2LkJtDQcWYiS+R13NrATM54jD7RpXd5z0MlgVR3JXLUg8NDXUDkS1G5Gro6cCRNoG3VpWP+kmMP50tGdCyQeh/7cyS0Q5gMIC0OqpY6apNVbSgVdy4wCyZhzcFu1GUeocscQe3gTIQU5MEOx/Bt0SJr0Hm2v3jNRA=; 24:PRbynyAk+NALEkua+eMypykJw6RYSNMbBbAESZwSGvGUz9LUbTfT/NA5qPmSf2/EeSLSkLsG0/ElEgIGuUU87oNlcdJDyLo3ZNRYBuQtTY0=; 7:q4tpClhELF5q1Rmi1MRw18ePlBkx7yqcTND5I1UYmQ9UeOnt+x96ORsJXJhKbFYW0icnGvN4a25KPXm4GxfEjXce9ONML3cgvQpNh7UzARqb18VTSlqzjx702XA2vJbzOTUYTf+GVEoCa0RhlTmjRb40MKwYCloPPH0KUe5gKtFsNkv110dhBjLvG0cgunNaKhWs2o5zt7FhzEVhsSSQ6zVrnuUe9xMdqP9VVMRWyouEZdSbpiMAuzUR8U9QsrXA SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2016 04:59:57.2235 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2440 Subject: Re: [dpdk-dev] [PATCH v8 22/25] eal/pci: inherit rte_driver by rte_pci_driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2016 04:59:59 -0000 On Monday 29 August 2016 10:19 PM, Ferruh Yigit wrote: > On 8/26/2016 2:57 PM, Shreyansh Jain wrote: >> Remove the 'name' member from rte_pci_driver and move to generic rte_driver. >> >> Most of the PMD drivers were initially using DRIVER_REGISTER_PCI(..) >> as well as assigning a name to eth_driver.pci_drv.name member. >> In this patch, only the original DRIVER_REGISTER_PCI(..) name has been >> populated into the rte_driver.name member - assignments through eth_driver >> has been removed. >> >> Signed-off-by: Jan Viktorin >> Signed-off-by: Shreyansh Jain >> --- >> app/test/test_pci.c | 10 +++++++--- >> app/test/virtual_pmd.c | 2 +- >> drivers/crypto/qat/qat_qp.c | 2 +- >> drivers/net/bnx2x/bnx2x_ethdev.c | 2 -- > > bnx2x_rxtx.c also needs to be updated: > > CC bnx2x_rxtx.o > ..../drivers/net/bnx2x/bnx2x_rxtx.c:22:25: error: no member named 'name' > in 'struct rte_pci_driver' > dev->driver->pci_drv.name, ring_name, > dev->data->port_id, queue_id); > > .... > > > Also szedata2 driver seems missed: > > CC rte_eth_szedata2.o > ..../drivers/net/szedata2/rte_eth_szedata2.c:1575:4: error: field > designator 'name' does not refer to any field in type 'struct > rte_pci_driver' > .name = RTE_SZEDATA2_PCI_DRIVER_NAME, > ^ > > > Ok - I will fix this. It seems I really need a better way to test before sending out the patches. - Shreyansh