From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A237A09FF; Tue, 5 Jan 2021 23:01:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB0DD160819; Tue, 5 Jan 2021 23:01:09 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 7368B160817; Tue, 5 Jan 2021 23:01:08 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0BA005C0194; Tue, 5 Jan 2021 17:01:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 05 Jan 2021 17:01:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= axdHnIirLjoJJTlZqYT6TckGZWSI9oC5ayi81Q8JbAI=; b=cmvNQ/V8WfC+8lF1 hRfCpcsww+Tg2NS4Y1OdsDUX5XoahddHjJyY6ETrcxOO4JJL0vhqWcqIRBazOAQa GQdLJa/bz/w6KP5tqZEzrAa0PeRhfVxiUU3zxdqcPc2c/7Jc5OqRylppvjlYk3xG 1fXgvIhVJeTCj+jPTcf05kidQcVC4MvREfLoW1YeY3yUwkBEMrW0uHo/LUcYu1KL 5wHt4R9ezyA+KyUtDblO26eW9LSRbpzjFgqQ7gXDTuRwUrqPmStEN7U+uV397UdU BkbejkEs+qrAKpXfVveKoPhIP1lCJLsa5g6EogyF461wkjxJ37qrybn4rv8Xxj+q FAlKtA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=axdHnIirLjoJJTlZqYT6TckGZWSI9oC5ayi81Q8Jb AI=; b=AcxbNhyuh8QerBh+MjH7HQsfcbtj4vopeWY1o3MUeIeFwT9/Q8DzYAzmU Y73hv9pkUWPjXB1OkW/RGKkJh9+1T4zV8Ql95wNFj3dignH+BNyMjf4EL8qrPhLr U2LLrTmpu6gMzi70Zp7PNRWRno/PAvf8ZHGevANUhXivJybYmndu1nIE3Gee5F1H 9SR8Grtu5Ia5tE8MOL8UTUXIsm9M7jMiCoyX714Rk1EiQLdwnk1AmuG/my4/Ydg3 ud3/uwBUZATo9w/wGBAmyU0olDJTPLGxJwV3niKdeuhj+0KDG0eOagl8XOTvKKrx idW2oJ4+cwhSkL0/HCBaRtiJXaqDg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdefjedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E6BFB24005A; Tue, 5 Jan 2021 17:01:05 -0500 (EST) From: Thomas Monjalon To: Tal Shnaiderman Cc: dev@dpdk.org, stable@dpdk.org, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, odia@nvidia.com, stable@dpdk.org Date: Tue, 05 Jan 2021 23:01:04 +0100 Message-ID: <76662169.ZHu4aoMZnK@thomas> In-Reply-To: <20201213141604.12560-1-talshn@nvidia.com> References: <20201213141604.12560-1-talshn@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] pci/windows: do not fail on missing NUMA node for PCIe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/12/2020 15:16, Tal Shnaiderman: > On older processors, NUMA isn't bound to PCIe locality. > those cases return ERROR_NOT_FOUND in response to the > SetupDiGetDevicePropertyW call with DEVPKEY_Device_Numa_Node > attribute. > > This error fails the probe process for the PCIe device. > this commit will ignore such failure and will set the > numa_node to 0. > > Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers") > Cc: stable@dpdk.org > > Reported-by: Odi Assli > Signed-off-by: Tal Shnaiderman > --- > --- a/drivers/bus/pci/windows/pci.c > +++ b/drivers/bus/pci/windows/pci.c > @@ -234,6 +234,15 @@ get_device_resource_info(HDEVINFO dev_info, > &DEVPKEY_Device_Numa_Node, &property_type, > (BYTE *)&numa_node, sizeof(numa_node), NULL, 0); > if (!res) { > + DWORD error = GetLastError(); > + if (error == ERROR_NOT_FOUND) { > + /* On older CPUs, NUMA isn't bound to PCIe locality > + * We do not want to fail the probing process > + * Setting 0 for numa_node and returnng ERROR_SUCCESS. > + */ The last 2 lines of comment are rephrasing the 2 lines of code below, so it can be removed. > + dev->device.numa_node = 0; > + return ERROR_SUCCESS; > + } Applied with smaller comment, thanks.