From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <patrick@patrickmacarthur.net>
Received: from plateau.patrickmacarthur.net (plateau.patrickmacarthur.net
 [174.138.60.243]) by dpdk.org (Postfix) with ESMTP id 09E5F1B62A
 for <dev@dpdk.org>; Fri, 13 Oct 2017 05:21:17 +0200 (CEST)
Received: from [132.177.123.220] (vpn220.iol.unh.edu [132.177.123.220])
 by plateau.patrickmacarthur.net (Postfix) with ESMTPSA id A8DA2BE592;
 Fri, 13 Oct 2017 03:21:09 +0000 (UTC)
Authentication-Results: plateau.patrickmacarthur.net;
 dmarc=none header.from=patrickmacarthur.net
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=patrickmacarthur.net; s=mail; t=1507864870;
 bh=z4K8pu8gVmGQ7/dgOIsBwpPsTaxWjOsLPmDm85IZRO4=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=Y6inYuotstE3K/rnJBIX2hZslHxCMNM1Tkv8JHnw1deZQe3WwPctWBK46IrBLOwJ/
 V2+piVdD6CPqmh1OXbhlq6GUZkpgClMt+n6QgWaAx+l8iLFW2FCzLNanRkAw99fJ8q
 +SrxK8a3WTDyOOQvWypbW1xH0+YiEbUFNfq7v70Q=
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, mark.b.kavanagh@intel.com, stephen@networkplumber.org,
 markus.theil@tu-ilmenau.de, Patrick MacArthur <pmacarth@iol.unh.edu>,
 Bob Noseworthy <ren@iol.unh.edu>, "O'Driscoll, Tim" <tim.odriscoll@intel.com>
References: <20171013024644.51248-1-ferruh.yigit@intel.com>
From: Patrick MacArthur <patrick@patrickmacarthur.net>
Message-ID: <7673fa98-986e-abde-a68c-01809d01caec@patrickmacarthur.net>
Date: Thu, 12 Oct 2017 23:21:08 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171013024644.51248-1-ferruh.yigit@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
 DKIM_VALID,DKIM_VALID_AU,URIBL_BLOCKED autolearn=ham autolearn_force=no
 version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 plateau.patrickmacarthur.net
Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix unknown symbols
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Oct 2017 03:21:17 -0000

On 10/12/2017 10:46 PM, Ferruh Yigit wrote:
> This patch partially reverts the commit d196343a258e and adds some
> functions from Markus' previous version of the patch [1].
> 
> igb_uio uses pci_msi_unmask_irq() and pci_msi_mask_irq() kernel APIs
> when kernel version is >= 3.19 because these APIs are implemented in
> this Linux kernel version.
> 
> But these APIs only exported beginning from Linux kernel 4.5, so before
> this Linux kernel version igb_uio kernel module is not usable,
> and giving following warnings:
> "igb_uio: Unknown symbol pci_msi_unmask_irq"
> "igb_uio: Unknown symbol pci_msi_mask_irq"
> 
> The support for these APIs increased to Linux kernel >= 4.5
> 
> For older version of Linux kernel unmask_msi_irq() and mask_msi_irq()
> are used but these functions are not exported at all.
> Instead of these functions switched back to previous implementation in
> igb_uio for MSI-X, and for MSI used igbuio_msi_mask_irq() from [1].
> 
> Fixes: d196343a258e ("igb_uio: use kernel functions for masking MSI-X")
> Cc: markus.theil@tu-ilmenau.de
> 
> [1]
> http://dpdk.org/dev/patchwork/patch/28144/
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

I can confirm that with this patch applied I am able to build and load 
the igb_uio module on CentOS 7.4. I have not tested the actual MSI-X 
interrupt mask/unmask functionality.