From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 3BB60592A for <dev@dpdk.org>; Fri, 16 Sep 2016 11:58:11 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id 1so31476204wmz.1 for <dev@dpdk.org>; Fri, 16 Sep 2016 02:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=zkN+0XkdE5mqTYiA1bqpv05Qm2ifkpJRe0PTGqHDJN0=; b=iOm8ajNFmXqVV4cC9QOIw+gXYe9RIaliealgixZE/lcz0jtQqVsl/S6snSkVR7Vfm0 ro1/85QiMA+Dui70lKtSK7k6pvqjgMaDegkvCZYadiSpseSnrj4HWqg1dXRFj3wAn0w8 pcuGJ0Op1O9Vs0LnHFUHpLCdDpD5PyKt4UKKTS85DCSgn2/J78IA7J/ePPZ1QrIiuuVJ JdRQV2FmXyGvVg3QBQR2y1Lw7yCNb5M7WBtn5jUnnGiUZgIhnpWhrqfFX5/4fKj1au39 FvCrTXc+Qn0+q1TE+RYMB/oVYHx7AcqR9Q8EPTeBRtCn36q0zZOlcJhSG5OyiSVRKVQc g3iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=zkN+0XkdE5mqTYiA1bqpv05Qm2ifkpJRe0PTGqHDJN0=; b=h4y2wa+5ldmDQroMRrQbRwdhC9QgdbI44D9EUz4Z/9MTvShRfeRJbBGQbUYpboIu4J VPfwoxaa6gOT5mu2OTymWEULOBbtvsIX8W4cVJTJVpWnq/hjZJCc6CY49k+LzmwlOhyH BA7LxOkPxJ8lFdHt6TgOA6qJQ5UmdNz792AR9Mkb+39LlqgtlH7DdSCjfdL6bo+qkyVa 9AROYzhz/pJEaFXGqZWhkfr3O6RFXu7iK83ANVJNS9n7/jcX8huZ+8BsVv9zTzwhI+KY wS4ASaH+m4Tbo+AX/a2fsizkQpVWCQJ+0v9uvoHDYJiFELeDMKvucUEMBiR9SrriDO92 zQJw== X-Gm-Message-State: AE9vXwPwujunL9M6QcId7MJXChDg0Tqhu+tb2RR9i30dHA3Y6ysZvA9wBP1fz470NUZnYJX4 X-Received: by 10.194.61.243 with SMTP id t19mr13322952wjr.60.1474019891015; Fri, 16 Sep 2016 02:58:11 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id bj8sm7538217wjc.49.2016.09.16.02.58.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Sep 2016 02:58:10 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com> Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com> Date: Fri, 16 Sep 2016 11:58:09 +0200 Message-ID: <7677934.dvmb0F7Vh7@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <B27915DBBA3421428155699D51E4CFE2025CE4E8@IRSMSX103.ger.corp.intel.com> References: <1472077494-164532-1-git-send-email-pablo.de.lara.guarch@intel.com> <B27915DBBA3421428155699D51E4CFE2025CE4E8@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] drivers: make driver names consistent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 16 Sep 2016 09:58:11 -0000 2016-08-24 22:37, Mcnamara, John: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > > > > ... > > > > - $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'eth_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- --port-topology=chained > > + $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'net_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- --port-topology=chained > > > I know that this is an existing issue but there shouldn't be a space in > "/path/to/ file". Perhaps you could fix that (in a number of places) as part > of this patch. You could probably leave out the "/path/to/" part altogether as > it may be clearer, see below. > > Also, could you wrap the long code lines in the sections that you change at > 80 chars using "\" to keep them on the page in the PDF docs, like: > > $RTE_TARGET/app/testpmd -c '0xf' -n 4 \ > --vdev 'net_pcap0,rx_pcap=/path/to/file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' \ > -- --port-topology=chained > > Or without the path part: > > $RTE_TARGET/app/testpmd -c '0xf' -n 4 \ > --vdev 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' \ > -- --port-topology=chained Applied with above comments fixed and release notes updated, thanks.