From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0515EA0471 for ; Tue, 13 Aug 2019 08:46:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 026A01B94A; Tue, 13 Aug 2019 08:46:35 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6A208326D for ; Mon, 12 Aug 2019 12:43:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 03:43:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,377,1559545200"; d="scan'208";a="166672875" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga007.jf.intel.com with ESMTP; 12 Aug 2019 03:42:58 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.55]) by IRSMSX151.ger.corp.intel.com ([169.254.4.214]) with mapi id 14.03.0439.000; Mon, 12 Aug 2019 11:42:57 +0100 From: "Kinsella, Ray" To: Thomas Monjalon , David Marchand CC: dev , "Burakov, Anatoly" , "Richardson, Bruce" , "Traynor, Kevin" , Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal Thread-Index: AQHVS5uVpGMbKJqVyEaprL4GOc+xJqbslokAgAACHICACsUW0A== Date: Mon, 12 Aug 2019 10:42:57 +0000 Message-ID: <767EFADFF809234DB6CAABD6D2F93847E06507C1@IRSMSX107.ger.corp.intel.com> References: <1564752563-11850-1-git-send-email-david.marchand@redhat.com> <1667146.ajMsIp94DY@xps> <3963110.nb0tCvxbkm@xps> In-Reply-To: <3963110.nb0tCvxbkm@xps> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGI5MTk5NDktNWRkNi00ZTg1LTk5MjYtNGM1Y2MwODgxZDkwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQWtkZ0J4SmR1eVQ1OHpwVEhMaFA1c3YrVWdrVzF1U2EwQzdOWExSZmMrS0o2ZEU5bWkyN1hLdlwvS1wvY2crMnM4In0= dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 13 Aug 2019 08:46:33 +0200 Subject: Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday 5 August 2019 16:13 > To: David Marchand > Cc: dev ; Burakov, Anatoly ; > Richardson, Bruce ; Kinsella, Ray > ; Traynor, Kevin ; Stephen > Hemminger > Subject: Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol > removal >=20 > 05/08/2019 17:05, David Marchand: > > On Mon, Aug 5, 2019 at 4:39 PM Thomas Monjalon > wrote: > > > 02/08/2019 15:29, David Marchand: > > > > This symbol has been deprecated for quite some time. > > > > Let's drop it in the next release. > > > > --- > > > > --- a/doc/guides/rel_notes/deprecation.rst > > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > > +* eal: The ``rte_malloc_virt2phy`` function has been deprecated > > > > +and replaced > > > > + by ``rte_malloc_virt2iova`` since v17.11 and will be removed > in DPDK 19.11. > > > > > > For this patch and another one about removing > > > rte_cpu_check_supported(), I have a general comment on the date of > removal. > > > > > > As was stated recently in the contribution guide: > > > http://git.dpdk.org/dpdk/commit/?id=3D7abe4a24cc > > > "Deprecated APIs are removed completely just after the next > LTS." > > > > > > The idea behind this policy is to avoid removals during LTS > > > releases, in order to have at least one release before X.11 LTS for > > > end users to prepare replacing the usage of the removed API. > > > > > > Does it make sense to postpone any API removal after 19.11? > > > > Those symbols have been marked as deprecated for a long time. > > Users had to either disable Werror or they actually migrated to the > new apis. > > If they chose the lazy way of not migrating to the new apis, I > suspect > > they forgot about it and/or they won't look at the release notes. >=20 > Yes I agree. > That's why they can be surprised when hitting the removal. > Avoiding this removal in LTS release is one more care for the lazy > users. The question: is too much caution? >=20 > > I don't particularly have a problem with waiting for 20.02, those are > > easy to remove anyway. >=20 >=20 My 2c is that if they are have signalled as deprecated since v17.11. They are fair game for removal at this point.=20 Ray K