From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id EDCDF1C52 for ; Mon, 11 Apr 2016 09:24:26 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id n3so91729482wmn.0 for ; Mon, 11 Apr 2016 00:24:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=/bagPz7mmZ5IvFebk4NlCKSsRNm/UbrQVy8HW/S9Pyo=; b=R3qm0jsBqaJWmmCb37Izj+JRwCU+aVNXbIcUTKt+z401ZXtzMG4hrOVy8fueNA43tk 6GYfxPp7X8GiQNyxULnxxVAQqzN4E0XmGw1clPabInS+IxIoZ0+uMW0I7oazMN3TRR2D fSFze3Z+URpZLT4/XhnyRHGEkXQeSj3i08UAjYN32/SYkrdTWyzQ2aiWEfVf4B142QHs MPXJWamEO+VytzJ4QpL0RSpL+cxKyNJHFbNuJI1YaCrtYMRr/S96SD5C1/ZQQJuBwl21 QvdWYOVcwOgQqR9al+5S8fQ1CR6CtCbvaCdjj5h7wE4LTVNblMvb5Ldss+XjuVLqYGSV 9Fkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=/bagPz7mmZ5IvFebk4NlCKSsRNm/UbrQVy8HW/S9Pyo=; b=m/hEyqrgLtmJPGUwx0iZ2EJ7wgdHH4bCJJGiabF2EfhLE2W2GpxqTFcsXPuujPMOAi N+cigo7SxoMAXYRb5jgsRiN6NiYQf2Jc2ILubJY7ghpJ4zHWwTFeedb2/t25u88sWl2Q Mm33f9jKZ7XaioQ9blGIM2i71gQEQv1ybR2Euy5mmeVpap/dxlbr580AL88yBkEcxz3b 82dBBOKQM/HGzj8ybkhjgZmVKxRywYznV3Yq/y8H9CR/4gtVKK2+M4dxb5M4FDfMmv5u A6NOjroaRxfWAjmexsx6SuFEcHCTWJvoYFA2svGpj7l/+20VX/wC103gOzJ0yad6mqd1 mZOg== X-Gm-Message-State: AOPr4FWNUdr5zWoWe6h4dTEPLj09DbhsSA3gzM6Og6W5dF/ZC7othLAKtCoCbR4Q4C92vZjI X-Received: by 10.28.24.195 with SMTP id 186mr4994227wmy.30.1460359466800; Mon, 11 Apr 2016 00:24:26 -0700 (PDT) Received: from xps13.localnet (245.111.75.86.rev.sfr.net. [86.75.111.245]) by smtp.gmail.com with ESMTPSA id 7sm15815763wmn.7.2016.04.11.00.24.25 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 11 Apr 2016 00:24:25 -0700 (PDT) From: Thomas Monjalon To: Marvin Liu Cc: dev@dpdk.org Date: Mon, 11 Apr 2016 09:24:24 +0200 Message-ID: <76861959.Vz3qnGk6Ag@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1460346357-26592-1-git-send-email-yong.liu@intel.com> References: <1460346357-26592-1-git-send-email-yong.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Subject: Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix build with libvirt version < 0.9.3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2016 07:24:27 -0000 2016-04-11 11:45, Marvin Liu: > vm_power_manager utilize libvirt API virDomainGetVcpuPinInfo for > retrieve domU vcpu information. This API implemented from version 0.9= .3. > Suse11 SP3 32bit default libvirt version is 0.8.8, so there'll be bui= ld > error. Add judgement in sample Makefile to skip unsupport environment= . >=20 > examples/vm_power_manager/channel_manager.c: In function > =E2=80=98update_pcpus_mask=E2=80=99: > channel_manager.c:117:3: error: implicit declaration of function > =E2=80=98virDomainGetVcpuPinInfo=E2=80=99 >=20 > Fixes: 2e099bc5d104 ("fix split of compiler and linker options") I think the issue has always been there: Fixes: e8ae9b662506 ("examples/vm_power: channel manager and monitor in= host") > +LIBVIRT_COMMON =3D libvirt-common.h > +LIBVIRT_HEADER =3D libvirt.h > +INCLUDE_PATH =3D /usr/include/libvirt/ You cannot assume it will be installed in this directory. Please check the version with the standard pkg-config: =09pkg-config --atleast-version=3D0.9.3 libvirt It can work even in cross compilation environment thanks to PKG_CONFIG_= PATH.