From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54ADF45B90; Mon, 21 Oct 2024 10:52:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EA27402C6; Mon, 21 Oct 2024 10:52:26 +0200 (CEST) Received: from fout-a1-smtp.messagingengine.com (fout-a1-smtp.messagingengine.com [103.168.172.144]) by mails.dpdk.org (Postfix) with ESMTP id 5ADD74026B for ; Mon, 21 Oct 2024 10:52:24 +0200 (CEST) Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.phl.internal (Postfix) with ESMTP id C8CFC1380274; Mon, 21 Oct 2024 04:52:23 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Mon, 21 Oct 2024 04:52:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1729500743; x=1729587143; bh=zGT+FaWtyHhyb/Bt/jAp7ERf7EVwcgakSzQv9ij9zZA=; b= XB1XU8Hiap7S6JWlk7E64MDNDKeifRgrI7IOkKo7Z4OoaddDzXpO51nUZNnjh6Qd uvZFYCIZLvbFPyDzD6Sg7Il1mCKuCXDRV8sHTqxJPMpGQwheSSpRFw8EccXb1ohB Mdya3QVtsBCFPVYPK09NGUCDRXB8AbtR3KmtKqI3vivD9lDt+l9E+SEu/ChRNoEt EOhOd8rbsrITO/NHJjo4ZTy2sxNBcsVwbchjEGf8kwJazsMNtkK5+EWoAMJ/j9DH p5ytfdAtBSpEV65Od7RASTvYZBb6iHtwLMKQ0grDWg5QzwC/1Cc9QjmhH29WrRfg BT+64e/wPELL+QfRyf7uIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1729500743; x= 1729587143; bh=zGT+FaWtyHhyb/Bt/jAp7ERf7EVwcgakSzQv9ij9zZA=; b=g JmMnliN24rUV83zCCFyk6KK5+5tHDQ6aB+1Pc2SsyzHcwOjL7/jDODBFyujW9EUg Sdg30vdGurWO3YWfbp2M96hRrrVTDu7FBMs0ScUTbahjHyWpykms/8lwF9CDt13t OzPVckV9hBoAUkmxfrKzNYvowtJQ8mgW1JMs/A4jrnLdowmrsCfIiYSBMTsw4Wcx xvKz/8bzR97VXjoTdJaeHTfJwdWIOIzXOzNzVHyOEIgGSXmMyZemnlfdiE6dWMqV TwETkQPSMeljqnIet4/tcQY1BCEmCaRQjm622pZqAWNsJ0DC+nmAtQaKmOZ3Upgv qahTyCwADM+VpYP7+mANw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehledgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeehpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopeifrghngh drjhhunhhlohhnghduseiithgvrdgtohhmrdgtnhdprhgtphhtthhopeguvghvseguphgu khdrohhrghdprhgtphhtthhopehsthgvphhhvghnsehnvghtfihorhhkphhluhhmsggvrh drohhrghdprhgtphhtthhopehfvghrrhhuhhdrhihighhithesrghmugdrtghomhdprhgt phhtthhopeifrghnghdrhihonhhgudelseiithgvrdgtohhmrdgtnh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Oct 2024 04:52:22 -0400 (EDT) From: Thomas Monjalon To: Junlong Wang Cc: dev@dpdk.org, stephen@networkplumber.org, ferruh.yigit@amd.com, wang.yong19@zte.com.cn Subject: Re: [PATCH v6 6/9] net/zxdh: add zxdh get device backend infos Date: Mon, 21 Oct 2024 10:52:21 +0200 Message-ID: <7688020.A5hrfCrGMc@thomas> In-Reply-To: <20241016081824.1808433-5-wang.junlong1@zte.com.cn> References: <20241016081647.1808333-2-wang.junlong1@zte.com.cn> <20241016081824.1808433-1-wang.junlong1@zte.com.cn> <20241016081824.1808433-5-wang.junlong1@zte.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/10/2024 10:18, Junlong Wang: > --- a/drivers/net/zxdh/zxdh_msg.c > +++ b/drivers/net/zxdh/zxdh_msg.c > @@ -18,8 +18,6 @@ > #define REPS_INFO_FLAG_USABLE 0x00 > #define BAR_SEQID_NUM_MAX 256 > > -#define ZXDH_BAR0_INDEX 0 > - > #define PCIEID_IS_PF_MASK (0x0800) > #define PCIEID_PF_IDX_MASK (0x0700) > #define PCIEID_VF_IDX_MASK (0x00ff) > @@ -43,7 +41,6 @@ > #define FW_SHRD_OFFSET (0x5000) > #define FW_SHRD_INNER_HW_LABEL_PAT (0x800) > #define HW_LABEL_OFFSET (FW_SHRD_OFFSET + FW_SHRD_INNER_HW_LABEL_PAT) > -#define ZXDH_CTRLCH_OFFSET (0x2000) > #define CHAN_RISC_SPINLOCK_OFFSET (BAR0_SPINLOCK_OFFSET - BAR0_CHAN_RISC_OFFSET) > #define CHAN_PFVF_SPINLOCK_OFFSET (BAR0_SPINLOCK_OFFSET - BAR0_CHAN_PFVF_OFFSET) > #define CHAN_RISC_LABEL_OFFSET (HW_LABEL_OFFSET - BAR0_CHAN_RISC_OFFSET) Removing code is strange here. Maybe it should have been placed somewhere else initially?