From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2E915A0096 for <public@inbox.dpdk.org>; Mon, 3 Jun 2019 11:42:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2A99C2C36; Mon, 3 Jun 2019 11:42:54 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 959F428F3 for <dev@dpdk.org>; Mon, 3 Jun 2019 11:42:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EE2A822182; Mon, 3 Jun 2019 05:42:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 03 Jun 2019 05:42:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Tjv2L6Zcvc1eAa0+CD8epevmMnLBqRUMui0Sq7P792s=; b=SQbwNetckpAp mwiYm9hyLtC3bQGDP/0Tq3vRjq+jTeVZyF8JD1cTkbQEiZsSMN8J5sos4i63ruf1 Mk95Hf1AOPv5tqiASkO8nT0xdW7j+Lgqqc34Cw9jcnG4ehM9aopFyFlP7I9x3QF4 r0G/hJa8uOMOx55PVIwSuhq5w7J5Oac= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Tjv2L6Zcvc1eAa0+CD8epevmMnLBqRUMui0Sq7P79 2s=; b=z6NY5atn80DiPcvCEGDPJoG3EDbYob8nAdRPluDnOQaPx5uugSnux5hUv epRJAcim5znis84hdr4LCAtBsF02yAF43OQEM7r+lJNeLKgikquMXWEnS0ufeLZh 2qpurjrZN1b0GIoFCUssRx153egmBSguAsgfjfQJzoo+dMO9IDfr51l85aD7SSQl pqbr5s0tNPpoJTk1dAC8DpLX0te4D26Sg19wSMrWkIsbmhZtlZrkGKCT3cHEEf+F XB2sKzU5CKjSWVlHtIEt//2Y3WMsWwP9vfXRHZL1Whl0b73uOAz98mrbgpgjwFu1 PuiSbtIuZ4j2HLryRODtmSyd0oAlw== X-ME-Sender: <xms:m-v0XGRr6psXiZLLOv0IzTjB6GIwKiN0XY5Foc1DtwjI4DUaKbw02w> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudefjedgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: <xmx:m-v0XFIjvNuAouftcO_ne19hzHFbFZUJ51uTBSBqKIefVTSj7KsmxQ> <xmx:m-v0XM80kVFhzFUAB2nlQNThel0LD6hc_BOUcnl_XyKLXIeyNywHhw> <xmx:m-v0XFCk9pukQyRifhsI5XXL9tUXTEsRe2qUhN7P01PK6zfhA2nCzw> <xmx:m-v0XDhUlwgaNet6-M0kiXCGe3aq0oWbbW57SV6Vex6Py8PDrPCsuA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 71D3A38008C; Mon, 3 Jun 2019 05:42:50 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Bruce Richardson <bruce.richardson@intel.com>, "Burakov, Anatoly" <anatoly.burakov@intel.com>, David Marchand <david.marchand@redhat.com> Cc: dev <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org> Date: Mon, 03 Jun 2019 11:42:48 +0200 Message-ID: <7690473.PLrV9C041b@xps> In-Reply-To: <20190530101555.GB1107@bricha3-MOBL.ger.corp.intel.com> References: <cover.1559147228.git.anatoly.burakov@intel.com> <e5de05b0-d7c9-17a4-6c61-56d3e5fa5d6e@intel.com> <20190530101555.GB1107@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 00/25] Make shared memory config non-public X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 30/05/2019 12:15, Bruce Richardson: > On Thu, May 30, 2019 at 09:07:44AM +0100, Burakov, Anatoly wrote: > > On 29-May-19 9:11 PM, David Marchand wrote: > > > On the names of the functions, could we have something shorter ? > > > The prefix rte_eal_mcfg_ is not necessary from my pov. > > > > I can drop the mcfg, but IMO all of these locking functions should be kept > > under one namespace, and rte_eal_ is too broad. > > I think most/all developers are aware that memory is part of eal, so > rte_mcfg_ prefix (or rte_memcfg) might work. Why not being explicit with "rte_mem_config_", same as the structure?