From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20089.outbound.protection.outlook.com [40.107.2.89]) by dpdk.org (Postfix) with ESMTP id B0540493D for ; Wed, 1 May 2019 02:43:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vD5rbXjybuTF/grXRQtB0rZMR5yPSKE1B1L6MTkbVqE=; b=RNDiRbD4k0wKr+rapBVpVWHJViCVGoxRTijT8yBAuh+SH5WODL64yOQefJ6oPnaIjt/c4Ifn/KVVUfdJnO3vovUtLUBgMhN4p8TelDPoysS+Ij6/7NjpCOqa2EnnQoCFEEK4iVM+aPKkNbCnnnflsO+MM9xzSfljY+DntQ27OcU= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3996.eurprd05.prod.outlook.com (52.134.65.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.15; Wed, 1 May 2019 00:43:23 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98%5]) with mapi id 15.20.1856.008; Wed, 1 May 2019 00:43:23 +0000 From: Yongseok Koh To: Stephen Hemminger CC: Shahaf Shuler , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow Thread-Index: AQHU/4eTD0s19/fX1k2gVK/oXjWvrKZVLHeAgABCOwA= Date: Wed, 1 May 2019 00:43:23 +0000 Message-ID: <769F5F97-2566-4826-89BB-441B97481E44@mellanox.com> References: <20190430190426.44018-1-yskoh@mellanox.com> <20190430134619.36cc9b21@hermes.lan> In-Reply-To: <20190430134619.36cc9b21@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: de565a9c-f9e8-458c-678c-08d6cdce042f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB3996; x-ms-traffictypediagnostic: DB3PR0502MB3996: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 00246AB517 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(39860400002)(366004)(396003)(346002)(51914003)(199004)(189003)(33656002)(476003)(36756003)(53546011)(2616005)(446003)(14444005)(6916009)(76176011)(11346002)(86362001)(256004)(26005)(8676002)(66066001)(186003)(102836004)(6506007)(99286004)(6486002)(7736002)(54906003)(229853002)(81156014)(8936002)(305945005)(5660300002)(81166006)(83716004)(4326008)(14454004)(478600001)(66946007)(3846002)(76116006)(25786009)(2906002)(66476007)(91956017)(66556008)(64756008)(66446008)(82746002)(73956011)(53936002)(316002)(71200400001)(6246003)(486006)(68736007)(6512007)(6436002)(71190400001)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3996; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: P5sTXCGxUClS/DfzdrYalpFIIbAZVYc00oRbcwll899FgAeQ8pttU518CvIy5d7kw7oiwiOJtlVTU3Q0bIdTKZbYqFLnUYU4Wd29uwDza5aAPKcmxpCqMRwCuvOB3ufDDxENG0YmME25tKsNcsdQx6OJWcj/vUzv5w+uEjnGeGzRqn/dWGpqNln1o9hxIpo1ZJ10jKpSf+n+ijsCoDqkjtOMFpV+JBxY4APktNk0lGnpQ/egUZHPThXVY8KGq1EmPvTGa/ln6ihRZ+IYGDad0jUMwAu1SQVaNF6gUwTYzoCUOUz8Q9mtL2c40+4Nt89vOGsJ7vlJG+Z593/GGOVIArpkQzchR/cSvPCIP++qwir7fXaNbUUMoYCkYHFCGr4SHE1lb3Q3tXf9t0EqrNzkqEkjcTGde1qDbCTuic5v6Fw= Content-Type: text/plain; charset="us-ascii" Content-ID: <40FAAB4695DBC34182C4CA6A1DA26412@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: de565a9c-f9e8-458c-678c-08d6cdce042f X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2019 00:43:23.3164 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3996 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 May 2019 00:43:26 -0000 > On Apr 30, 2019, at 1:46 PM, Stephen Hemminger wrote: >=20 > On Tue, 30 Apr 2019 12:04:26 -0700 > Yongseok Koh wrote: >=20 >> + priv->sh->device_attr.orig_attr.max_qp_wr) { >> + DRV_LOG(DEBUG, >> + "port %u Tx WQEBB count exceeds the limit (%d)," >> + " try smaller queue size again", >> + dev->data->port_id, >=20 > The patch looks good, but it could be improved to make life easier > for the users. >=20 > This is an error, why not print it at NOTICE level since DEBUG messages > are usually suppressed. Okay, better to set ERROR. > Please don't break long lines in log messages. That doesn't add new-line and mlx5 specific coding style. > The latter part of the message > is obvious, why not skip it. Because not all users know what WQEBB means, I wanted to make user's life e= asier by informing what to do. > Also since max_qp_wr is __u32, the print format should be %u It was copied from the removing line but agree to change. > Instead: > DRV_LOG(NOTICE, > "port %u Tx WQEBB count (%u) exceeds the limit (%u)", > dev->data->port_id, > txq_calc_wqebb_cnt(tmpl), > priv->sh->device_attr.orig_attr.max_qp_wr); >=20 > Also, should it have a Fixes: tag to backport to stable? Okay, no harm to give more information. Thanks for the review. Yongseok From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C2C2FA0679 for ; Wed, 1 May 2019 02:43:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E87AE4CA6; Wed, 1 May 2019 02:43:28 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20089.outbound.protection.outlook.com [40.107.2.89]) by dpdk.org (Postfix) with ESMTP id B0540493D for ; Wed, 1 May 2019 02:43:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vD5rbXjybuTF/grXRQtB0rZMR5yPSKE1B1L6MTkbVqE=; b=RNDiRbD4k0wKr+rapBVpVWHJViCVGoxRTijT8yBAuh+SH5WODL64yOQefJ6oPnaIjt/c4Ifn/KVVUfdJnO3vovUtLUBgMhN4p8TelDPoysS+Ij6/7NjpCOqa2EnnQoCFEEK4iVM+aPKkNbCnnnflsO+MM9xzSfljY+DntQ27OcU= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3996.eurprd05.prod.outlook.com (52.134.65.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.15; Wed, 1 May 2019 00:43:23 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::e8d5:4aff:902d:6e98%5]) with mapi id 15.20.1856.008; Wed, 1 May 2019 00:43:23 +0000 From: Yongseok Koh To: Stephen Hemminger CC: Shahaf Shuler , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow Thread-Index: AQHU/4eTD0s19/fX1k2gVK/oXjWvrKZVLHeAgABCOwA= Date: Wed, 1 May 2019 00:43:23 +0000 Message-ID: <769F5F97-2566-4826-89BB-441B97481E44@mellanox.com> References: <20190430190426.44018-1-yskoh@mellanox.com> <20190430134619.36cc9b21@hermes.lan> In-Reply-To: <20190430134619.36cc9b21@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: de565a9c-f9e8-458c-678c-08d6cdce042f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB3996; x-ms-traffictypediagnostic: DB3PR0502MB3996: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 00246AB517 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(39860400002)(366004)(396003)(346002)(51914003)(199004)(189003)(33656002)(476003)(36756003)(53546011)(2616005)(446003)(14444005)(6916009)(76176011)(11346002)(86362001)(256004)(26005)(8676002)(66066001)(186003)(102836004)(6506007)(99286004)(6486002)(7736002)(54906003)(229853002)(81156014)(8936002)(305945005)(5660300002)(81166006)(83716004)(4326008)(14454004)(478600001)(66946007)(3846002)(76116006)(25786009)(2906002)(66476007)(91956017)(66556008)(64756008)(66446008)(82746002)(73956011)(53936002)(316002)(71200400001)(6246003)(486006)(68736007)(6512007)(6436002)(71190400001)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3996; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: P5sTXCGxUClS/DfzdrYalpFIIbAZVYc00oRbcwll899FgAeQ8pttU518CvIy5d7kw7oiwiOJtlVTU3Q0bIdTKZbYqFLnUYU4Wd29uwDza5aAPKcmxpCqMRwCuvOB3ufDDxENG0YmME25tKsNcsdQx6OJWcj/vUzv5w+uEjnGeGzRqn/dWGpqNln1o9hxIpo1ZJ10jKpSf+n+ijsCoDqkjtOMFpV+JBxY4APktNk0lGnpQ/egUZHPThXVY8KGq1EmPvTGa/ln6ihRZ+IYGDad0jUMwAu1SQVaNF6gUwTYzoCUOUz8Q9mtL2c40+4Nt89vOGsJ7vlJG+Z593/GGOVIArpkQzchR/cSvPCIP++qwir7fXaNbUUMoYCkYHFCGr4SHE1lb3Q3tXf9t0EqrNzkqEkjcTGde1qDbCTuic5v6Fw= Content-Type: text/plain; charset="UTF-8" Content-ID: <40FAAB4695DBC34182C4CA6A1DA26412@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: de565a9c-f9e8-458c-678c-08d6cdce042f X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2019 00:43:23.3164 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3996 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190501004323.aQliTk9E3qfgGwLjrRxTK75KGXXoFIS_5J1chQ4j_-w@z> > On Apr 30, 2019, at 1:46 PM, Stephen Hemminger wrote: >=20 > On Tue, 30 Apr 2019 12:04:26 -0700 > Yongseok Koh wrote: >=20 >> + priv->sh->device_attr.orig_attr.max_qp_wr) { >> + DRV_LOG(DEBUG, >> + "port %u Tx WQEBB count exceeds the limit (%d)," >> + " try smaller queue size again", >> + dev->data->port_id, >=20 > The patch looks good, but it could be improved to make life easier > for the users. >=20 > This is an error, why not print it at NOTICE level since DEBUG messages > are usually suppressed. Okay, better to set ERROR. > Please don't break long lines in log messages. That doesn't add new-line and mlx5 specific coding style. > The latter part of the message > is obvious, why not skip it. Because not all users know what WQEBB means, I wanted to make user's life e= asier by informing what to do. > Also since max_qp_wr is __u32, the print format should be %u It was copied from the removing line but agree to change. > Instead: > DRV_LOG(NOTICE, > "port %u Tx WQEBB count (%u) exceeds the limit (%u)", > dev->data->port_id, > txq_calc_wqebb_cnt(tmpl), > priv->sh->device_attr.orig_attr.max_qp_wr); >=20 > Also, should it have a Fixes: tag to backport to stable? Okay, no harm to give more information. Thanks for the review. Yongseok