From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 3196AEE2B for ; Wed, 9 May 2018 20:31:17 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8868C4059FEB; Wed, 9 May 2018 18:31:16 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-116-87.ams2.redhat.com [10.36.116.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id B31A910848F; Wed, 9 May 2018 18:31:15 +0000 (UTC) To: Ferruh Yigit , Konstantin Ananyev , dev@dpdk.org References: <1523630598-24606-2-git-send-email-konstantin.ananyev@intel.com> <1525437945-8207-6-git-send-email-konstantin.ananyev@intel.com> <0592a009-5fa8-a109-a1e2-9d2bbc6c4cc5@intel.com> From: Kevin Traynor Organization: Red Hat Message-ID: <76a56efc-70ab-dc24-dda7-526386262b64@redhat.com> Date: Wed, 9 May 2018 19:31:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <0592a009-5fa8-a109-a1e2-9d2bbc6c4cc5@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 09 May 2018 18:31:16 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 09 May 2018 18:31:16 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'ktraynor@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v5 5/8] testpmd: new commands to load/unload BPF filters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 18:31:17 -0000 On 05/09/2018 06:09 PM, Ferruh Yigit wrote: > On 5/4/2018 1:45 PM, Konstantin Ananyev wrote: >> Introduce new testpmd commands to load/unload RX/TX BPF-based filters. >> >> Signed-off-by: Konstantin Ananyev >> --- >> app/test-pmd/bpf_sup.h | 25 ++++++++ >> app/test-pmd/cmdline.c | 149 +++++++++++++++++++++++++++++++++++++++++++++++ >> app/test-pmd/meson.build | 2 +- >> 3 files changed, 175 insertions(+), 1 deletion(-) >> create mode 100644 app/test-pmd/bpf_sup.h >> >> diff --git a/app/test-pmd/bpf_sup.h b/app/test-pmd/bpf_sup.h >> new file mode 100644 >> index 000000000..35f91a07f >> --- /dev/null >> +++ b/app/test-pmd/bpf_sup.h >> @@ -0,0 +1,25 @@ >> +/* SPDX-License-Identifier: BSD-3-Clause >> + * Copyright(c) 2010-2017 Intel Corporation >> + */ >> + >> +#ifndef _BPF_SUP_H_ >> +#define _BPF_SUP_H_ >> + >> +#include >> +#include >> +#include > > This makes testpmd depends to librte_bpf unconditionally. What do you think > using RTE_LIBRTE_BPF macro to make it possible to disable bpf library? > +1 > <...> > >> @@ -16695,6 +16842,8 @@ cmdline_parse_ctx_t main_ctx[] = { >> (cmdline_parse_inst_t *)&cmd_set_port_tm_node_parent, >> (cmdline_parse_inst_t *)&cmd_port_tm_hierarchy_commit, >> (cmdline_parse_inst_t *)&cmd_cfg_tunnel_udp_port, >> + (cmdline_parse_inst_t *)&cmd_operate_bpf_ld_parse, >> + (cmdline_parse_inst_t *)&cmd_operate_bpf_unld_parse, > > It can be better to move testpmd_funcs.rst updates in doc patch into this patch, > it helps confirming the both doc and patch. >