From: fengchengwen <fengchengwen@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Jie Hai <haijie1@huawei.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>, <lihuisong@huawei.com>
Subject: Re: [PATCH 4/4] net/hns3: support outer VLAN flow match
Date: Mon, 21 Oct 2024 09:47:35 +0800 [thread overview]
Message-ID: <76e79c85-44b8-4faf-b017-6ef2f46e5663@huawei.com> (raw)
In-Reply-To: <20241018094127.0b3b5a33@hermes.local>
On 2024/10/19 0:41, Stephen Hemminger wrote:
> On Fri, 18 Oct 2024 14:19:41 +0800
> Jie Hai <haijie1@huawei.com> wrote:
>
>> @@ -306,11 +324,16 @@ hns3_parse_devargs(struct rte_eth_dev *dev)
>> &hns3_parse_dev_caps_mask, &dev_caps_mask);
>> (void)rte_kvargs_process(kvlist, HNS3_DEVARG_MBX_TIME_LIMIT_MS,
>> &hns3_parse_mbx_time_limit, &mbx_time_limit_ms);
>> - if (!hns->is_vf)
>> + if (!hns->is_vf) {
>> (void)rte_kvargs_process(kvlist,
>> HNS3_DEVARG_FDIR_VALN_MATCH_MODE,
>> &hns3_parse_vlan_match_mode,
>> &hns->pf.fdir.vlan_match_mode);
>> + (void)rte_kvargs_process(kvlist,
>> + HNS3_DEVARG_FDIR_TUPLE_CONFIG,
>> + &hns3_parse_fdir_tuple_config,
>> + &hns->pf.fdir.tuple_cfg);
>> + }
>>
>
> Side question, why the casts to void here?
> Is there some tool that is complaining (like old lint), or is there
> some error handling missing.
Yes, it will output a code check warning if don't add (void).
In our design, there will be a warning trace if user input an invalid option (and nothing changed),
so it is OK for don't process the function's return value.
prev parent reply other threads:[~2024-10-21 1:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 6:19 [PATCH 0/4] net/hns3: support more flow pattern match Jie Hai
2024-10-18 6:19 ` [PATCH 1/4] net/hns3: restrict FDIR only support one tunnel header Jie Hai
2024-10-18 6:19 ` [PATCH 2/4] net/hns3: support general tunnel flow match Jie Hai
2024-10-18 6:19 ` [PATCH 3/4] net/hns3: add FDIR VLAN match mode param string Jie Hai
2024-10-18 6:19 ` [PATCH 4/4] net/hns3: support outer VLAN flow match Jie Hai
2024-10-18 16:41 ` Stephen Hemminger
2024-10-21 1:47 ` fengchengwen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76e79c85-44b8-4faf-b017-6ef2f46e5663@huawei.com \
--to=fengchengwen@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=haijie1@huawei.com \
--cc=lihuisong@huawei.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).