From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4816745B8B;
	Mon, 21 Oct 2024 03:47:41 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CDEE94021F;
	Mon, 21 Oct 2024 03:47:40 +0200 (CEST)
Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])
 by mails.dpdk.org (Postfix) with ESMTP id 82C17400EF
 for <dev@dpdk.org>; Mon, 21 Oct 2024 03:47:38 +0200 (CEST)
Received: from mail.maildlp.com (unknown [172.19.163.17])
 by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4XWyp01SZ4z2Df05;
 Mon, 21 Oct 2024 09:46:16 +0800 (CST)
Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10])
 by mail.maildlp.com (Postfix) with ESMTPS id 5754B1A0188;
 Mon, 21 Oct 2024 09:47:36 +0800 (CST)
Received: from [10.67.121.161] (10.67.121.161) by
 dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2507.39; Mon, 21 Oct 2024 09:47:36 +0800
Message-ID: <76e79c85-44b8-4faf-b017-6ef2f46e5663@huawei.com>
Date: Mon, 21 Oct 2024 09:47:35 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/4] net/hns3: support outer VLAN flow match
To: Stephen Hemminger <stephen@networkplumber.org>, Jie Hai
 <haijie1@huawei.com>
CC: <dev@dpdk.org>, <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Yisen
 Zhuang <yisen.zhuang@huawei.com>, <lihuisong@huawei.com>
References: <20241018061941.29960-1-haijie1@huawei.com>
 <20241018061941.29960-5-haijie1@huawei.com>
 <20241018094127.0b3b5a33@hermes.local>
Content-Language: en-US
From: fengchengwen <fengchengwen@huawei.com>
In-Reply-To: <20241018094127.0b3b5a33@hermes.local>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.161]
X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To
 dggpeml500024.china.huawei.com (7.185.36.10)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2024/10/19 0:41, Stephen Hemminger wrote:
> On Fri, 18 Oct 2024 14:19:41 +0800
> Jie Hai <haijie1@huawei.com> wrote:
> 
>> @@ -306,11 +324,16 @@ hns3_parse_devargs(struct rte_eth_dev *dev)
>>  			   &hns3_parse_dev_caps_mask, &dev_caps_mask);
>>  	(void)rte_kvargs_process(kvlist, HNS3_DEVARG_MBX_TIME_LIMIT_MS,
>>  			   &hns3_parse_mbx_time_limit, &mbx_time_limit_ms);
>> -	if (!hns->is_vf)
>> +	if (!hns->is_vf) {
>>  		(void)rte_kvargs_process(kvlist,
>>  					 HNS3_DEVARG_FDIR_VALN_MATCH_MODE,
>>  					 &hns3_parse_vlan_match_mode,
>>  					 &hns->pf.fdir.vlan_match_mode);
>> +		(void)rte_kvargs_process(kvlist,
>> +					 HNS3_DEVARG_FDIR_TUPLE_CONFIG,
>> +					 &hns3_parse_fdir_tuple_config,
>> +					 &hns->pf.fdir.tuple_cfg);
>> +	}
>>  
> 
> Side question, why the casts to void here?
> Is there some tool that is complaining (like old lint), or is there
> some error handling missing.

Yes, it will output a code check warning if don't add (void).

In our design, there will be a warning trace if user input an invalid option (and nothing changed),
so it is OK for don't process the function's return value.