From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80A3FA04DB; Fri, 16 Oct 2020 14:05:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C977A1ED6D; Fri, 16 Oct 2020 14:05:28 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A60E81ED6A; Fri, 16 Oct 2020 14:05:25 +0200 (CEST) IronPort-SDR: sC6xluO+Smgkz8jeqMrUPv87qIs6kA+vrzoIMPKzwAbS/bxVNbHzENTq9mIZZOLsTrEmSl2k7r wDGTcOA3Nv1w== X-IronPort-AV: E=McAfee;i="6000,8403,9775"; a="230789351" X-IronPort-AV: E=Sophos;i="5.77,382,1596524400"; d="scan'208";a="230789351" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 05:05:24 -0700 IronPort-SDR: DYROxyc6vyZJy/FetEt1pTXFPHDxWjiuL6kbvvV9bXBTsW7hO20OL2CA+zedXLW8plLYR3RF8y XSolWar9sn6A== X-IronPort-AV: E=Sophos;i="5.77,382,1596524400"; d="scan'208";a="531692141" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.19.66]) ([10.252.19.66]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 05:05:15 -0700 From: Ferruh Yigit To: Andrew Rybchenko , dev@dpdk.org Cc: Thomas Monjalon , Andrew Rybchenko , "techboard@dpdk.org" References: <1602600818-7473-1-git-send-email-arybchenko@solarflare.com> <8f8907cf-d905-c867-cf42-694d16b0a0cf@intel.com> Message-ID: <76f63a45-01a5-a3d1-2107-37fe8cf5ca2d@intel.com> Date: Fri, 16 Oct 2020 13:05:06 +0100 MIME-Version: 1.0 In-Reply-To: <8f8907cf-d905-c867-cf42-694d16b0a0cf@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] ethdev: unify error code if port ID is invalid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2020 4:32 PM, Ferruh Yigit wrote: > On 10/13/2020 3:53 PM, Andrew Rybchenko wrote: >> Use ENODEV as the error code if specified port ID is invalid. >> >> Signed-off-by: Andrew Rybchenko >> --- >>   lib/librte_ethdev/rte_ethdev.c | 44 ++++++++++++++++---------------- >>   lib/librte_ethdev/rte_ethdev.h | 46 +++++++++++++++++++++++----------- >>   2 files changed, 54 insertions(+), 36 deletions(-) >> >> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c >> index 5b7979a3b8..1f862f918a 100644 >> --- a/lib/librte_ethdev/rte_ethdev.c >> +++ b/lib/librte_ethdev/rte_ethdev.c >> @@ -784,7 +784,7 @@ rte_eth_dev_get_name_by_port(uint16_t port_id, char *name) >>   { >>       char *tmp; >> -    RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); >> +    RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > > Thanks Andrew, +1 to this error unification. > > This will be API change without deprecation notice, cc'ed techboard for it. > > If this should (almost) always return '-ENODEV', does it make sense to make > another wrapper macro for it, to prevent later other error types used again. > > And there are a few instances returning '-1', are they left intentionally? > Reviewed-by: Ferruh Yigit