From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD21845822; Tue, 20 Aug 2024 11:32:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AA204026C; Tue, 20 Aug 2024 11:32:05 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mails.dpdk.org (Postfix) with ESMTP id 83D32400D6 for ; Tue, 20 Aug 2024 11:32:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724146325; x=1755682325; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Swoy4KQJV5cCIu+CI8TYCQvZxoUIi9TalfLeSjBtHmE=; b=i9f57vOH4uvyhXNnNC7zXsTfCpnskygFePt924tyunJi4rD8q/tZuD8E hvMZE9YjpGqwBXIadwZ/ElMCwI1QMSw1nggqVdgkDsEHGCCwVbo5fh0IT Z8qtyh2lTAkbEIAMbfg4G8dm5blsCVe6tU3JlNzHJ6ePcBi+yB/QHC+Sr 3lTGWPaxeX+LaF1vAQR753S+jeW0BSVIXFpAvb9YKgFozdYshCVIyB6qI 4HwYuPhP5wIaGWJpyzhwHOloqAeCKUfphAxAAc2Y6CGT/hE9uZwBg0vN3 R5EIaCDVtnzWsqBUVU0M26bcMtqADIMI1aKXYY0t+RmXp8FXiJ24SV9I8 A==; X-CSE-ConnectionGUID: VlB86WHCTc+pe9QuYQgD0Q== X-CSE-MsgGUID: mw31YDNDRkKzBl+L+i9a/Q== X-IronPort-AV: E=McAfee;i="6700,10204,11169"; a="33821418" X-IronPort-AV: E=Sophos;i="6.10,161,1719903600"; d="scan'208";a="33821418" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2024 02:32:03 -0700 X-CSE-ConnectionGUID: PDIy/d4yQwCXOB+XAObaqw== X-CSE-MsgGUID: KVQXkplWQQWhpATzSO4KEQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,161,1719903600"; d="scan'208";a="65361392" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Aug 2024 02:32:02 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 20 Aug 2024 02:32:02 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 20 Aug 2024 02:32:01 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 20 Aug 2024 02:32:01 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 20 Aug 2024 02:32:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GVVi/3kp29iD9Hwa2iS1Wc7mQMqk/LeKZF8AVp8iXgaWNxusDyhTaN16mZRaDIN83xKsqHgr40PYk/ZfI1dCeykzsfyYzDDU3tqUuwyIl5KghG1uqSD6VMQxdiS6pmUmK1zkMmXdQTHEO94D0QQXHOY1OUea1Z13D2QCF4zf9qBgRu05f3p6rhvKPJQygYVLLILIvdBwK+2bFlHmjEzIxV6FpS3Uns2LumZe7+AFT6Lp1H3jxjC9oYjs6MR4WQTxDQFTKy/Fv4AD+xa0xdI0qJ/bKH2KQsFRG2GGzVse8IX664ZGXCZzblS50Es1+Ny1mchVGCcWlPUn7i5aiF5aEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6v19V/tFO+RR6i/NmdD6lctPJpxVZ6qSw5msjkx8dFI=; b=MGVq7tZnV15bMcZGwmQVj/Mz5vbWeCkgidvKcW7emnT+xdXMudFyPsu61PDLSdkvrpyusX8HGWW3v6lNsmgJI3GLmILIb432ZL2Ig/MoDAuvGljjYaYBTfiCXSEjn8Ars4afh7ocKaxtB3f6CERZid3FVE0U17JGKbPuP7SNf+1mbPgJMFi9i/NJnsOy7W4BbfvEYPFcn1LEH1x4GNBMYYFEVE4o8Eik0NwGLML72zs+9g65T66ed0VNvIoYGGEt6gWQkn+dHogsVP1jT+YbsIY+5ws4QoWO5HhYw4CTRi9PJU+/3X1AhK7tSAy2lQlttYLiMa5sNKk8A9udwhmVpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH7PR11MB6498.namprd11.prod.outlook.com (2603:10b6:510:1f1::21) by CO1PR11MB5027.namprd11.prod.outlook.com (2603:10b6:303:9d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.16; Tue, 20 Aug 2024 09:31:59 +0000 Received: from PH7PR11MB6498.namprd11.prod.outlook.com ([fe80::999a:425d:a211:5d30]) by PH7PR11MB6498.namprd11.prod.outlook.com ([fe80::999a:425d:a211:5d30%6]) with mapi id 15.20.7875.019; Tue, 20 Aug 2024 09:31:59 +0000 Message-ID: <770a909a-025e-49e5-909f-455e47953d0f@intel.com> Date: Tue, 20 Aug 2024 11:31:53 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] usertools/cpu_layout: update coding style To: Robin Jarry , CC: References: <4844fc3a4604ffef789702752ff04699ab5118db.1723810613.git.anatoly.burakov@intel.com> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB9PR06CA0004.eurprd06.prod.outlook.com (2603:10a6:10:1db::9) To PH7PR11MB6498.namprd11.prod.outlook.com (2603:10b6:510:1f1::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR11MB6498:EE_|CO1PR11MB5027:EE_ X-MS-Office365-Filtering-Correlation-Id: 051f59f5-9540-44f8-f3f3-08dcc0faf0d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VEhZT0lrN2F3cnBGTjVrU3Jqd2JUTENPM2tMS2x1b0dCN1pSa0RjaTdKWDlH?= =?utf-8?B?YnlDZWF2L0lOL20xMjdmS3gzdlVwTEdMeE5oRUtGUkJmdlJERnUyZXNNWmVy?= =?utf-8?B?UE5jRHRENldkbEhOMTZJajJxRjRKYjZubUtzSHZaZDBSckVEeTYydTJLcUd3?= =?utf-8?B?KzRncWl6WDMvMEhFOFZCSzhEYnpXYkVpNXo0MHJTRzhRcDJtUHlXNU5KcFh3?= =?utf-8?B?V3ZkT1lqTDZwK2lTT2NEdk01Y2ZxbGZzM0RiY3pLZ2NUeXUrckxNT2xUWXpB?= =?utf-8?B?a0xKS0Zod3dkMnJMbEsxbll5TUpEcVgxaHM2alN0TmFXZWtDUTRIVkRjcXR6?= =?utf-8?B?UHRJUHNEZkk3d2J4Mms4WmhUNXdUUVU3VmFrUG43TGQ4NlBzTWpyUDd4eVlp?= =?utf-8?B?OE81UnF5TUJHTm1KMGkvaktaTDJNWEJGTjdNM09MS1AvNlk0dUY5ZzU0MHJ6?= =?utf-8?B?M0F1eGxwNVJFM0x6V1l1NmFvWFdJMzlvWjlVa2IvaVJFRjFiYXFHbmtHYmFL?= =?utf-8?B?akxLWjhpaGZRNU5KQmpjTXFmR0loVFI4TFdkdDVDZU9jUWgzTERlVTR5WGcy?= =?utf-8?B?Y1dKQ2U3SS84T25XZ1FZUkpQRkMwSmdNWFdob3NJT0lmVTRSaVlCR2I3T3V6?= =?utf-8?B?eit2aUtqTlVhWEZnOVhtbTE0RS9lVjlYL1FUdTJXaEI3clNQWG9UaVZwOTM1?= =?utf-8?B?VXppdThFWkNkTE94S2RYOUpMbXIyYlNxcERSZGtTYWQ2cmUzTUZPOFlKS1FT?= =?utf-8?B?cEloQWd1S2NiWURjUVpCVEtFNkpwV0c4ZjZtMTZhZi8relp2bHZkT0pvRlZW?= =?utf-8?B?TENvSlFqNGFndDRSMWQvRVRwa1Z6aUl0Nzc1d2t6OWhPcEpHTjZPSzRhYlda?= =?utf-8?B?M1c0OHY1NGptckpQWDRVUFA4ZCsxdHkwMkRxYk9TWndEa1ppOENNTitFN3p5?= =?utf-8?B?S0ltc2NlMzlCT0JqNmRDaXN6dmRjRk1xNnR3MnA0UHZ6aTZnTkU0QUcvb1Jp?= =?utf-8?B?OUt1RXZGZlJRZ3JDY2JoQjhBdEwwMWNKeFRacUtab1FaT211Y1VhWUFPbmlv?= =?utf-8?B?clUzbzVEVDRLaTJJbzFNdjM2QVYraFgrZ0ZLWkovdWdMeXRZaXdrSnpkWjlr?= =?utf-8?B?ZENXeTM3QjR4aWFxbDQ5eTRGQkNqMXRENlQxWHp3UHVJcW13YjFHWlB2SU05?= =?utf-8?B?dFF0OE84aWdDVDV0VjdsbnRybVdtZHFQSU5aYmxtSVNWQWZtMm14VjEyQVhD?= =?utf-8?B?NXVncEp2N3RJTGg2aytsT0xiaThEalNhVmovbFFOYi93azB5elFiM0VucE9n?= =?utf-8?B?RjQ0NHVMU2UrcGVqaGQwU09UWDJ3M0FyMlhPcHgxK1FUYk1hYkpOZ2w1UFR2?= =?utf-8?B?MmxaOWZqRmd2bFF4VTB1UVpLY1RKMXU2dWkxWUxNVzkvSkVsc0cwdUFBTmEy?= =?utf-8?B?RDNuSGgzN0FBYWZ5cEt6NlZRL0lOU3Ntd2xHTW5WZzZnWG5rTklGNkZpZ1pm?= =?utf-8?B?Si9NbEdUcXErL0h1NFJGRXc3ekZHdE95K1JKaUUzaGZ3dGFjZWRrcEZqQm9o?= =?utf-8?B?OEZYWE1jdnd4YjFKYnR4dmVFcDBudlc1QTBZalYvU0tVOWpzeFl1QWI1NXBo?= =?utf-8?B?OFpteGtFaGxiN2p1NlpwQ1hUT0tCNXlVRWJpYVpNcVBsd1VnM1gvaGVCcUFR?= =?utf-8?B?am82R1lpeEVxZzVqU04yczYvNm9YU2JaRUl3YXRPL2lUOHhveklOcjkwTzdY?= =?utf-8?B?OTM1TENZeHBOZDhET1YvQlNiTjZWUzE5dVR0NDRWa0ZvTDVXbVFrL2trK2Y0?= =?utf-8?Q?ao2cAzNDcvJbiZRkYGmHGXudduvhmw6oocBrY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB6498.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SldveFl1VWNQOVRMRGNqTVptUmtIdnhNTXlwTzBlY2pxN0NLQnQ3dnJWQlZv?= =?utf-8?B?VDVxT1dKV3lNRlRXUEIxelhBR3o5V1o1clpnY2pZSmlhUmp3R052WDFRangz?= =?utf-8?B?bHliLzY1RHZuRXQxWGo0ejNmYldGcUlRR2dFS0JEdXd3dFhvbFpTeWlRa1g4?= =?utf-8?B?L293b3dxbjVxZlFiWW9NdUJ6b3B2Rk4zM3F6cUYxem5RK1Y5NGFQdFZGYTFo?= =?utf-8?B?NXlkTmZpSXJJK21jSmxhZUd1SDVsd1NDcmRTWkt0OEpDeTNTM3BqalU0YkVW?= =?utf-8?B?R3J5cDM4b1gwbU5mQlQ4NWVwbGk3aHh3ZFc2SXovb2FFMEpQVElFa2xXOWhN?= =?utf-8?B?TXloU0R6WExIUlBLWllMNU41MmJtSVhKV3Z3V0U3MzZZcUVBNDJyR2JGcUw1?= =?utf-8?B?TithcERNZlg1QXJJY0pCNHk4UjFUTmtROTdEajN0bmM1K0ttY0JrdG5ZYUVX?= =?utf-8?B?Wnc1eXZQNkFtTUd0d1hLdVgvK0pQM3R1WW43WmsvdENPL240YUdVZ1NyQy9W?= =?utf-8?B?MG0yaVZ5SENub2I2Z09SczJOVWRSTGNld0FiMU8xb0Jna2J1T3lBS0ZaYzM2?= =?utf-8?B?dXJKYWYyOGw1YXp3NjdRMEh5ZWJyU3lpMEpOTWJITDhKTTVSODljU01kd2Z6?= =?utf-8?B?c25rd1lJZlcxUW5PRmxsUjZjTEYvRmNFYUZnUEs5NzJwQVhZK1hIbGloTHBG?= =?utf-8?B?bmdYdy93cXgxcWlXU0ljWkgvNC95Nm94QUxXYmlsbWJzQVFWMDZadDZaaXFv?= =?utf-8?B?cG5JaEhscy9uQW14MWZwZmpGVEk1NVpXNUU0QklsaUJDTkxOWXpyY0RmUXJx?= =?utf-8?B?aE1rUUVOSGNIWWNFa0EyV2haMjU1Z0dRa2xvSnhKUk5PQUNSN0l4TWlOSDc1?= =?utf-8?B?NElXanE1S3RvcVJnd1J6eTliYXNZTDFhYm5zK3dTSXIyTCtPc3JRbWE2ckNS?= =?utf-8?B?OE1RY2hOejkxNHIyb2o4VEdXSHRQOG1sS1lXWW1WUVowNHJIZmdKWnlCT3p5?= =?utf-8?B?MTF4L085T3BNeUlFbmRhWjR3U0c1M2JFSllEVlpUZFY0WDMwWTEvTmZkbmJm?= =?utf-8?B?dm5zNk1aUWgrTElTK1Eva0trdlNMQ0R5RmtyMXhKK1pKWEJWanlTTkNJZk1Y?= =?utf-8?B?Nk8yQ2tBSllLM2ozaG5PU05jUDVicEZmemgvT1piYXlVM3pBYW0zRTVsOHVy?= =?utf-8?B?MGpFUnN3N3VVSXJYamNWQjc0czROSFFWZ3d0c0tkM0ZqRkk5SWVuZmNWKzhK?= =?utf-8?B?d00rNW12a1g2Q2dUSlVkNG9QbHZPbkpDT2FsRlV4Vmk3STFmaDQ0VVRxam9I?= =?utf-8?B?eGFSVG1GQmVXcHFvNVZMUWt0aWdTVnpoTHgwcU9aNFlqVGdhb3hNeCtUV1Za?= =?utf-8?B?RTRXOHIxVUFIeWdYdnhZeFJoVWpnU1FqTzRIRWs3VTI2NjY2QXM0UWJjcjRu?= =?utf-8?B?TmtoTXcvVnBlYnl4WHJBQkM2czdvdGREL21CRXRTNE5JT3VYbnZhN0NNNEIy?= =?utf-8?B?V3hPdXA0UjEzQmhiOFpXazRCN0dCcDc1Ui9XaksrbVpXb0JuTWVTbGtab2tF?= =?utf-8?B?d1czaC9lZCtxbnNXL2hjZFVwT2FjdXRudk82ZlNINHNmQWRmMHA1bDBZV3Zz?= =?utf-8?B?OU1kMklxNGxxT3YzYVJGdUJqSWl0WVh5eTlzYjZ2eGUzZnRuSWZrMFZDV045?= =?utf-8?B?UVR5cjJlOHJ3S3NRTjNjUWNFNEdwR3FYSEZEb1Y2Um1iWjNoSVp6Nm54SjhW?= =?utf-8?B?REx1aFVjWDg0TFJGaUUwUHV2NWFIUHlsaVkxbUo2MXc5NFhuaXMxTHJtSmVv?= =?utf-8?B?VXJQSGdHc1VzN0xYMTMzc0FOVEtTMUpSdnRSb0NwNDBMRjB6OGZLSXJDS245?= =?utf-8?B?WTZtQXppRHhZUWdJZGxFM25VeU44Q3czMkZveUF0bWJybTAxbC80aWVDSHNo?= =?utf-8?B?eGMyZDB6K0hGVklTOG4rQXc5ZGtmNTRTUG9hb05wdTdQT211b3dodHNJZjBE?= =?utf-8?B?d1ZheTlsOUZBNDhFWDdOUGs2YUhKM2MwdlcvYjlpUy9zeDZDQUxWcDlGcUtN?= =?utf-8?B?YlQxN3dqNlM4a1FoS0hGckMwZDJGb0xpZmI0V1lKOWJDMVRiUGJIaXdjYjBL?= =?utf-8?B?Q0o0dVE1MFBHZXVKYVdiczFvYmVNbGFZUjVNcUxwdWp5OC9CamRWVG9Wa3I0?= =?utf-8?B?Y1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 051f59f5-9540-44f8-f3f3-08dcc0faf0d8 X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6498.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2024 09:31:59.5960 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZljEhp+xEcC5whEhZ+pNbdCNL/gDgTT9hcC7yM5quk6785zSxJ+nB9Fr8/w58hAKBDbs8Tpp+hciIz8FMAcZvdL/b6oXyL16zrSEN3wBAxg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5027 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/2024 11:20 AM, Robin Jarry wrote: > Burakov, Anatoly, Aug 20, 2024 at 11:12: >> > FYI: if we change the minimum supported python version to 3.9, we >> could > even get rid of this import completely as builtin types `set`, >> `list`, > `tuple` and `dict` have become subscriptable. >> > >     https://peps.python.org/pep-0585/ >> > > You can use them directly instead of the symbols defined in the >> typing > module. E.g. the following becomes valid syntax: >> > >     def foo(a: list[set[int]]) -> dict[str, tuple[str]]: >> > > Instead of the more verbose: >> > >     def foo(a: T.List[T.Set[int]]) -> T.Dict[str, T.Tuple[str]]: >> > > But we can keep that for another day. >> > >> Incidentally, `dpdk-pmdinfo.py` script does use this syntax already. >> So either our minimum Python requirement is already met for this, or >> pmdinfo needs to be fixed to avoid it. > > I checked and unless I missed something, dpdk-pmdinfo.py uses the > symbols from the typing module for annotations. Not builtin container > types. It does both. Check e.g. line 147: def scrub_pci_ids(info: dict): > > But I think that we should bump the minimum python version to 3.9. 3.6 > is really old... > Well, that's not really up to me to decide :) -- Thanks, Anatoly